Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Wed, 1 Nov 2023 16:56:47 +0100
From:   Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To:     Dmitry Rokosov <ddrokosov@salutedevices.com>
Cc:     hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev,
        shakeelb@google.com, muchun.song@linux.dev,
        akpm@linux-foundation.org, kernel@sberdevices.ru,
        rockosov@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v1] tools/cgroup: introduce cgroup v2 memory.events
 listener
Message-ID: <eqvaejfo5uoz5m7e5g3wjgegfo4ribajdgu57fst3hu5m6gfa4@beugaul6pjjz>
References: <20231013184107.28734-1-ddrokosov@salutedevices.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="n2vvgyykebaacuqp"
Content-Disposition: inline
In-Reply-To: <20231013184107.28734-1-ddrokosov@salutedevices.com>
Precedence: bulk


--n2vvgyykebaacuqp
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi.

I think the tools/cgroup/cgroup_event_listener.c was useful in the past
to demonstrate the non-traditional API of cgroup.event_control with FDs
passing left and right.


On Fri, Oct 13, 2023 at 09:41:07PM +0300, Dmitry Rokosov <ddrokosov@saluted=
evices.com> wrote:
> This is a simple listener for memory events that handles counter
> changes in runtime. It can be set up for a specific memory cgroup v2.

Event files on v2 are based on more standard poll or inotify APIs so
they don't need such a (cgroup specific) demo. Additionally, the demo
program lists individual events, so it'd be a maintenance burden to keep
them in sync with the kernel implementation.

My .02=E2=82=AC,
Michal

--n2vvgyykebaacuqp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZUJ1PQAKCRAGvrMr/1gc
jvhcAQCUjTNWbtpe3NaqFagBmyBnMYqk8L1TerFT4RmMIyjOWwD/fvrevKAsZOxp
e6hUE/uLByN0AfsTqVtXgPo/ZtnjYwo=
=9QWy
-----END PGP SIGNATURE-----

--n2vvgyykebaacuqp--