Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Wed, 1 Nov 2023 17:05:39 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Ben Wolsieffer <ben.wolsieffer@hefring.com>
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Ben Whitten <ben.whitten@gmail.com>
Subject: Re: [PATCH] regmap: prevent noinc writes from clobbering cache
Message-ID: <b0e8c9f5-7aff-4adc-b5bc-d61c6107c07f@sirena.org.uk>
References: <20231101142926.2722603-2-ben.wolsieffer@hefring.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pw5rt8tNwUJb6Zfg"
Content-Disposition: inline
In-Reply-To: <20231101142926.2722603-2-ben.wolsieffer@hefring.com>
Precedence: bulk


--pw5rt8tNwUJb6Zfg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Nov 01, 2023 at 10:29:27AM -0400, Ben Wolsieffer wrote:
> Currently, noinc writes are cached as if they were standard incrementing
> writes, overwriting unrelated register values in the cache. Instead, we
> want to cache the last value written to the register, as is done in the
> accelerated noinc handler (regmap_noinc_readwrite).

Could you please add a kunit test for this?

--pw5rt8tNwUJb6Zfg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVChWMACgkQJNaLcl1U
h9Ca0wf/ZPDbcne+0fDI2ts571Uo57MW0irb1eXl6vypwEChkShmFPljDGlI4PP1
+DD0/Uw2RHR9L1b0HnQ6kYwu9HOlSnM5cIkvpEBTQ1bLicEB7pWWSCwSPmiiwHBr
6j2/G4lSqOWbHhTTgMc+Zw8ZSdSLdja2cYfQQwgNlWfAo7RQ9lclljWtBzxKnrXw
Z0P6yQ0TmiKn7L7PcEXMh3+tn6/4CH+lRqL4JxYfKvOyKHmmfqcJJuj1/BULRNQG
C5dpFretGVwsOm8fxNbyhyaO99kjUCYqxMB9HtfbcUYevmByuGbfiLSK4EAlsOGM
rU4ckTMHBgUHjvkTr6XnGMuksIdkRw==
=X9eS
-----END PGP SIGNATURE-----

--pw5rt8tNwUJb6Zfg--