Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
From:   "Liam R. Howlett" <Liam.Howlett@oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        "Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: [PATCH 01/12] maple_tree: Remove unnecessary default labels from switch statements
Date:   Wed,  1 Nov 2023 13:16:18 -0400
Message-Id: <20231101171629.3612299-2-Liam.Howlett@oracle.com>
In-Reply-To: <20231101171629.3612299-1-Liam.Howlett@oracle.com>
References: <20231101171629.3612299-1-Liam.Howlett@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tTsnPDae89Ck8qV2QyptLvn6NBkZKIwR47CtPOzE6mZDqJ9+clsu4K6fo6JU?=
 =?us-ascii?Q?/YaLMlQZdS9/Pfz16IESVpDNreNuWuhB7/ytvBoKf5lrbprAV6ewH1r97cI6?=
 =?us-ascii?Q?89/gqwJobjk1JRzrLsA+qBHL8CdP1nKTtl2JC5Y+mcEtQhy1bbpt40OE6btB?=
 =?us-ascii?Q?dN/vpAoUjnID2bkEBmiKlTs72yVeAWiUDqgK77zoDXCLLd+u7urvjY2cSm7H?=
 =?us-ascii?Q?PMA0agEFDdR7ycBGNPRDAs1NmgNzxDlltvSItuXXrd3Nc3q+xZguea4Ipr3v?=
 =?us-ascii?Q?GHcNPnwUptrVMkH6YRI2xdZ6dAZdCx28QV68mxsgR3LT46NBfsvuqbrANTGa?=
 =?us-ascii?Q?w3klYzz0riUv8bsCb4lT5YiuPUTLKo/O7cYnYDdORloF5RacdqGhlDKdw6dP?=
 =?us-ascii?Q?4f4DSeO/Sz6hzD/lOfi8IAnpHOzJOp2hbNBLWPGq40aBvIjt+IMtMSMiD2Wm?=
 =?us-ascii?Q?Remi8ygGyuGqYuhXt3rzwY4YzTXByvEM4TtrEvqM9yt/N8WjQdtE8FaPEyBe?=
 =?us-ascii?Q?KDFXurdIM/OfnGd11VwGOj/bnbjTLP0fLutdMZJDtmO3M8hYH5XIXhg+b7Lm?=
 =?us-ascii?Q?3VFqHxHOaKgyN747domINZXZRuMG+lP9SS+K5+SUEc3f3KyLyJ8y8SK6+e8h?=
 =?us-ascii?Q?htp/ehZO9zSTKpiksN7ozCAqEuOQj+dKIf828mU5N2TKYMb66KfR9gd05JZ3?=
 =?us-ascii?Q?GjZ2UUei5rytTGAPgL54plOfAjUQS2i1P90oATnHV+J7PVy3BqR2bUzsTl2O?=
 =?us-ascii?Q?7a3rGT+ziyNEXIdLpTllyfwMisk4WXRFlWHOttERmDHBFrh2g+K9lXwSakZN?=
 =?us-ascii?Q?bGa6G9H60/97/vtuiPGtl9Lr1CexAEMfw+htcZ3q3pa4+IVlRgiMaRbT3Cnw?=
 =?us-ascii?Q?eWHb/fuYv2X8A+81kcbq4GfON91tCRr1/P8UMlzKC6nnXFD6J2fEagj2208j?=
 =?us-ascii?Q?kV9fgg5/u1vfhGmyDLTOuZEdxSDlNe3H37fd6IbpmT/ovybb0d4XxPpYUXhR?=
 =?us-ascii?Q?VPzgSJO6fGdM8LcKhG+2WNko0dhxnc2FJjsVrXvXB0gg+fr9yE1SfTlVnbzJ?=
 =?us-ascii?Q?Pvf6wKLIrLdEMzrPN5RaSJ4Y3Ruxtn/scxpnSC7DK4CrvqrO9c35ZIJryke3?=
 =?us-ascii?Q?XQANZICaG5eOuUzKxwmgd0Q0254TZOu0WMURqNzLsX+5/+/OXrBtlJ5GZFLn?=
 =?us-ascii?Q?hyOiwkFmZ0EJBmSeT2s2TPabsAujroEfrCTUHi0B/uFvTrn29j+bWK7s7Qh6?=
 =?us-ascii?Q?T0kHyH9ctAtQuN7dHARraoH/yCSzHgH93qzzlF1xXbbZBhPrYEwTzm2UN17N?=
 =?us-ascii?Q?UbnkahUvU+PNy5nRnoJB2zStaNPzGIEP8IHw9cgNN9hsPNt7H9v6B6UTuySk?=
 =?us-ascii?Q?Cro6gYZN494tFA+YE/abi9V4PM6JS1c8TKvYxDB1t+e6x0ikis825mpXXTIK?=
 =?us-ascii?Q?6Qg8vaE/eZVXmKcDilauRJAauwfv/dziMRR53R4XaH1pZkQQmtI9IhtyWgAM?=
 =?us-ascii?Q?inccKKwfd9u9EWxcmoX1K6zNZUxl1HXfkGbG2FoEqXLHAEe2xhRWgTUV1Xnh?=
 =?us-ascii?Q?4PtwJXSCm60vi4+G5qj5HsBvH90qKrchivkLDw2h?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HSZPs9QVf6a2SDli53FgzajYGjKVf1nxoOe4RMKMcMpx4TCeRZNGezS9Typ8jRWXSFxka14kXB5zWIUSLYGf3JOe0aygrTuHvXVb8J6ifarFZesoEtIePyKRv9+fUS6NaQ9LXHJFBneagIvk193oyIyv7Mj/+ddpF13GFBZze6w5bBmT3cUkYV3oZJZX5EalBZ7pvTfALIjk0LpVCj79+4bphVHkRwKj7L26WVjG2d2GY7a4X3FZXVCr3iCK363yMb5KKHYXiW8mAwEeYDtbjrs5qBs6Pg5K94Bp1tsRKVDXE85Yl5S9A1AkdynuMjjjNGqcvKhpkTkLm5ab7PDRY/yUAltSnJoCQhmS7gVO/EZ6N3v+zsAiexMp0cCeOPOt2jsul8XRfGrcygVVQX+fzMeOwvtOYJk+NUpkvsk/Fpjqg6S9jEM3aYzBok5hC3WpsMfXpKB34GyfluxMmtX1aZRvLCmofY8fn4zu/y4r6t863dJnDd5WxwcQKhTGs/Wc3IfbnJgWn2W/7qQTMaF/hcuMdKy0NSDTj2MIvXRrQ+RRtc2uwyJAsr0+VLdciAPbMkL6EVT1C/F48g4dpy8xc7fUq+mYT6/rOfOO6AQEnMAA2ksa7lcdRSRFoHwtNTM6thu0t1M1uVjsm+Aar8EwIp2uyvZJkhz0xn7mXlqTQjtJZqX0HUxyOUgeBQJxTNsaz4I8WCOIACXVFJxRNs+GR7ov83uwK/ALNzqwP+eOsPkgbd6UAQI4kyP4epccvAUhUxMDtSAUv7chGE5OdOLglBFvU/kTCpQFKo3N+Kr8i2wJll42b8Oc8NKaP/J+PP2D4CEbhRTuHw4wOOrenG2KbJkXZ+ezW+6wsrKG9uVGGjLWPgyRNBweQ6+FZKbGeNNVY6cbT1AZdmUlBDx70YMCaQ==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 614ced25-77f2-4876-8f82-08dbdafe4ef5
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 17:16:38.5042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f3//2Va5STVN/IMTXo6jgruSv9KYKu9Qa8T6TFL0XE4dcdT/q9m4ANhEpHjyC5coLLovgS0zu6YpaTQDq5SCJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7684
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-01_15,2023-11-01_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2310240000 definitions=main-2311010134
X-Proofpoint-GUID: fW9RmoQstYFRFIXapQza5PZkMIZ7nbxl
X-Proofpoint-ORIG-GUID: fW9RmoQstYFRFIXapQza5PZkMIZ7nbxl
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 01 Nov 2023 10:17:39 -0700 (PDT)

Removing the default types from the switch statements will cause compile
warnings on missing cases.

Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 lib/maple_tree.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 0e00a84e8e8f..0fcbfa7e9942 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -759,7 +759,6 @@ static inline void mte_set_pivot(struct maple_enode *mn, unsigned char piv,
 
 	BUG_ON(piv >= mt_pivots[type]);
 	switch (type) {
-	default:
 	case maple_range_64:
 	case maple_leaf_64:
 		node->mr64.pivot[piv] = val;
@@ -783,7 +782,6 @@ static inline void mte_set_pivot(struct maple_enode *mn, unsigned char piv,
 static inline void __rcu **ma_slots(struct maple_node *mn, enum maple_type mt)
 {
 	switch (mt) {
-	default:
 	case maple_arange_64:
 		return mn->ma64.slot;
 	case maple_range_64:
@@ -792,6 +790,8 @@ static inline void __rcu **ma_slots(struct maple_node *mn, enum maple_type mt)
 	case maple_dense:
 		return mn->slot;
 	}
+
+	return NULL;
 }
 
 static inline bool mt_write_locked(const struct maple_tree *mt)
@@ -6718,7 +6718,6 @@ static void mt_dump_range(unsigned long min, unsigned long max,
 		else
 			pr_info("%.*s%lx-%lx: ", depth * 2, spaces, min, max);
 		break;
-	default:
 	case mt_dump_dec:
 		if (min == max)
 			pr_info("%.*s%lu: ", depth * 2, spaces, min);
@@ -6758,7 +6757,6 @@ static void mt_dump_range64(const struct maple_tree *mt, void *entry,
 		case mt_dump_hex:
 			pr_cont("%p %lX ", node->slot[i], node->pivot[i]);
 			break;
-		default:
 		case mt_dump_dec:
 			pr_cont("%p %lu ", node->slot[i], node->pivot[i]);
 		}
@@ -6788,7 +6786,6 @@ static void mt_dump_range64(const struct maple_tree *mt, void *entry,
 				pr_err("node %p last (%lx) > max (%lx) at pivot %d!\n",
 					node, last, max, i);
 				break;
-			default:
 			case mt_dump_dec:
 				pr_err("node %p last (%lu) > max (%lu) at pivot %d!\n",
 					node, last, max, i);
@@ -6813,7 +6810,6 @@ static void mt_dump_arange64(const struct maple_tree *mt, void *entry,
 		case mt_dump_hex:
 			pr_cont("%lx ", node->gap[i]);
 			break;
-		default:
 		case mt_dump_dec:
 			pr_cont("%lu ", node->gap[i]);
 		}
@@ -6824,7 +6820,6 @@ static void mt_dump_arange64(const struct maple_tree *mt, void *entry,
 		case mt_dump_hex:
 			pr_cont("%p %lX ", node->slot[i], node->pivot[i]);
 			break;
-		default:
 		case mt_dump_dec:
 			pr_cont("%p %lu ", node->slot[i], node->pivot[i]);
 		}
-- 
2.40.1