Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Wed, 1 Nov 2023 21:07:33 +0300
From:   Dmitry Rokosov <ddrokosov@salutedevices.com>
To:     Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
CC:     <hannes@cmpxchg.org>, <mhocko@kernel.org>,
        <roman.gushchin@linux.dev>, <shakeelb@google.com>,
        <muchun.song@linux.dev>, <akpm@linux-foundation.org>,
        <kernel@sberdevices.ru>, <rockosov@gmail.com>,
        <cgroups@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>
Subject: Re: [PATCH v1] tools/cgroup: introduce cgroup v2 memory.events
 listener
Message-ID: <20231101180733.ok7j34izehrpyfpy@CAB-WSD-L081021>
References: <20231013184107.28734-1-ddrokosov@salutedevices.com>
 <eqvaejfo5uoz5m7e5g3wjgegfo4ribajdgu57fst3hu5m6gfa4@beugaul6pjjz>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <eqvaejfo5uoz5m7e5g3wjgegfo4ribajdgu57fst3hu5m6gfa4@beugaul6pjjz>
User-Agent: NeoMutt/20220415
Precedence: bulk

Hello Michal,

Thank you for the feedback!

On Wed, Nov 01, 2023 at 04:56:47PM +0100, Michal Koutný wrote:
> Hi.
> 
> I think the tools/cgroup/cgroup_event_listener.c was useful in the past
> to demonstrate the non-traditional API of cgroup.event_control with FDs
> passing left and right.
> 
> 
> On Fri, Oct 13, 2023 at 09:41:07PM +0300, Dmitry Rokosov <ddrokosov@salutedevices.com> wrote:
> > This is a simple listener for memory events that handles counter
> > changes in runtime. It can be set up for a specific memory cgroup v2.
> 
> Event files on v2 are based on more standard poll or inotify APIs so
> they don't need such a (cgroup specific) demo. Additionally, the demo
> program lists individual events, so it'd be a maintenance burden to keep
> them in sync with the kernel implementation.

From my perspective, eventfd serves as the standard mechanism as well.
Therefore, when incorporating the cgroup v1 event listener test into my
project, I initially turned to the tools example, which proved to be
immensely beneficial. Conversely, the cgroup v2 inotify example can
solely be found within the kernel selftests. Although the prevalence of
inotify makes this somewhat understandable, having an additional example
would provide supplementary documentation, which is often invaluable to
developers operating in userspace. Of course, there are maintenance
expenses associated with this approach, as you rightly pointed out.
However, I am willing to undertake the responsibility of maintaining
this example if necessary.

-- 
Thank you,
Dmitry