Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp1132003rdb; Wed, 1 Nov 2023 12:11:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQ5wAED0+bLuza4XWyeJRhpml1rM0YKtrkfnJ6ZP9rD1oKbAAYu77lNTFhgddeRkBdG3IB X-Received: by 2002:a05:6a00:1488:b0:6be:b79:eca with SMTP id v8-20020a056a00148800b006be0b790ecamr20273282pfu.32.1698865879511; Wed, 01 Nov 2023 12:11:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698865879; cv=none; d=google.com; s=arc-20160816; b=UbGB7djVUjNu3Etfo1dIuJZX5A4z4/481stc7zH0BO8wtcDBM0QaAIAQge0TVmdc6u /c7mhjHHq/MeiENCzhmKGuilOHZukx5Hs+lJhJ9C9z4FID4g6srQ+Vs91wi+8JhXHtvw /StLMw5PHSHtdwdXzjk8pD4d3JnpBUoq7TZpLH2i50MwFxeoXEJfSiHnM6OhB2d4ueul VhHcW+Y8q7sAqReDqpOm3VHstvsQFBw0aG8MqX84X+ycf0YjJs3gXLy3oMNGR0/+m4+t axpJQpEPy3KOLA+baAeeSRWHKc1LYCLMf0piiLeKUz/LF4OWVa5q+nB2PFslTl5Af9mr LXHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=4RmhHqVU+OcQi9a5wWVvmwhy6cSHOIi3XcghAi7uKUw=; fh=Xn5nprqnnoF3CPXjAJVpIQ5iuNfypbmRsvbbs83BurE=; b=DP+9ZgImxnYBdkYLoXzld4rh5qfAXgOO26k+WfuMil/ivQQe83r70zbecP/W65CjXo 2w54tYx1H75KaOR8da3jpWune7ma8hTS4nsdC1gMqYp1CHWndvfLXVWu9H5zdfjFe04B 5rj/W+zUZ+dpPsCrbC1QbEW2cxkT/22j4ngejm7LvBbYWadDvyXKgyefqDLLG7r8BtZR HMmwc+A81W5PcRL5DG9Yh7fCvVh9uIZddF+shuBYrVsY1Q+EBxmyvqQPUzgrsscHClfU ddSdJqTU8oZFxzViG0Rmc0b/tnloA4R3UNA2EMXjWGV7WmotQtAU1YzMGf4g4h4uGktd SS5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=lmKoLm69; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id w69-20020a638248000000b005b88fad841csi417680pgd.285.2023.11.01.12.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 12:11:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=lmKoLm69; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id C0BB1809843E; Wed, 1 Nov 2023 12:11:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232802AbjKATKv (ORCPT + 99 others); Wed, 1 Nov 2023 15:10:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232693AbjKATKu (ORCPT ); Wed, 1 Nov 2023 15:10:50 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7E27F7; Wed, 1 Nov 2023 12:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4RmhHqVU+OcQi9a5wWVvmwhy6cSHOIi3XcghAi7uKUw=; b=lmKoLm69Vx/JuCLHrKTwyI0Ifl d+5mQVFyEXY+rMHBviWPDA1ev0OID67NyVavp1YQFWgo8+CM4cWHDk6nQmWt3AGCQVjY5ZsvtJqda kFxk3ho6mya9HS0zse7jZUfVd1MAAbHE0rpTHG39wUcM8o+L7tghsE2O7BybkVcxVDURbysEFQp8C l4ptP56313Xfyfsr7X2nz2uGRjTUDCyVHn40O5M4WSAczXTalGiYeJurc18076Axk5xOKOmXLOzXZ AtEimsLTPkiAdD91a10O9f6KRlb4EB7OCdeC6tLtNKTIcHZbH2YBKbfDay75+TkLnNHdnw97fZUlv I3eN+Yeg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qyGbv-007zqf-1O; Wed, 01 Nov 2023 19:10:39 +0000 Date: Wed, 1 Nov 2023 12:10:39 -0700 From: Luis Chamberlain To: Krister Johansen Cc: Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Douglas Anderson , Vlastimil Babka , Arnd Bergmann , Lecopzer Chen , Nick Desaulniers , Thomas Gleixner , David Hildenbrand , Masami Hiramatsu , Pingfan Liu , Michael Kelley , Petr Mladek , Andrew Morton , Josh Poimboeuf , "Guilherme G. Piccoli" , Mike Rapoport , Peter Zijlstra Subject: Re: [PATCH 0/2] Triggering a softlockup panic during SMP boot Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 01 Nov 2023 12:11:14 -0700 (PDT) On Fri, Oct 27, 2023 at 02:46:26PM -0700, Krister Johansen wrote: > Hi, > This pair of patches was the result of an unsuccessful attempt to set > softlockup_panic before SMP boot. The rationale for wanting to set this > parameter is that some of the VMs that my team runs will occasionally > get stuck while onlining the non-boot processors as part of SMP boot. > > In the cases where this happens, we find out about it after the instance > successfully boots; however, the machines can get stuck for tens of > minutes at a time before finally completing onlining processors. Since > we pay per minute for many of these VMs there were two goals for setting > this value on boot: first, fail fast and hope that a subsequent boot > attempt will be successful. Second, a panic is a little easier to keep > track of, especially if we're scraping serial logs after the fact. In > essence, the goal is to trigger the failure earlier and hopefully get > more useful information for further debugging the problem as well. > > While testing to make sure that this value was getting correctly set on > boot, I ran into a pair of surprises. First, when the softlockup_panic > parameter was migrated to a sysctl alias, it had the side effect of > setting the parameter value after SMP boot has occurred, when it used to > be set before this. Second, testing revealed that even though the > aliases were being correctly processed, the kernel was reporting the > commandline arguments as unrecognized. This generated a message in the > logs about an unrecognized parameter (even though it was) and the > parameter was passed as an environment variable to init. > > The first patch ensures that aliased sysctl arguments are not reported > as unrecognized boot arguments. > > The second patch moves the setting of softlockup_panic earlier in boot, > where it can take effect before SMP boot beings. Thanks! Looks good, merged and will push to Linus soon. Luis