Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <d47235e0-7ecd-483e-82c3-78f13c77df67@amd.com>
Date:   Wed, 1 Nov 2023 15:26:23 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH] x86/resctrl: Fix unused variable warning in
 cache_alloc_hsw_probe()
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Peter Newman <peternewman@google.com>, x86@kernel.org
Cc:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev
References: <20231031220534.37730-1-tony.luck@intel.com>
Content-Language: en-US
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <20231031220534.37730-1-tony.luck@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3piNWpGdnlGSlJXVzA4NjVNZXN5MWFUVDQvajdjMmsreWN2S21qK1hYSGR5?=
 =?utf-8?B?dURpRlRCNGZPZHh2NFdSNktMWFJvOGF3YUh4UTdkY21scXcwYkZiNHExQ24x?=
 =?utf-8?B?enZudTBIQWtVQjBhaGJEUWVNUVdNOERyNDZaZy9JUVVteSs4L3pjS3B0ZHBp?=
 =?utf-8?B?ZFlKWmNINjNEek5mVGsyM1I1T1FTM0gvamNNNzJEelpSWFpVSWkvNmxSY3VE?=
 =?utf-8?B?U1BrT2IvWFFnQ0ovOFBkZ1psSmdiYnJwYnNpeTBsSUVKcFdKV0o5MlBKMkkx?=
 =?utf-8?B?MkpwNFpjZm95aGMrVWU4NlFDUnVVekpJRjg0M3NYMzA4c2Z5SS9yNzBPeHpG?=
 =?utf-8?B?WTBsTnpVeHNvUS81eUZYWDFpNWpORlFIeVllcVkrdGx0ejQydWFqYVV4VjVL?=
 =?utf-8?B?cFdYNTJyeHVDcmo5a1U3ekhCdU1rWEZEcXI1aXZmMStmUkNVMDRJd3N3Z2Mr?=
 =?utf-8?B?Y2FUN216Rmx0VGI2bWFhVUhiMDBEMFlzaDhWQWxjUlVSay9veGlNVDI3RkJj?=
 =?utf-8?B?N2hBVXlYTkxKYVJUN3JtZmZRMG11b1AzMThRVTFuS2M0d2N4ZGZVKzhiOTdY?=
 =?utf-8?B?RzJDQVZ0RnpFQnArbmxlbnhyZmZ5MkR2Q3lqN2VyM3FNMUIxL0ROTXNPelVi?=
 =?utf-8?B?WXpSdXpDa1dSVUlNdDB3L2Fla01iQ0xiSnpSMk1kNkNnQ2s4VWFONkVTNnY2?=
 =?utf-8?B?d2FDb200QlJNMm5QOFJmTlNWaFk3b1JYbWNwbFpXSVptOTZYbG1MdzFLalc5?=
 =?utf-8?B?bHhwbVZHTUZzNnJ5RHp3Y3d2WjRVZzN4VjlPMURKQUdRdHdRcjJhRTBFUkIw?=
 =?utf-8?B?TUw1SHJ1WldEUnk5a2lDOWxRTnNsOGZ1OVRaeDFhSFpSQWt3ak81QUVvaEF0?=
 =?utf-8?B?MnY4VEx2ZWRjVU9xZGJtZWJRS0duY2lsR1FTOU9USjlZcE1OKzlvNHdQajg2?=
 =?utf-8?B?eDREWnBPSU83OGFvK3lqbGxmdUdjanRCdzJDcVdvbG9PTE9ra1JrdTFsMm1p?=
 =?utf-8?B?TkNoL1M1RGx5RWFmTzEyM0FoOTNjVFUrRWhJSjB1Z0c0THJVbHJoOWJkb2FS?=
 =?utf-8?B?Q1ZieFduTk01MU5DSnQxQ055N3c5bFpmakxGc0gwT1psVVBIaHZoTmlQOFo3?=
 =?utf-8?B?dXFLd3F3a1ZENElPaXdVUVRqZHBjQzNQUWV0VVBUbzBvUFR5QUtSWU9qVDVR?=
 =?utf-8?B?R2gxaXNLaHhSZ1VMY1k2eXJ3Q2d6dTJtZmlLVGp5NDBOQkkvcStHcnhrM0lp?=
 =?utf-8?B?bnVBdk5RbnZ2U3VueHBYaHhTVFA2WW84QUhtRXlBVHNJQ2pJTC9DNUlhVlB6?=
 =?utf-8?B?L2RzQ1dPc2xWUWZTNzVMSWdVanNDZnExNU5XZjFYN25EVDVJYlZRT2NlSXI1?=
 =?utf-8?B?MkNadGZCZmpJWVNqa3p1Ujl4TmFxNHkyckk3K0k3TmV4bVVnRWU0eHJvbW45?=
 =?utf-8?B?WUp6Qi9JYzRxeWtnSGlKUmFrL0RhbGVDL0FwTXRsdy83aHdzdldnS1pWSmVL?=
 =?utf-8?B?cFI3b3crK3RCdW5SVmw4Y3pJZGMvRmpPYlBLNTJDWlZBZVczVTVhQW80N2dY?=
 =?utf-8?B?Nms3Tmd3YVpoeVg4a2VUWjc4VFp1VWZwZFVnR3RWQjRidFV1dGZCVWpwTjB1?=
 =?utf-8?B?SHFVRFpNTU1BQ0lteDFZK1dHNFVPSGhSS2ZYUmdjd3kvZ3VmdGUxbGJ2bkg4?=
 =?utf-8?B?YUZ4OUZSMzBjbU5oK1gram1SKy9xenFYV0Jmd0w0YXZncUt5VTYvcTRoRkdC?=
 =?utf-8?B?cnBhaXFieWY2ckswMDg2L1BGMlBCeHhjbnFkQWJZL1BnandZT3hTVEJOSDVK?=
 =?utf-8?B?cnNMSXlyVm1lQmZMRkNzdFBYcVR1bEJTUXduSUlad2pkdzZzaUN6d2lxL1o2?=
 =?utf-8?B?UEV0MjN5NDhUa1pRcTU1dUJwRUNiM0VmN2ptS1c2TjZKY0Evc0VBVVFidUlu?=
 =?utf-8?B?VzNxeFVlcUZIbmJkdEYzb2VuSzBRRmJiMXEvaC9TdWdLOWhJU0thd0Q2R1d4?=
 =?utf-8?B?c0R2anJXWXNEc25uTFM4TVIxbXIzQ29hVUdveC9Ca0Vqck1kZm0zSmF2U1dp?=
 =?utf-8?B?SGRETVhKckx6NDVHUmFoMzhJc3lhUmxQVFZFeUx6eG5MbitTd1poYk9RS0w3?=
 =?utf-8?Q?KFqI=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de668b1d-8850-4218-86b7-08dbdb18d2a0
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 20:26:26.4391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QMrkQTA5mX4JQICnJgIYfQ05wsEfhz3oBb/COyHCz/czdykxMZILbVjVnp1OoyBv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9059
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 01 Nov 2023 13:26:48 -0700 (PDT)

Hi Tony,

On 10/31/23 17:05, Tony Luck wrote:
> In a "W=1" build gcc throws a warning:
> 
> arch/x86/kernel/cpu/resctrl/core.c: In function ‘cache_alloc_hsw_probe’:
> arch/x86/kernel/cpu/resctrl/core.c:139:16: warning: variable ‘h’ set but not used
> 
> Fix by switching from rdmsr() to rdmsrl() using a single u64 argument
> for the MSR value instead of the pair of u32 for the high and low
> halves.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> This has been annoying me for a while as the only warning from the
> resctrl code when building with W=1.
> 
> N.B. compile tested only. I don't have a Haswell system to check this works.
> 
>  arch/x86/kernel/cpu/resctrl/core.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 19e0681f0435..4084131d391d 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -136,15 +136,16 @@ static inline void cache_alloc_hsw_probe(void)
>  {
>  	struct rdt_hw_resource *hw_res = &rdt_resources_all[RDT_RESOURCE_L3];
>  	struct rdt_resource *r  = &hw_res->r_resctrl;
> -	u32 l, h, max_cbm = BIT_MASK(20) - 1;
> +	u32 max_cbm = BIT_MASK(20) - 1;
> +	u64 l3_cbm_0;
>  
>  	if (wrmsr_safe(MSR_IA32_L3_CBM_BASE, max_cbm, 0))
>  		return;
>  
> -	rdmsr(MSR_IA32_L3_CBM_BASE, l, h);
> +	rdmsrl(MSR_IA32_L3_CBM_BASE, l3_cbm_0);

You are writing 32 bit and reading 64 bit. Why don't you change both to 64
bit?

>  
>  	/* If all the bits were set in MSR, return success */
> -	if (l != max_cbm)
> +	if (l3_cbm_0 != max_cbm)
>  		return;
>  
>  	hw_res->num_closid = 4;

-- 
Thanks
Babu Moger