Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp1171117rdb; Wed, 1 Nov 2023 13:27:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFz1c2uDzab76pV/NVEXm3bW5GDr8ZwZbq3IVnbuPonxggB7fiRc+hG2ZIBKMkKezKYEGho X-Received: by 2002:a05:6a20:918f:b0:153:b16e:8db1 with SMTP id v15-20020a056a20918f00b00153b16e8db1mr15896094pzd.10.1698870430528; Wed, 01 Nov 2023 13:27:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698870430; cv=none; d=google.com; s=arc-20160816; b=mkrI2wKLGYBiNYsbCawJWsmTq5SBhJAoZT45UyJ6zXmJuxC+bIV1QuC9+7vPOSV13k 3rmzR/QzTToBY5Y+ZpqihUGi6ly9UINQtTjF3nK1NlOi/oTdFb8Ub7C1FtZeNy8Pm4pq wcev5vET+Opx7o3sDhLXlQN0ixZyHFP6WIOEbv3eUoZpHFrznByOno9jFxHmo3ido2Yk MYSeToTx0IWJkdk/Yw1CLkqbffr/RgkGyiJIZRLBvCbHAoj/FJNX7T+nS39IIN55Si5v MopLxv0TgJR1OhpRjGerLFoMzIdNgHBKu5pHIak6wtnmXfIRf8z/H1hx4FgNQbiAWoN/ F4DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=Od7geAUO03xnUMzUzl75DCFJAJ0NbP3Lvnn4+QKHjsU=; fh=g1jORCg7XplfmOWaokwmUBpSREuOqg5tPfppkCfNHls=; b=m+qQe7y794w0Pkh9tRtUvl7C2eX/4Q1+NNhee179RQTFUvRpE3Eje6nF64IkUd+hKE R1qK14WdYjmLFsZ2zjDXL7q5n8/oz34ay2sbCtZ65Zv7QLSJwrHCXWEV/G2Pu00nLqwd 9keWXfe3D+N0FBL0BqhgvIzmAzOieCVpQuMgB0juEOXwzMXnf6gseF9xpq9OllR4X6v/ NWCMZMJ2EtRXNId4jnZVWr1uZXqU9oq5EHuB2F7nHCsredoCWlTJ0Lm08jDMZGlA/nzp R8nayGglWsuxJVFKiUmVgetwue56mp3ELNi5Xhgij2C93i2TQ/6/BSvqbfapWfyhJCR9 +B+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fFxX+nmj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id l11-20020a056a00140b00b00690228b1d45si2398416pfu.342.2023.11.01.13.27.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 13:27:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fFxX+nmj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 9D723801F762; Wed, 1 Nov 2023 13:27:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346405AbjKAU1I (ORCPT + 99 others); Wed, 1 Nov 2023 16:27:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232578AbjKAU1H (ORCPT ); Wed, 1 Nov 2023 16:27:07 -0400 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 252AEF7 for ; Wed, 1 Nov 2023 13:27:02 -0700 (PDT) Received: by mail-yb1-xb34.google.com with SMTP id 3f1490d57ef6-da2b9234a9fso170900276.3 for ; Wed, 01 Nov 2023 13:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698870421; x=1699475221; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Od7geAUO03xnUMzUzl75DCFJAJ0NbP3Lvnn4+QKHjsU=; b=fFxX+nmjf8auP6ELv8OU+J7F/2kaXNgndRo7QT3fxgez8gbPJp5hH1iJArQ6TKdCdR zh6VPgLjVOz73GtcDryexoYD8QHZxn8wRkyR3pz7NWI0CsGFsurlUmU1582zuUKO82RG k2z0U3o0oziyrmw7F+CaQO1xFbSMvkDtg0aaCycBMfaLIdLETmCU5PV/65RJciVPr3Ud 5fQUAldGRCP9Py0rzLFRynEc6BiWSuri/F21X9wpqF/VNJSNld+yPQmJhGqPwtu+K3QF DQXvjmzgRs/uUMAAL48tcemFt48d7BBWCjPXvFdBpMZsVOZfeK8xv/NzR78hLup8l63S ZWiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698870421; x=1699475221; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Od7geAUO03xnUMzUzl75DCFJAJ0NbP3Lvnn4+QKHjsU=; b=qOo+MwF8V2j3CPAAsQQVv3CHoc4ohj6km+4Y1c25vdjy9W+yIZcdJ1zK+z5X2vfeuK Bl8+I9IuHs1PF/OhcGZ30qJos69teUtGimitlvTxmLX8NNvSJ9zl2AXsrYMBVW6IY07j CoZJxFVDW04obLFWfCVGdLINx7dTTQcYYhLv4BDXP+BCuGbUo3uQfqUoX37rg87uPIR9 Sga3A7nAXhaEPeg9Y3THPyk8iP4qs1x6xdEAMHFFNyiuF6XyaONrzbM3FFhO6mzq3EgD 8jrnQHpd9qZUAQEJlIVZrUC8RzFp/M39vS0wfVRmz4PLQloJ5riFBvQtKnaEuw7ZC/nD xphw== X-Gm-Message-State: AOJu0YyjNcyewr1q9VlHDxgCNcBnOf6mCBCJuPxArVTmbJlBqe7qFDLA sxUFdg9KuVuCfPpfAy5DLAkiNBNx7TiuCw6HxDY7bA== X-Received: by 2002:a25:40c7:0:b0:d9b:9aeb:8c26 with SMTP id n190-20020a2540c7000000b00d9b9aeb8c26mr14111496yba.40.1698870421285; Wed, 01 Nov 2023 13:27:01 -0700 (PDT) MIME-Version: 1.0 References: <20231030-fix-rtl8366rb-v2-1-e66e1ef7dbd2@linaro.org> <20231030141623.ufzhb4ttvxi3ukbj@skbuf> <20231030222035.oqos7v7sdq5u6mti@skbuf> <20231030233334.jcd5dnojruo57hfk@skbuf> In-Reply-To: From: Linus Walleij Date: Wed, 1 Nov 2023 21:26:50 +0100 Message-ID: Subject: Re: [PATCH net v2] net: dsa: tag_rtl4_a: Bump min packet size To: Luiz Angelo Daros de Luca Cc: Vladimir Oltean , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 01 Nov 2023 13:27:09 -0700 (PDT) On Wed, Nov 1, 2023 at 1:35=E2=80=AFPM Luiz Angelo Daros de Luca wrote: > Sorry but I noticed no issues: Don't be sorry about that, it's good news because now I know where to look, i.e. in the ethernet controller. > My device is using > https://github.com/luizluca/openwrt/tree/ath79_dsa_prep%2Bdevices . In > summary, kernel 6.1 with openwrt generic patches and the > reset-controller patch I sent net-next recently. Looking good to me. > [ 3.888540] realtek-smi switch: found an RTL8366RB switch > [ 3.952366] realtek-smi switch: RTL5937 ver 3 chip found Same version as mine too. > [ 3.967086] realtek-smi switch: set MAC: 42:E4:F5:XX:XX:XX Unrelated: I have seen other DSA switches "inherit" the MAC of the conduit interface (BRCM). I wonder if we could do that too instead of this random MAC number. Usually the conduit interface has a properly configured MAC. > [ 3.976779] realtek-smi switch: missing child interrupt-controller nod= e > [ 3.983455] realtek-smi switch: no interrupt support > [ 4.158891] realtek-smi switch: no LED for port 5 Are the LEDs working? My device has no LEDs so I have never tested it, despite I coded it. (Also these days we can actually support each LED individually configured from device tree using the LED API, but that would be quite a bit of code, so only some fun for the aspiring developer...) > Maybe the ag71xx driver is doing something differently. I'll look at it! Thanks a lot Luiz, Linus Walleij