Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <9e6a979a-48db-4b25-884f-ac8d4c2bb078@amd.com>
Date:   Wed, 1 Nov 2023 15:42:36 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH] x86/resctrl: Fix unused variable warning in
 cache_alloc_hsw_probe()
Content-Language: en-US
To:     "Luck, Tony" <tony.luck@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Chatre, Reinette" <reinette.chatre@intel.com>,
        Peter Newman <peternewman@google.com>,
        "x86@kernel.org" <x86@kernel.org>
Cc:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
References: <20231031220534.37730-1-tony.luck@intel.com>
 <d47235e0-7ecd-483e-82c3-78f13c77df67@amd.com>
 <SJ1PR11MB6083C14236AC0AFCB49DFB15FCA7A@SJ1PR11MB6083.namprd11.prod.outlook.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <SJ1PR11MB6083C14236AC0AFCB49DFB15FCA7A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmtxTkhkVmFBZUFFZUQ3ZjhnMEF4eDhpaUdEK3k4MUx0ZUhLOThRVVp6VHE0?=
 =?utf-8?B?Q2k2Vm5UK1pPdzh0N3FVaGIyU0NTSnpMMWljVlFzS2tkaUlMYkxmS1lydmRh?=
 =?utf-8?B?L1Jqb2xEb0lQTzFVSFBKWU5OeUVpRktxVDRxVXdOZGdsS3NNckRNRXBCczV1?=
 =?utf-8?B?WFJpTlJQUkJ0MEdIWngxcUxCS2RlTG00a3gxMHFySiswczZGN3dpdXVDZVJ0?=
 =?utf-8?B?YkJ3dWhwSUdYdXo4UzF5eXh2aDRwQktKT25QWW5zS2FnQXVtZThITXJsQitx?=
 =?utf-8?B?eE94bDJjZU1SVU5yTVNvMjdhZ3NMQ0wwUzB1ck9RVXVJUERFOG5tQXJhTUFr?=
 =?utf-8?B?NllwdUNJZUx6eENNRmttZUMwZ1U3MWo1NDlHSmwrNzdOay9nZ283NGlPVHNV?=
 =?utf-8?B?bEk1c05pZXVEeXRtSlBLeFB3VCsyampiSjJmTDBmMDhFZmpqZ2dxbW9kbEQr?=
 =?utf-8?B?L2JOK01pb3FoNDM3dXFXMVNtS09zbHp5T0daV29BeTk1L0t5WUhyaEFoU0NN?=
 =?utf-8?B?SFM2aTJtZzBRMUwyeE4veHd1MzNCNmYwR1RDSDRCbVpqUkJuSUR3ZjFxTWRH?=
 =?utf-8?B?UXg5dDRhRGdmZGMvZzRFc2t1bktWVzJCVFpMY3BPdDIramluU1JXVXNVUHJE?=
 =?utf-8?B?NU53OTFzMDJqdFFWQUw4YXZ0bjJ3VzdLUVU5SjZNM0JlRGV2Z3djOWVoODRH?=
 =?utf-8?B?aWZGSUZPN0RSbmVEdjJ4ZHJzeExRZlpLak93b1B0UVVGOVVLd3dhZzI3VGRJ?=
 =?utf-8?B?aWYyWjdnZ2lab3QrN2ExcFRMVVp2ZzJvclB4N3c5VnNpek4wdHBWQXJ0cGt0?=
 =?utf-8?B?TlorR3lGMzV4MUowNkxsZDhRblQxdXBZMDVYc3F5ckJhSGptT2RKbWM2OEVF?=
 =?utf-8?B?d2pNdXZYZU9TVElQSi8rWUtHQ3dnNnBNRUVkTHBqSWp1RGhCUE1hQlNLWjdk?=
 =?utf-8?B?Ymx1MXJFZ2M3dDkvYVFkOHZsL0Zzd1FJemxWT2UzdUN4cTBYeWlsM3paemtw?=
 =?utf-8?B?dTdETlQrdnl2ajhNT0QvYWZBWG9QM2lNd1RoV2pJUjltY1lwdnhYc2NKeHNC?=
 =?utf-8?B?RmQ4Yzkwa0pndHVzRnRQb21TOFFWQ094Y0JGeHpvT1F4ZnpoQThBMHNWLzZx?=
 =?utf-8?B?MVVvOUQwL1BnSkVDMHpxNWxTNnZPcjZOZWF2Tzk1NFhlWVhOQWlvb2lQRFht?=
 =?utf-8?B?VGxFREdNRnNYd1BnZ1FhMWpYYnloOGdMdCtSMVd2dDdQOUlEN09ZS09xQXhw?=
 =?utf-8?B?T1V4OGhiaGJjb3JhRUlOWXBDZVhDSnZVNzhlUzRjUzdxU1hmMTRQeWNGYmkv?=
 =?utf-8?B?SE5kNmJwS2tHUVE3SVljODRmZWM4VE1RbGNCTHNlQ1hjVUVDU1ptVmZQSmV3?=
 =?utf-8?B?NXpQVVRBaDh0UDIwV3d3SGdVNkNVQ2hkWlVQOU1tZTBrWFpWUDcwWVNCSmdY?=
 =?utf-8?B?WHFlaEJ1R1ZKaFlMTTFReXRjVnR2Mm1mcDRnTXVCZEZRMnRydE1UR0FRcFls?=
 =?utf-8?B?UFkyZWl5VW9McmpmaTlvQWxOQXlaejZ3Yndxc3VHQ2tZdFdBYkNENW1Odk8v?=
 =?utf-8?B?NEh4ZFZjaHZ3b1ViemlTTmZ2R0VsZFkrUy9nRG1Ha2xSUUEvc2tuQmkzN0lI?=
 =?utf-8?B?TDFHU1FXS3ZIcmZWMDVEaEdEOGYrRkhYNThycml4L0tHQm1PN2wwTDdkZExR?=
 =?utf-8?B?ZTJZNHdtM0xsMkUrS2tLNVR3czZOaTNNb24yd3ZzcGVKWFg1MHQ4bjlWaHFm?=
 =?utf-8?B?aHFJNGxmME56WXBJWkZsNHEwVW50ZzcrT0JRUEhkUDNpT3owaWVSSWZZZnJv?=
 =?utf-8?B?LzltUU4yNUNUeHowVUhjelJDSjRRNjVwNmltNzVnakZtUDloWVVPMVFIS3Nj?=
 =?utf-8?B?eDZpUVhqRzU1Mk4vcGN4b0tVVUVhWGFFRnVZdGZsV1NScndjNlVtU3ZyNG03?=
 =?utf-8?B?allhS3pJaGh3MmRmT3RuLzRna243TkZydFlzclNJd0Z5bEV5dGZzYnhOdWRh?=
 =?utf-8?B?NWFlNjAyM2FnRU43NlpscFFOa2hNYXIvRDNlQjV2ZEN1aTlCNzg3anpFTDA5?=
 =?utf-8?B?TnJhbzBycGJ2NkJMVUpGUTlxRlU3UTlLRVZUcS96MmdzR3NjU3Ric0p6dzZa?=
 =?utf-8?Q?ADwM=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6857d78-49c2-4a92-36f3-08dbdb1b15fc
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 20:42:38.3783
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yG2li5ONqa03yQxABQXk56405m/aNz/fyn19D7QipB4ZMWzCPyP7Hb1hKrpSbrBQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6565
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 01 Nov 2023 13:43:10 -0700 (PDT)


On 11/1/23 15:33, Luck, Tony wrote:
>>>     if (wrmsr_safe(MSR_IA32_L3_CBM_BASE, max_cbm, 0))
>>>             return;
>>>
>>> -   rdmsr(MSR_IA32_L3_CBM_BASE, l, h);
>>> +   rdmsrl(MSR_IA32_L3_CBM_BASE, l3_cbm_0);
>>
>> You are writing 32 bit and reading 64 bit. Why don't you change both to 64
>> bit?
> 
> wrmsr_safe() writes all 64-bits ... just gets those bits as a pair
> of 32-bit arguments for the low and high halves.
> 
> I could switch that to wrmsrl_safe() and change max_cbm to be "u64"
> to make write & read match. Would that be better?

Yes. That is better.
-- 
Thanks
Babu Moger