Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 1 Nov 2023 14:59:01 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Ira Weiny <ira.weiny@intel.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>
CC:     Yazen Ghannam <yazen.ghannam@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ard Biesheuvel" <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH RFC v2 3/3] cxl/memdev: Register for and process CPER
 events
Message-ID: <6542ca25d2fb7_435c1294aa@iweiny-mobl.notmuch>
References: <20230601-cxl-cper-v2-0-314d9c36ab02@intel.com>
 <20230601-cxl-cper-v2-3-314d9c36ab02@intel.com>
 <81b90308-fdb1-3686-33a3-1e7ec42a7ef8@amd.com>
 <6541c795e39b_2e75b294e0@iweiny-mobl.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6541c795e39b_2e75b294e0@iweiny-mobl.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TzH3+4gvkXtgn6tFHDkbwGEAd0aw/5XN0eupBUlEW/136SeVqc5GnTLVUQzv?=
 =?us-ascii?Q?+fQTGq2odN0naNijfz3tFv10p2CceVZh0k2Pt29eSANEn0FrIdcPTO3VfcLi?=
 =?us-ascii?Q?b82TzBIIaAwrE6HUR9a1NBOMZcqSysVt6ZQKi2XVg3n0ZptsoR93+Jv6IFgi?=
 =?us-ascii?Q?77vVqBBM3dWXbGvzM21Bqf4YlhdL41YTmkkEG3cjTt5gmlzQ8NCc3/cXEYMd?=
 =?us-ascii?Q?VL+/rG2H7EW1LW/tD9ZqKYi1sUHxU3A2ve3YgFvEMVEOewgOC58FScqpgD/e?=
 =?us-ascii?Q?7r15RMJ9NH+2BXnuFZXEc1SFfJ0n9uwz5aPTC2AYsHJ94Td9sy7E26ZZ8kNT?=
 =?us-ascii?Q?yQQ6MPvkfkc5Qcuq5mpRNDUPsUaCUHhOF40NzaZ92Uc7ygVuGskamBquW/OD?=
 =?us-ascii?Q?G5exzDbQSZ6APLokmEJ63owzbpNcYJ04p80UjOwUePQWCjLWvLVF6s/n2lBB?=
 =?us-ascii?Q?28loozS4sIau79I7qP6irA+i9QlvpTK0UjQnqwYgO/BVHy2Q1JHR5cKL0wGG?=
 =?us-ascii?Q?HoAyzm7ds0oKLJwjuZj+XjAd+T6JW4nQlnzJatUUNj09f+wRv+8KIbwckGzX?=
 =?us-ascii?Q?OFVp5MPkTx8thcW5H7KNDyt0SnBRJc+iYqgs+321B2m0XMVB6QFjLNI5hp5Y?=
 =?us-ascii?Q?k4MXvt07y3S9TPRYlGQLPJiXUqQY1HC3EqWHk8F/phiE/ljjprAAPMBRv5xK?=
 =?us-ascii?Q?aY6vLWGpxm7ngw+xJp29RAVzOG/dVW0LkVRsF7z7pJBpyUKesF9PVMlMHDf+?=
 =?us-ascii?Q?7P6tKCokhH3L5lEIS1UhBc08Ugrt5prxqyDTuQ9HV39pr4oZSAvEHICoDwJ5?=
 =?us-ascii?Q?76XdH0rTH70yMAqWJ6JLigz2hc9ZOHzkZGfOzTx7KUbUIHKWOiryL3LA1XDQ?=
 =?us-ascii?Q?RBcHoThm+ioL7o7Te6xLv6y9iNYkcji2q+SmDwOfUJeUlpXy3HBu8j3aokkN?=
 =?us-ascii?Q?RVx3Uh1woAySyQDZ/rfH+9l/sbTu70wbd43ITSYP9HEvcexrqZr+/cbyyfle?=
 =?us-ascii?Q?Qp97Q+6iaPeSGNw+oeFQGz1sHRTY4Mn2CpohWGfvgdywcOg0Pkzd5n8SXPRc?=
 =?us-ascii?Q?GZfFkGvBYx1hnLUnFGBiHMcZv2A8yzRhOpyzh5u6GJz4OGfkon79/09iOtyI?=
 =?us-ascii?Q?s2mOuTzhuSQqXT4Yln/O+QMfBzG3LXksPnuFwagZgHsEU6unsiLiZD4TQ3C9?=
 =?us-ascii?Q?RlbAv1aNy5eZXorbTcr55/l812bl/k0pF3ndCbrNgeFgbOFkW7ePiTPVB0j+?=
 =?us-ascii?Q?/XX8T2ojeSUHTEPd8BU5skJzGerUZAFyOjosU4wJe8snoa93K2L+CDCz69DP?=
 =?us-ascii?Q?/5PO5vMDHybfc9medaWalWF64P/WzZvJn/oanez8e5zg1wZGH07QfnZJIy5u?=
 =?us-ascii?Q?RsCYIZ6Dqh1pfmG8VBPwpWuysOUm7zvLhJduoKRuttZ67zcm/2MK6ZYflWo8?=
 =?us-ascii?Q?l3ERQQ1xGAqWTvfnmXPTihJFBoQ3rhO95B2JK+FNZaHTvwKWUTYOqUJkPePK?=
 =?us-ascii?Q?boF9JguS2DOQ7w4gPgF71NbI7sU7/4NSXE7jcQH8SGLHYMqF8GGj5zv4m2ee?=
 =?us-ascii?Q?Hug7TnhJ06470IGXw+3d4a3P+88wn7ioVWH++FTB?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d3c03d86-7379-4f85-89e1-08dbdb25c451
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 21:59:06.8075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dYq5cvTwomV0X5Sai175ryO72nFEPa5LZwb1b+lJ5DnDcaWxqqnHrEqRrOIR09PBTcyFekIX1xPpcXvQm5g7NQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB5681
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 01 Nov 2023 15:00:30 -0700 (PDT)

Ira Weiny wrote:
> Smita Koralahalli wrote:
> 

[snip]

> > I think we should copy into each 
> > field of struct cxl_event_record_hdr individually starting from length 
> > by pointer arithmetic (which is definitely bad, but I cannot think of a 
> > better way to do this) and then do memcpy for data field in struct 
> > cxl_event_record_raw..
> > 
> > Any other suggestions would be helpful as well.
> 
> Based on Dan's suggestion to share the structures this memcpy can be
> avoided altogether.  Let's see how that works.

memcpy was removed.

> 
> > 
> > I can make these changes and validate it on my end if that works..?
> 
> Any testing would be welcome.  I don't have a test setup readily
> available.

Sorry this took so long but I have a new series with the
headers/structures re-aranged along with the other changes.

https://lore.kernel.org/all/20230601-cxl-cper-v3-0-0189d61f7956@intel.com/

Thanks,
Ira