Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <5b005b81-792a-4338-8085-e064c273f887@amd.com>
Date:   Thu, 2 Nov 2023 09:33:44 +0530
User-Agent: Mozilla Thunderbird
Reply-To: nikunj@amd.com
Subject: Re: [PATCH v5 05/14] virt: sev-guest: Add vmpck_id to snp_guest_dev
 struct
Content-Language: en-US
To:     Tom Lendacky <thomas.lendacky@amd.com>,
        Dionna Amalie Glaze <dionnaglaze@google.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org,
        bp@alien8.de, mingo@redhat.com, tglx@linutronix.de,
        dave.hansen@linux.intel.com, pgonda@google.com, seanjc@google.com,
        pbonzini@redhat.com
References: <20231030063652.68675-1-nikunj@amd.com>
 <20231030063652.68675-6-nikunj@amd.com>
 <CAAH4kHY_sM0DTL+EVz3GNDq1q_5S4FH1Ku9EMV0HOzFAY1s4QQ@mail.gmail.com>
 <57b904e1-9a17-9203-e275-4b5a31ca8a71@amd.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <57b904e1-9a17-9203-e275-4b5a31ca8a71@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGpHbmd2a2YreGdYalhYRmNmd2hESERxRVlCMkg2MGc1aE44MFAvV2FqNSt1?=
 =?utf-8?B?QmJIK0lZN1M4Ymhqd0xwSFJlRC9lbkVTb1lnU3ZvT3llVkRQNEhhWmFGbFZ3?=
 =?utf-8?B?R3pjNlMzamd3UGk2QnhuRFBFeEdHVUsySnBrTzlMTjFrRGl3TzdnTGhobFhY?=
 =?utf-8?B?aTBvNEk0UkE5NGJzRlo3a0xNRmtJM25NZVZyVmNqK1loaWF3Z2lOUmY5MitN?=
 =?utf-8?B?dEgrekgvaEhhZ2dIcG1OMjlSdU0wNmd6elpkQldxRU5DcjM0MFBjYTVyV05o?=
 =?utf-8?B?bnFHNzBXR0RpWjBrbTErUk9lM0kxZHJqZ3BtdU5zc1J4SUoxYjFTM3A4SHNw?=
 =?utf-8?B?TU5ZelJ0aC95YlhzUHRYZTM4K0o0TU1CVkg1L3g4V2hxejcwcmlrTUJrY3A0?=
 =?utf-8?B?TEtDUjVsN09YeHNCYzlFeTNoSDNkNnM3YnpwaVlwK2V0SHladkdIWDlBeGVT?=
 =?utf-8?B?V2wrT25SeURvYjNWaUhRWXBsTzBpbUh4QmRERk9XRklXeThBMkhIVUh6ZDFk?=
 =?utf-8?B?TTAvanpsd1daTXVsQ2tPL1RPaDZjeGkxM1dLcDJaSDY0bnJpTDVST2V3ckFM?=
 =?utf-8?B?UkxBb0NYejY5cmw3OE1XdjJFNE82ek5MWGNoaTJUcSt0WVhUbG1CdERGQVBw?=
 =?utf-8?B?aTNZSlhubkd1NSt3SHFGblRiRW9weGg2QTNrNm5sdFhvMDljSGlhdnBtOU0r?=
 =?utf-8?B?QTJZVTZjVjZ1Y25HWWNqc1BwRW1sNjE0dGlJdkVTcTQ4NC9UbXNFVkhDRzhO?=
 =?utf-8?B?VDZETGw0RXV5RSthWk9oT0dMcnZsTzlQQ2JGQkVLbzRjTkl5NG5SVk8rOER1?=
 =?utf-8?B?ckJBTEw5UkcwbUtQSlFYcHFTRGNQbkpTbEtmVEhtOWp3UTJLTFArSFk0RjRx?=
 =?utf-8?B?QmgvSW91S3NBZk1SUFM0ZXdGdDh5MVIyZkZxVm1Ja3haZk02c0xXYU1rSEVq?=
 =?utf-8?B?SFV4R3NBdjV5QWNuTllpbGRua2xvRGUxMEcwUnpkZkZLTTZMbTNTT0dpNmU1?=
 =?utf-8?B?Ni8rU1pvMC9aQjkxWTB4eDRqSnZjQmVFTlVXc1FKVlBjQWVIYm5hUDF0Z0dG?=
 =?utf-8?B?NDBMZU5mRWRmWjRuZjFvejJWcWRaVFVWTnlLS2VtUTJ0VGlRQzNzWUNBQ3JT?=
 =?utf-8?B?Tnh5ZE02Rmo4WnN5THliWkVVT3NCZEpYTVFCRTVYenZ1V3Y1MGY0S0syckRv?=
 =?utf-8?B?QmZnYWlQTEtDM1FQd2NkNTdLVWZxNENFeklPbGRubjRaaGJTZHBINFhKZmcy?=
 =?utf-8?B?eG14YllCMVhkVEVodGdVVjRiRzRZN3BSRm0vRjNWOXFQUWxBdUdOU1Q2ZEZh?=
 =?utf-8?B?OGl3a2grTTNRYWR6Y2dZZjBBUHJ6TnhmZGJiTFE5dGpWNEg5Z3o2d1ZEN1ZL?=
 =?utf-8?B?dm15aWgrVnRwZjNMYi8vM1hTK0k1NEwwMWV6WllwK0NLb2E0VGdBYnN0L0or?=
 =?utf-8?B?QmFkd1hldTR6N1VPSmFTRlFqbXhSWW9KT0JUQUVEdVBKaGp1bnV2eEpEM2Y4?=
 =?utf-8?B?Y2thQ1BQM1k5MTdVSG5kNm55K0ZIRVo4K3NWUHJ3QlhhUnFUMFNIcUxZb2R2?=
 =?utf-8?B?cFhqc0RRMVVRTmJaMVhPMjVDOVJ3OEVoUnVBenMrRGRaUCtiUlR5NU9pT05G?=
 =?utf-8?B?MlNVVkkrVkpaTUVHeUNiTG1zV0JDUFIyVnBVSVlUWkhFVGtHWWFmTXBQaDR3?=
 =?utf-8?B?dWkwOW9VVUVXMndHRThCSDVwOHk4bUl3Y1hQeFYzM0ZIN1NOTzJiYjJndjN1?=
 =?utf-8?B?dmc5aG83MXVrMnZNNk02eTNFdlpNRkhRYlY3UWpWcHo5MTg0RkpCRVh2SXZN?=
 =?utf-8?B?ai9UWjhGSG5nRXNKYzNjRXpQS0NVSmNGS2xCOU5zQnJ5OG5aZWRweWJhdXhp?=
 =?utf-8?B?dko4TlFSSkE4Mng5ZXFmRWtqK01YcnoyS1NXaXQvb1VHVjF1dk9lMllNR2M0?=
 =?utf-8?B?VTVmMEpacTRZWXBHL0h2bC9Rb2VHT0xsZ3JsZVVBQkdabmFxU0c3MlNzM0Z6?=
 =?utf-8?B?YTlsOGpVUHdpNmFqb3pwNWRrN2J2akNDYWkwWjhxVXoxbkZmNGtoK2ZMWkor?=
 =?utf-8?B?Vzl0ZG9seXc0ZG9ZeTJmcEEzVDJRNnpuaWFOWFFSNCsxZ0hnYi9LQytzcnN3?=
 =?utf-8?Q?1ou2mVcf54tFcNdXQKS3QN3pR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc6a22aa-9f55-445e-e22a-08dbdb58baf7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 04:03:54.6878
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6UkLklcAiw0Hf1rXlwXgWNx2yVC+ujoSSbz9pZs9zKWQ6eWQCdMXa/Ycqfu9KnAqyJm8vtAMGASEnXeLZ4c5wg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5514
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 01 Nov 2023 21:05:09 -0700 (PDT)

On 10/30/2023 10:42 PM, Tom Lendacky wrote:
> On 10/30/23 11:16, Dionna Amalie Glaze wrote:
>> On Sun, Oct 29, 2023 at 11:38 PM Nikunj A Dadhania <nikunj@amd.com> wrote:

>>> @@ -656,32 +674,14 @@ static const struct file_operations snp_guest_fops = {
>>>          .unlocked_ioctl = snp_guest_ioctl,
>>>   };
>>>
>>> -static u8 *get_vmpck(int id, struct snp_secrets_page_layout *layout, u32 **seqno)
>>> +bool snp_assign_vmpck(struct snp_guest_dev *dev, int vmpck_id)
>>>   {
>>> -       u8 *key = NULL;
>>> +       if (WARN_ON(vmpck_id > 3))
>>> +               return false;
>>
>> The vmpck_id is an int for some reason, so < 0 is also a problem. Can
>> we not use unsigned int?

Yes, I will update that in my next revision,

Thanks
Nikunj