Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <193a0476-042f-4766-9637-5ad25fd6f3e2@amd.com>
Date:   Thu, 2 Nov 2023 10:00:30 +0530
User-Agent: Mozilla Thunderbird
Reply-To: nikunj@amd.com
Subject: Re: [PATCH v5 08/14] x86/mm: Add generic guest initialization hook
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>, linux-kernel@vger.kernel.org,
        thomas.lendacky@amd.com, x86@kernel.org, kvm@vger.kernel.org
Cc:     bp@alien8.de, mingo@redhat.com, tglx@linutronix.de,
        dave.hansen@linux.intel.com, dionnaglaze@google.com,
        pgonda@google.com, seanjc@google.com, pbonzini@redhat.com
References: <20231030063652.68675-1-nikunj@amd.com>
 <20231030063652.68675-9-nikunj@amd.com>
 <32e898b4-3567-4d4b-9f18-80a20d05db1e@intel.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <32e898b4-3567-4d4b-9f18-80a20d05db1e@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTdoS1VIQ0NDajZuUGhwTUNFeXRaZjlMN2plcWJ2MUpFOUk2MGlQYk9hYTQv?=
 =?utf-8?B?bzFjU0hVT2R3MDZFL05XdndlQ1ZiQXBXazlDYUU1eC9qZ1JpNno1OEorUW1R?=
 =?utf-8?B?MjJ6VUllWHZZWWxmRHhzSWh3NnMyR2RWWEZrdWdPc2tuVmE1cnhKSWhvTWxZ?=
 =?utf-8?B?UzlqalJkTFo1N0ozTkc0RUxzRzlwWEJiSVRsZnd3dFAzYzI2Umc0d1hKUnZQ?=
 =?utf-8?B?YVVlOEM5WVdHMTc3NnNMNDNYU0hkVVRpVW1zTHdvanRFeGhYS3R4VHBISlY3?=
 =?utf-8?B?K2c2b2IwYTR5NU02VDNHaStoM3dIZnlzWjR6anR4QlF4blZONHlwdzNiS3p4?=
 =?utf-8?B?ZGZMSDY1Z3Y4MFBKVEpDSS9QaWZaZHBzYmNFVm1MZlBxZUZwSk5MRnl4WnZY?=
 =?utf-8?B?Z0wvemNkM0ZLZWN2L2FoZGZUL3FKdXRxd3BPNkFqeEVVc3NTditVVFRtNnNU?=
 =?utf-8?B?djFGQXJhMGo5TUYxL0U2cmU1M2hFdXQ5RlNBNVhaYWltN1lnYXBXbDdQb0w4?=
 =?utf-8?B?WkhPQ09XVVI4ckJBdURQdzBMb0oxRTV6by96OXNIZUJhR0xDU212a2xFL0hk?=
 =?utf-8?B?ZjZYN0U2bDRGZDBSZDhubnJjT1UwTFhET0htdm1OOWsybUlDTHVHT3RacExn?=
 =?utf-8?B?ZkJZUUdsK0g3Q2N6bnFvUU40RnhkMVVhL2w4ck9uVFkySXVZVGZtdjJFd3I1?=
 =?utf-8?B?UE9jYzQ0VU42U0ltQkV2L2labnh6cnU4Y0xMUWxLOUlwUkFVeWhDL01tUy95?=
 =?utf-8?B?ejdzRHFvVTE2Ly9hME1PZlZBY2RkcG82Um0xUi9tWVEvV1NvZHoxOWZHTk9i?=
 =?utf-8?B?aXZCZHJLZjdYTVhQdk1pWHl5bmVtTjcxcFFzM3BrQXNWRUg5TUlhVWF6Y1hS?=
 =?utf-8?B?MStLNDhaU3pxdGJDYmNCQU1vOSs5RmZyMG9iOW5aVUlnVytUb2NXcjNVdjVN?=
 =?utf-8?B?ZjNBTnZmdkJ0czJ3ZklDVFR6cWRqNmRWbGo3YW9EVUpKNG9LcHZmeG9nYmtj?=
 =?utf-8?B?MWFrM3hiTXJiNU1PZUpUWDhuNkFFRE9yMXpmL3JDbmxUbkk0USs0UDRRSjFQ?=
 =?utf-8?B?MU9pdUFWeW05TkR0UXBmZTVnako2aGNkUU9oRWp4ZWIxKzZJODNnZmxyaVhu?=
 =?utf-8?B?bGlTNnl6MnhXcDZWb2pLQjRBRlJzUFdQMlJsWXlZVmYvWVN2bzJxME5Wa0Y1?=
 =?utf-8?B?QUxFS2t6dWV2UW5IV1psb2wxdm5EeTdiNVFoRExadkNqNTEweDNlK2pITnVT?=
 =?utf-8?B?U0pOY0Q4L3oxZE5KWVl0SEIyT3d6SDFGTmVXZ1lKSytrQnhLMFZoWG9tckNR?=
 =?utf-8?B?T1dIdjB1dEp3V3k5L3ZOR0dHaGtnMCt6aktVMEQ4WTNaTnRxWjY2MVJ4VEJX?=
 =?utf-8?B?OFg4eStFVjV1SW1xMkVUdXl4cjREVHNvTmRLZU5ibUN2b3VJeUFHdzZVZUVk?=
 =?utf-8?B?NStLRk4zZk94K3V0UldNbXpwdzdtVkQ1MmtIYXVLY0tXcFRscXFxZ0t4d0pC?=
 =?utf-8?B?b204U2I0RWdZNm5yKzJyWVFvdEJPTDQyenh4Vnp6M2U2MDBYcEtIc1Z1Vkpi?=
 =?utf-8?B?Nlp5dWFCRWtoMzF1V0N0cUcvUFArSnlRQ0NtbTNVUTd3c1k4RHJaSnpUSkRP?=
 =?utf-8?B?WEllaVh5dmJUUE11OVNEaytxVENidlN6cXJjVUJVNmNUNExzYUgyNTdET0N6?=
 =?utf-8?B?K1E0OFZwQzNzL3hpSDBNSjZadDl6WW1PY2k4SlQ4YjArN0wyVkpOMDZvcGNP?=
 =?utf-8?B?RXpVWnlxT00rWUkrN3FZL1Jqazh3aSt0OWloUjUrbHNEWnczNjNNL25JZTkz?=
 =?utf-8?B?Qi92cXU2ZVF0cUZWRmlTZFBoN05CNXFUZ3hiVWFZcE9qc1l3T1pEYm1nVHVI?=
 =?utf-8?B?M25NZjJaZTdlRVkrTmF3NEM0UFpkMDk1V0VpUjRUeDNielNaVjNIUDcybDUr?=
 =?utf-8?B?bUNZb2lmSURFVnNkNnlJWEdhWmZkeVp3eGpDWHhnc3ltdW81NzY0R2xDdHp1?=
 =?utf-8?B?ZjNSSmxMV3dqRDFCNWRxazBXSzl5ODRraHlWc3RPMGlXRWZHL3U5THpJSkNK?=
 =?utf-8?B?eVdjWHMyVEJ4V2w4MHhWd3VIZlJ3cWVDZFZIcUJzcmpVYjRkS3p5Y2JYTWox?=
 =?utf-8?Q?19JgDofnbN4vm3Ov5PdiFWeZh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ab6036f-8b61-431d-a5fb-08dbdb5c78a1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 04:30:41.4065
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FRbVNgimIS6jdSrJngrFTkb6YLirIlQudFyVyykg0VCSYEfUFKf67lpNNK7Z1iKRcb1xhKJxnFnIGPpyUPyAUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4093
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 01 Nov 2023 21:31:00 -0700 (PDT)

On 10/30/2023 10:53 PM, Dave Hansen wrote:
> On 10/29/23 23:36, Nikunj A Dadhania wrote:
>> diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c
>> index a37ebd3b4773..a07985a96ca5 100644
>> --- a/arch/x86/kernel/x86_init.c
>> +++ b/arch/x86/kernel/x86_init.c
>> @@ -136,6 +136,7 @@ static bool enc_status_change_finish_noop(unsigned long vaddr, int npages, bool
>>  static bool enc_tlb_flush_required_noop(bool enc) { return false; }
>>  static bool enc_cache_flush_required_noop(void) { return false; }
>>  static bool is_private_mmio_noop(u64 addr) {return false; }
>> +static void enc_init_noop(void) { }
>>  
>>  struct x86_platform_ops x86_platform __ro_after_init = {
>>  	.calibrate_cpu			= native_calibrate_cpu_early,
>> @@ -158,6 +159,7 @@ struct x86_platform_ops x86_platform __ro_after_init = {
>>  		.enc_status_change_finish  = enc_status_change_finish_noop,
>>  		.enc_tlb_flush_required	   = enc_tlb_flush_required_noop,
>>  		.enc_cache_flush_required  = enc_cache_flush_required_noop,
>> +		.enc_init		   = enc_init_noop,
>>  	},
>>  };
>>  
>> diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
>> index 9f27e14e185f..01abecc9a774 100644
>> --- a/arch/x86/mm/mem_encrypt.c
>> +++ b/arch/x86/mm/mem_encrypt.c
>> @@ -84,5 +84,8 @@ void __init mem_encrypt_init(void)
>>  	/* Call into SWIOTLB to update the SWIOTLB DMA buffers */
>>  	swiotlb_update_mem_attributes();
>>  
>> +	if (x86_platform.guest.enc_init)
>> +		x86_platform.guest.enc_init();
>> +
>>  	print_mem_encrypt_feature_info();
>>  }
> 
> How does '.enc_init' ever get set to NULL?  Isn't the point of having
> and using a 'noop' function so that you don't have to do NULL checks?

True, I will remove the check.

Regards
Nikunj