Received: by 2002:a05:7412:b795:b0:e2:908c:2ebd with SMTP id iv21csp155417rdb; Wed, 1 Nov 2023 22:07:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGROc2a5RP1ymHiZlPcjSqRCCcOxDjxXNyOJZILhZnZ2D9U11456qkxvsIB2sEOMiWqJAdh X-Received: by 2002:a05:6359:800e:b0:168:d90a:f72 with SMTP id rc14-20020a056359800e00b00168d90a0f72mr16213077rwb.28.1698901672169; Wed, 01 Nov 2023 22:07:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698901672; cv=none; d=google.com; s=arc-20160816; b=LDytK3kAXpvqVgH7CRb2TupUvbc945NqSKtikYTmv9AWcwV00WL7PKgubTQCapctfD MWiuBd6aE4dY2grLsXYsDUGcAaDO2GDw2id2BR3NN4wN2YbAW1EWY1CWHboyBvF9hTiL NS4JeIiE7nDmo7kq887UsA9Bnz7FBFj+jjhnBMEzUMVLAoQxtp7x2M+nLDmHolAjaBUN 5qEAh/EF4U+Kugp4fVe4TDMgknRiNyV3kOdg0Dzb9EPRCLHO212DhYKfCYJ/x0VBwEa8 151odaIFNqhgiyl076sAJRpdkGpmmlSXCczUsZuaiCXMslPYsR9kZk2v3HEyTQitILVf rEgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=5maFj4nqhBa5Bm26fdrYwGmw8q8AU7XC/qOYHFZqGyk=; fh=+BlwdlqDD1ZRglnRtYILFPTMVqM8pS/eOHg2ritYTB4=; b=ciXvP8FY72w+cfAOFuwiAEW/ZB+F9wcRZrm54cSC7aWOvLGz33dYbCyKr7Mra1esym fPl/t0NBs+IN1yRotODpfV1ACnl3dKp+1IEJXd74cS6O80NdCTgr/Umul6tpB17xxdF/ oM4Tf3BnZlzwlanBAe+9BwY15szJ9fDldkNF0B09lm18tTaxs9jo0mllzaqgfKoTeenq MqSYnx4AEQ6t0iTjfnH0eJ4FtlZL/q4FKNThNZcw/rbyMwGACvG5WOxqXbox4lsDCuYs DR/ITiQzlDJ3oTIdn4HpP0MEB7sBl4TfDYof8a/+2SXhRdWG1SA56pf0QbVtoy+SU4D2 s/NQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TqDFwTYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id o14-20020a656a4e000000b00565f0e91894si1361434pgu.394.2023.11.01.22.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 22:07:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TqDFwTYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D70238023EC2; Wed, 1 Nov 2023 22:07:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348448AbjKBFHh (ORCPT + 99 others); Thu, 2 Nov 2023 01:07:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbjKBFHg (ORCPT ); Thu, 2 Nov 2023 01:07:36 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DACFFB; Wed, 1 Nov 2023 22:07:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0153C433C7; Thu, 2 Nov 2023 05:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698901653; bh=bEaqdWR5b16aP9FDPsmLQydpfrRhMcFq4QOwyVtFKS0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TqDFwTYbT8gI8nvfa1xBpWQh9zmD09Z+mSW4JUajvZ+0YIvjbFd8KLQ8ha0Yzp5Ub E8uUwtAOMjzxKY6WJy9nwXKFL42E4PtHR6/CHL2Uw6kZJnAqxT12zgwmWktS6Yyh4g moP5nIAyrl331+He0lEmuZ8RFON57hqb9gTLg9F5N2WQcHQ/fSKlC8hB48XvTGuNzR mHJXoi1I4WrOjLGfu36QE/7BhbzrT/MyOq2INwpRZIFE/CQI9doBRuz1HU2/ehCMTI pfqAeEqo5YiNcWkzG21X8vmkgIKVYTIpF7DgoQ8e6hAHM1DY3XXN3/6pnIqNN3hWJX H8F4kwsqfpiSg== Date: Wed, 1 Nov 2023 22:07:30 -0700 From: Jakub Kicinski To: Haiyang Zhang Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, kys@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, edumazet@google.com, pabeni@redhat.com, davem@davemloft.net, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net,v2] hv_netvsc: fix race of netvsc and VF register_netdevice Message-ID: <20231101220730.2b7cc7d1@kernel.org> In-Reply-To: <1698355354-12869-1-git-send-email-haiyangz@microsoft.com> References: <1698355354-12869-1-git-send-email-haiyangz@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 01 Nov 2023 22:07:43 -0700 (PDT) On Thu, 26 Oct 2023 14:22:34 -0700 Haiyang Zhang wrote: > And, move register_netdevice_notifier() earlier, so the call back > function is set before probing. Are you sure you need this? I thought the netdev notifier "replays" registration events (i.e. sends "fake" events for already present netdevs). If I'm wrong this should still be a separate patch from the rtnl reorder. -- pw-bot: cr