Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <5b6f1d00-8dcd-49d8-98bc-53638ec5b43e@amd.com>
Date:   Thu, 2 Nov 2023 10:43:45 +0530
User-Agent: Mozilla Thunderbird
Reply-To: nikunj@amd.com
Subject: Re: [PATCH v5 09/14] x86/sev: Add Secure TSC support for SNP guests
Content-Language: en-US
To:     Dionna Amalie Glaze <dionnaglaze@google.com>
Cc:     linux-kernel@vger.kernel.org, thomas.lendacky@amd.com,
        x86@kernel.org, kvm@vger.kernel.org, bp@alien8.de,
        mingo@redhat.com, tglx@linutronix.de, dave.hansen@linux.intel.com,
        pgonda@google.com, seanjc@google.com, pbonzini@redhat.com
References: <20231030063652.68675-1-nikunj@amd.com>
 <20231030063652.68675-10-nikunj@amd.com>
 <CAAH4kHbceVXo_==J7K4f5kTbCYj=SQWQNDs2CAAms3vdreG7cw@mail.gmail.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <CAAH4kHbceVXo_==J7K4f5kTbCYj=SQWQNDs2CAAms3vdreG7cw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RExQejE4MTdlL0Q4TGs2eStyRDRaQjRCMzlQT2Z4bGV2Nyt3d1k1a0Vha0Rz?=
 =?utf-8?B?QjlPcEx3NHR3MmxoQTdrLzFPZTlvY0xPSDIwclFWZVl3a1k3RTB6U08vT2lo?=
 =?utf-8?B?Yi9rTVhENS9jUjhra1A1Q2xNMysrenp2ZHhjUW04VzEvemdkbmhtSjJuR2xX?=
 =?utf-8?B?TEYrOER0bFlKR1o4ZThJcTI4blYyVEtDb1R5ZU1samRXdXJRRTlGbm50USsv?=
 =?utf-8?B?aHNRa3dCek9YT1V5MHhnNG9nRThieDVDTzRSTng1STVkd3pQUEhISFV4RnVY?=
 =?utf-8?B?K3pDS2pxV3Rva0JkajIwNXVadmYyNGxiU2pJOXBFeVVnRThjNVBEU2VtTEZI?=
 =?utf-8?B?MTdiMnA5Y1Q3YTZ6K1JmT3cwaHpqV2tlQjVPVkdudnFUSHJwTU0vcEpwSUFN?=
 =?utf-8?B?N21YU2t3YnJVcVVwNlhQRzB4Z2FNOEROY3BZdkE4NHYzeVkveUpvTU11a1FH?=
 =?utf-8?B?cURxVURKUlRrMUs0U2F2RGIwdENQaFZYSjEyaHhhdkdEdHNWeFA0MUxYc1hv?=
 =?utf-8?B?Z2VEODlwVmwrL2ZvdlRQdEMzbnp5Q3VGTENtckkxR05naE9RUVVjOTNHVEd0?=
 =?utf-8?B?Tjg4S2MxOVE0WEE3Rk1ORHAwMENJYzdRQzBQR1RNYUNUWm04KzBHYjF5QmdH?=
 =?utf-8?B?aGoxU09EU295alJKUnJyN2p2T2E1U0NkUUtXU1V3d0hUbHFkR0VtSGNtSHNi?=
 =?utf-8?B?Q1h0QWVVV0tYc1dRSlh6Y0JtTHZuN3NJTVArUnJFSTB4WGdlZGdTaVZlcHBl?=
 =?utf-8?B?K2NJMXJSL09LSnJVV0sydmVHY1lPTiszaVVmS0ZiMzNYb2xiNVcwQjJ1TVFz?=
 =?utf-8?B?dHdmNnQvY1pwaEIwOXB2SEM5ZE53K1hmT2FiekdBRWNITC9Oc040VjlHTzIy?=
 =?utf-8?B?djNDVWZFc0w1VUdmOXNzaGkzeU1uUm02YzRidkRpMGZyRHRld0dqVm5MQnBG?=
 =?utf-8?B?bjlTNGZIeVN1ZWxDcWQrNlp6aThDMlRKWW90VlRsU1JuYTFkMG5za0tnM2tk?=
 =?utf-8?B?L2MrOWhmZmpBSFJSN0NoVElzQjNuWnIvdG5qMVUrZjZ2ZmpkeDJuV2t5Ymhm?=
 =?utf-8?B?LzVPY2l0S1RXUUxGWEpYN2pXRitFSDNXNFFnd2ZRUEFpWUZUTEU1S2Nac2JD?=
 =?utf-8?B?MXNRcjFQcU4xenJMWmpnK3RTUDRodVVka2RucU93Q0hmVis1aVlhZVZ1UElE?=
 =?utf-8?B?SHFzaXFJVDgvNFFZaGw4UTVqU1hlRCtiUk1teXViaUsyMVh2aE5yRVFPajUz?=
 =?utf-8?B?YkVVOXR0L05pNW1UUTA5dEVCZjFmaE8wengzaEo3Kzg5ZmNSRzRxOEMvU2FO?=
 =?utf-8?B?N2Q2aGNyMVZEamgyOU5NNUloOXVuNVV6ZVNIdldMQW9mZHZlaGwrcnd4NlhR?=
 =?utf-8?B?L2E0VlljTHAweGR3M0JTWHpxQWpBR2RwS3hMRk1MQWppUmxBSU95UWhWZHAr?=
 =?utf-8?B?TUt2ZXRrS0FNWWhCa1RvbndyMThUamg3eWQyeEFSV0ordHl6L1p2WThuOUwz?=
 =?utf-8?B?RStPZVZJaFV0Y3l2ZElsYWdJaFZnSlJUUjBIYUlobXZ6aWFvaVcyZUJXN25o?=
 =?utf-8?B?dWplL3BDbC9sM3NrQjVhVzljOXN0dWVCNW4zUmt1dmNGeEQ1aG51L2tteklP?=
 =?utf-8?B?aG5mWDgzaFBzanIyS25iTHY1blFjVFBXWFJhQWk1b09McjM2Qys0VnRzMXJs?=
 =?utf-8?B?dWlQV1VnSWozeHRhZGx2dDViS01QVUJMajVwREROY1FaRGNiT1FVMzRtbDVQ?=
 =?utf-8?B?S2J2U1VxM0JBTmVncndZelpQbzdRNTdJdzVDQ3NXNVd1L1hKanhaSmVKVERZ?=
 =?utf-8?B?UnJUUGFVTUxpcXU5RDNUa3B0Zm1hUFd4d3hZVENhSk9tMmZGMXZiREw1RFZD?=
 =?utf-8?B?N3llUzIrQ1UrMjdBRUJxeXU5QkFremJFRllzRWZ4dWVIa1VZUVBjQk5sMmhK?=
 =?utf-8?B?dG9tb0xkR0ZUYk9qRTR1YXJEY1hFN0dSanZHd0s4T3FsMnUwaW1iY0ExS29D?=
 =?utf-8?B?bXNvcjdrU1RCdm1GWm9pR2JMaFVIWXAxNFU5UzVPOXMvQ1VCdU5SR1pMbFVY?=
 =?utf-8?B?TjVqWHJCSVlDcERmUWw1NmZ2RUtTd1dMTFRCNmY5ditkM1FGYnVYKzBkQ3VL?=
 =?utf-8?Q?GZ/V3Aoh6xPBmN9F5UHSFszTc?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25e67970-6bae-4cc3-31f1-08dbdb628328
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 05:13:56.0103
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eYtMCPXrXQJYC8tSmlRRXVcLs0dGo80mjPELTdTk/KlNEZTzr384/q8e67/ZVQwj83drtYC8//THZOlMPQmo3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5638
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 01 Nov 2023 22:14:10 -0700 (PDT)

On 10/30/2023 10:16 PM, Dionna Amalie Glaze wrote:
> On Sun, Oct 29, 2023 at 11:38 PM Nikunj A Dadhania <nikunj@amd.com> wrote:
>>

>> @@ -1393,6 +1397,78 @@ bool snp_assign_vmpck(struct snp_guest_dev *dev, unsigned int vmpck_id)
>>  }
>>  EXPORT_SYMBOL_GPL(snp_assign_vmpck);
>>
>> +static struct snp_guest_dev tsc_snp_dev __initdata;
>> +
>> +static int __init snp_get_tsc_info(void)
>> +{
>> +       static u8 buf[SNP_TSC_INFO_REQ_SZ + AUTHTAG_LEN];
>> +       struct snp_guest_request_ioctl rio;
>> +       struct snp_tsc_info_resp tsc_resp;
>> +       struct snp_tsc_info_req tsc_req;
>> +       struct snp_guest_req req;
>> +       int rc, resp_len;
>> +
>> +       /*
>> +        * The intermediate response buffer is used while decrypting the
>> +        * response payload. Make sure that it has enough space to cover the
>> +        * authtag.
>> +        */
>> +       resp_len = sizeof(tsc_resp) + AUTHTAG_LEN;
>> +       if (sizeof(buf) < resp_len)
>> +               return -EINVAL;
>> +
>> +       memset(&tsc_req, 0, sizeof(tsc_req));
>> +       memset(&req, 0, sizeof(req));
>> +       memset(&rio, 0, sizeof(rio));
>> +       memset(buf, 0, sizeof(buf));
>> +
>> +       if (!snp_assign_vmpck(&tsc_snp_dev, 0))
>> +               return -EINVAL;
>> +
> 
> I don't see a requirement for VMPL0 in the API docs. I just see "When
> a guest creates its own VMSA, it must query the PSP for information
> with the TSC_INFO message to determine the correct values to write
> into GUEST_TSC_SCALE and GUEST_TSC_OFFSET". 

The request should work irrespective of the VMPL level. 

> In that case, I don't see
> a particular use for this request in Linux. I would expect it either
> in the UEFI or in SVSM. Is this code path explicitly for direct boot
> to Linux? If so, did I miss that documentation in this patch series?

This works with UEFI boot. I havent tried this with SVSM yet.

Thanks
Nikunj