Received: by 2002:a05:7412:b795:b0:e2:908c:2ebd with SMTP id iv21csp159304rdb; Wed, 1 Nov 2023 22:21:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZyhrTtCh3qLgBeXbD5OxBjCwJIHYpDPAyjmRQFlsqO5K9kYr7J7gewd9nrOhVvJpneI66 X-Received: by 2002:a05:6870:e984:b0:1d5:a58d:1317 with SMTP id r4-20020a056870e98400b001d5a58d1317mr22043261oao.10.1698902463304; Wed, 01 Nov 2023 22:21:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698902463; cv=none; d=google.com; s=arc-20160816; b=pscQmTQ2ZNclwWkC/ahklNXLzbCWAYka0K0L9R/fu58Q+VWhYnyK46mJqst4iswIDY IV6VX4MNWmBdccn0Js+ymbv6JQFLzqKzxxI5GT/0y6+GZA/EGUrBI4NUckjalPzf6Kba sY8uyUrQFzHQ2Yd8EZlcX4FRleBQyafotH1swNj1ydGb1l3AzF4IR/VdkqGAv4EbqIsN BWW6MnRQ21Q4azIJblSq87edN2YvUb7nngZc20PPDvpXWdedHk5EMp6/eO0fshQlxq5K trKDpXg5tQYkmvBPce6v+65rxaM0jBAOgddhfWTIHfSZDydmRtcHynPs8H/KCXn1+Ezd /X9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=feEGsZGMZpNpvuY2tYK4OOCZ99yhvDyzE094c0JU0jY=; fh=RJ1+rxGg7mSoO5ww3dmnNZMb5YzXqxGt340zfIZ/bis=; b=DOTR1BZMXSud0VyhVSety0xaBjLXV2F6azouKy8Q5uXL1kRXrnj9U4zvubrdipw23b vABqDV9WoCQRD/lsZgTcUKldWyDTnMPa7nMKIZ5flI+Sla3msopTiJhzicUeS4FT+Qph SIGUdetmjNtFT77e+rKNZ2hx4k9taDL+fk+eHBvH5lJ1P1FtwQ9PjTf/Tax+qhAtvvru 6YHlWeaF2N0iut0gMX4LgtCvwuKrp2SubPLv69vW23NSGdWT63bqEU4wZU1gelMae2f+ GuyGYblt3dWwEk2FVYEA9zyzMLnlP0QiLAGYjx1x1NxuztS8yxpJmnxFX6TfKDLi6CkJ okfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YwvoDwyl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id g1-20020a636b01000000b005a1d8815ec0si1152500pgc.37.2023.11.01.22.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 22:21:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YwvoDwyl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 2BF3E802AFFE; Wed, 1 Nov 2023 22:21:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348522AbjKBFUx (ORCPT + 99 others); Thu, 2 Nov 2023 01:20:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348472AbjKBFUw (ORCPT ); Thu, 2 Nov 2023 01:20:52 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FDAE116 for ; Wed, 1 Nov 2023 22:20:48 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11B99C433C7; Thu, 2 Nov 2023 05:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698902447; bh=YhTfqLur7/NQtlk8H9Cl3X4eNRRBK1DfeII4CpjFXWA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YwvoDwylHxhrQyMNZbt0YmegaTf9VzAd4jgxPYpYAtTO7666H2DmLp8VFckNRA7h1 MMgYO7qoq1L+fb9FEEvfpWyPcBvJSHz0jDxas40g1w+CMBmtqL4HomNCruvYXQUu6h MdoRq11FdCH0bqi9SUsWu0BNt6L6jwgdPj+mj9HDCTnxoVTTqUmNDuXPE/9bXHl425 NVBxLI5LTI2EfOQHyIVSlTpBEKh9gy15O/+HvoojJmvaQ/5eAaA9U41USFeRQpZCj9 rYPr6zaDl6y5IMr6Uy2isOl4Ul8QenaA9LN6IG/iWVE5Uz+XegdK3EjzVXBM03nvFt ZMMDQT1Q4fIig== Date: Wed, 1 Nov 2023 22:20:45 -0700 From: Jakub Kicinski To: Shigeru Yoshida Cc: stefanha@redhat.com, sgarzare@redhat.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] virtio/vsock: Fix uninit-value in virtio_transport_recv_pkt() Message-ID: <20231101222045.5f7cca01@kernel.org> In-Reply-To: <20231026150154.3536433-1-syoshida@redhat.com> References: <20231026150154.3536433-1-syoshida@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 01 Nov 2023 22:21:00 -0700 (PDT) On Fri, 27 Oct 2023 00:01:54 +0900 Shigeru Yoshida wrote: > This issue occurs because the `buf_alloc` and `fwd_cnt` fields of the > `struct virtio_vsock_hdr` are not initialized when a new skb is allocated > in `virtio_transport_alloc_skb()`. This patch resolves the issue by > initializing these fields during allocation. We didn't manage to apply this before the merge window, and now the trees have converged. Patch no longer applies cleanly to net. Please rebase & repost. -- pw-bot: cr