Received: by 2002:a05:7412:b795:b0:e2:908c:2ebd with SMTP id iv21csp162404rdb; Wed, 1 Nov 2023 22:31:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFh45YTgtJmiJNa9ccksPx/tJRIe+awt9gL5JgvaPvTBz494hCpTjGI67L9yuA8ffreesEi X-Received: by 2002:a05:6808:8e1:b0:3b2:dad1:72d3 with SMTP id d1-20020a05680808e100b003b2dad172d3mr19888139oic.50.1698903094954; Wed, 01 Nov 2023 22:31:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1698903094; cv=pass; d=google.com; s=arc-20160816; b=wyYe5Do3ZCynzqo9kToYgSRQmRPHKS5ur/YTbqgsdVmJGnW6iMEZjWyZQJ82rMzPX/ WrLRaVrD6JzDVnxILC1/OuuGYq7BmDo4VTk3SomZaYfGsd3xsKIZ89Cmb05bNO8guoi2 tkU8qxibKjbVN6u+Kn/2vmbvIksKDtuDn0YQww3CMVffQA3DaM6WuoL9Nh4oz5vqYbL/ a53kZP6MF4fkQAtlcbYAxBSq4cp1UhPhvDD4stgq+6AR6ZZkQqmFKqqzifEck5oexB41 80AouxQDGTaohwIhMIRjPeJZ9aWBby7/PVwI3+VO9neRjMjLQrL98CVIjeVKIpIdIBpQ gt6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=6BUkUgTTJ5IXTWNw17hcoqHW4N1eJU4OTUwAfEyw9O0=; fh=dKWgqA0+Q50QgjyyevMdVXLcrZwmgFQchivROBncpWk=; b=dhPg3JGRWqnTQ+bAzvwo2uX3U0Wzb3VlBfRfttlUUDMI9xx7bIOZ2JLHplwQC+Q2kn TYM9OYZULytcarmr8TuRHfSsVUDy0TlBooZ6eVDe+5IlgpIKodJ71xxlYCBKQO1UyJNX t4D2Xi9D2pdi0xcp5XGiLV9odf28+2k9YpsoNeP9unwqePiMWTXAoE3JvBBuIGeMK8cb eglZyHq3X/kVS8Ok62ReXWHIa6qa+si6FGJwuqLcSFI6LM9/JARZYNmVPnKc2fdrK0Wg Fid1XLJiIxALt706mNPtTgWiVrtkUR88WfF8PIdfMkz3grcuNWu4K1AluNywK3GSzgKT dzIA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XOZ6dGV6; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id ck5-20020a056a00328500b00690f9e835d8si3059735pfb.132.2023.11.01.22.31.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 22:31:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XOZ6dGV6; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 750148093D7B; Wed, 1 Nov 2023 22:30:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348552AbjKBFaj (ORCPT + 99 others); Thu, 2 Nov 2023 01:30:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348448AbjKBFah (ORCPT ); Thu, 2 Nov 2023 01:30:37 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B36C12B; Wed, 1 Nov 2023 22:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698903032; x=1730439032; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vbp+HO/+7vTchnzn873ypyP3+zh6I8tjjn70pzl7rl4=; b=XOZ6dGV6x4jgKJZG9kr5g3R37XSxIlpg8ghIAP+qSeIAgBD8MX7DuWNI 4EYYTzsUIBFkOIXB1gTnp9DwTB0mVk6z0PwIi0mJ1ER08oCZK3FheClsp Q75nFqphoUTJmzq6/aCeTpYKsB+8z2HLUBcvP1e/P163j8URP2QFCaWUj 5RwVjJFbeYjGiSgjP8QaBwrqJz6mAO1DXwXq8aHoXlzd3GmRFGmBR2t6t ewEF6JxYAN44IISz744PA3a45KFF5vai8pc0AJJZuiPnZV5pn/0DWpxX4 Ga/6ZVAFWMY8iFhEK0vD2WMZ0uqvsc5bboxohwGzqlEQ3zZnBbkkXLFY7 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="388458950" X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="388458950" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 22:30:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="2420245" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Nov 2023 22:30:30 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 1 Nov 2023 22:30:29 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 1 Nov 2023 22:30:29 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 1 Nov 2023 22:30:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CNMLX8t5HvF5B1780gbkzyXNYVYVovzqw8cRWIdmtzjUcuNS2UGx3Lp1mBCgnxlm0KQ/md68I0c6ZvOb1P7u/r+FiRTAAj9VLDZgXzRdIGHopLL/2xTqP4oxPMfrgmNcbIAw3yYypz2c35p2XrNYjfpmvXjW7caWujfXJt2YiFJepSSjGcv9IItaouwPdYFzdAdnNQCt8otLifjC5hlcZC86bfgvOfw8Rh3W8LQBcaDWwuVUo39lWm9gmeIF8d9oyCzzrflzXuN+XTPCDOqyWAga6v5bIt5sASD31VpMlg+3xrWrnvVM06y8laFyh0T20k2KfOIpqWVdimE0R0KJcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6BUkUgTTJ5IXTWNw17hcoqHW4N1eJU4OTUwAfEyw9O0=; b=jiWLsOejgqfgvVF/CFr1QJqtjo3muoLH2yu38eElRYDzqw1hVaDkAXzgkhJMlOKN+DoR0QVskrUyXWuS9EbvaDzN0swNHpFGrawIkkDtmvzAJwGnJuvfI1rZNshLmmRWTThDTCA1MUwMpvPxwpdxj+FxNOWOaPXHNX/nbgod61O78Oel+KlWsABJXSctpDeUuRCc+E+nkre/55t2aIvznTuRK2h96aigwMfZLhOSJxWJFEroRPdxrfQGh6VywIzpRsHQQKifVvmZjkatmMX1JUiiBSAd7+YpsNaKE6dVu+Hgh2HN9ea72FV9Er5Pp3lHhjIl8iJ4lHma2wjm1+EVDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL0PR11MB3122.namprd11.prod.outlook.com (2603:10b6:208:75::32) by DM4PR11MB6358.namprd11.prod.outlook.com (2603:10b6:8:b7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Thu, 2 Nov 2023 05:30:27 +0000 Received: from BL0PR11MB3122.namprd11.prod.outlook.com ([fe80::7911:8ae6:fc73:1097]) by BL0PR11MB3122.namprd11.prod.outlook.com ([fe80::7911:8ae6:fc73:1097%6]) with mapi id 15.20.6954.021; Thu, 2 Nov 2023 05:30:27 +0000 From: "Pucha, HimasekharX Reddy" To: ivecera , "netdev@vger.kernel.org" CC: "intel-wired-lan@lists.osuosl.org" , "Brandeburg, Jesse" , "linux-kernel@vger.kernel.org" , Eric Dumazet , "Nguyen, Anthony L" , "Keller, Jacob E" , Jakub Kicinski , Paolo Abeni , "David S. Miller" Subject: RE: [Intel-wired-lan] [PATCH net-next 1/2] i40e: Do not call devlink_port_type_clear() Thread-Topic: [Intel-wired-lan] [PATCH net-next 1/2] i40e: Do not call devlink_port_type_clear() Thread-Index: AQHaBnjohJsFQcSJYECrCylOHbGyJrBmjV0A Date: Thu, 2 Nov 2023 05:30:26 +0000 Message-ID: References: <20231024125109.844045-1-ivecera@redhat.com> In-Reply-To: <20231024125109.844045-1-ivecera@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL0PR11MB3122:EE_|DM4PR11MB6358:EE_ x-ms-office365-filtering-correlation-id: b1d8ad79-4f9b-41a6-d19b-08dbdb64d1fa x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DAH4sXuYN4X0XT6WdpIGirk+5s00D6rVdM0XzHpJuDLbDQKARRaed2Z2OhvUvF/gxHxc/DfguE2JOg6MImzwi9mqlAD7lKNSWvPKOC19Q7lP2fK+Xy7Mj22oqRIqXqQb3jelc9SUkIxbBNdrVeE2DHVkuPNVK4tYT8e9LrA/6fjgSLi4KQ9OViDJR7BeSE/1xs9fmPQH5fULiTHBb2wW7B1IrL4CaOz03XYalczzai8FRnN1hEB2/4cid7dKVLozbnOB9I792QcAEU8tMQLt3QjNpfP5WKhIqNIX3OhpK1qGa0aj4VMx/bQqjVcoD0S8Hifbzd1bsaPqfMjyk3PmNV869VL6xaSYWpgHyTz8/rwaO+OKwMXxf0C18wZk+e3dANMZcYKFgrOv/I0zFIOsZHxcRJllxoxa96Gf8jgL6DtWcjCJPMM9bHkxaooSDHhGo4Zz3a3pKWLa+lMXHTBACrLIQvpDf7uSI/6c2aKbFaNzwpPCRLmyHijAnXz5rgnz5yKpKvbQVQ3XX2IIWnDr1mk+fwwVd5gTkRTgmq5bgnP0sFxyvozAngdhDcX0Ui00YDIWT4KauxeIcPVOhnbt+fl265C+eA3NycJHLwE+2tLbcBQtzPf4SV3c7lCx+YN6 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB3122.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(39860400002)(376002)(366004)(136003)(346002)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(38100700002)(76116006)(52536014)(122000001)(2906002)(110136005)(66446008)(66556008)(66946007)(66476007)(9686003)(54906003)(64756008)(53546011)(316002)(82960400001)(41300700001)(8676002)(4326008)(83380400001)(8936002)(26005)(86362001)(55016003)(33656002)(5660300002)(7696005)(71200400001)(478600001)(6506007)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yHuHWcWeNGYYKQGgvq7H2zZhcUHHajpWsJwOYbby+ddwk9Yo2TRHx5dv7qif?= =?us-ascii?Q?W4JgXKYtwSQX2oUo2IW1JFLKh1GE/ggw1puRiVm35g25dGAu6CK2vu0s5bza?= =?us-ascii?Q?nI+8sJzKLn4pOlzKI7s+f1Q3e0E+eJZHtoL82Nlj771j995FvByakWUWtFSE?= =?us-ascii?Q?APqwy18D7pIYuj2D6uilI7WLPK+qA8JD4ZH8L2ik//8D2twcFr4R8QtiN0XC?= =?us-ascii?Q?/7EjvHuQrD5aEAjFOKR1MTZ5f12RFQkclBgXk5qBcaoyxgpXVYAATU9ptL7w?= =?us-ascii?Q?n4+D9yEA0iFolw0PFF9sZoo5RnmRDUHTBhm+VlHqbR9NAnlgtL7tb65RJhlr?= =?us-ascii?Q?47vhpwPZPW59FS/ror68Dpn+Vm6RV6Fgfbw05OWcxRSBrsYDamSqklU2P/dm?= =?us-ascii?Q?7cE8M0DUOElvoE6ixJZ87pLnrUStY1KlFpecy4To62FcuP3ZkpYFDSJtNGNG?= =?us-ascii?Q?ib4ztHsDMZOvnk0bF6V6p3gBPnnjRUFfqqh1gEDRtB+xI+ZqizpPARFMoW4a?= =?us-ascii?Q?cwgMyt9mj9WWwG+jL1gFU/QCY/RSeEpxLgXBo8NfX8qRIzyGJD3ffy32p7Yu?= =?us-ascii?Q?4mUkl01gHOLgmpk5n4wXM35JAp0Ly7Cta1S9ErIDCuoe3Vp8zXQGxhKiMrCi?= =?us-ascii?Q?zd4wLfGp3gYGgnw67CcIX1rdFii47vE4MPu+M7KGGvMgR1xqA7TlWLWwQM6C?= =?us-ascii?Q?cxMPA0Af0sMwoeMEVrP6eiOWsF8hxRivNiQK6yXkzLCMPkxbLWhy4Cnv89SF?= =?us-ascii?Q?Y3dKFw46iDH1h+UXAqixwu7HpxtCW2Trjv50eqX/O7dSSQnB9yPEvA0XoM/v?= =?us-ascii?Q?r9+tpfGUUr2/zYzoOwkzmtiDxP39Foyao7wKQ+OAxM4UcsUMqhE9tcw1bys2?= =?us-ascii?Q?2//IndSW+28Hb5QlTpnmJDczTZFdz9ykEUR90pQGugeh/Bw5pT8ftgAPxuB5?= =?us-ascii?Q?nxHqXy3XoYX+0Av91Kvmy7zeKK9/FkeY3QpI6+kMb7FA3DwyWh+IHXNm8u2I?= =?us-ascii?Q?PYGpIOb6RLfQuk3x3uDA2mIQPcxiMnk+4meql2bIya6dkOaISd2Gsoh12GEb?= =?us-ascii?Q?F9XHB3pkhTXqG6zmmZIsi9daJ1IP5rpt85X7VmZWU1xnVdMrDcCjDv5zQTve?= =?us-ascii?Q?S/21lKC7c+0poCH1cbdaY7posBT3zke331E2iibeM1doZXENOPT1vuj0a4KB?= =?us-ascii?Q?Vi4bMLEEkRWR4zLuljHDji/U1RAOrgoMnLIfoFAUL3M4zFqkhDUxSte3siOT?= =?us-ascii?Q?jr0rzuydrbjGxKYAZwuSSotwuo+9jbCLrJLkRMWSMAxiWRGqYHtSwsLdQCDP?= =?us-ascii?Q?8uM9FoTBavZBJj9gjgp66qXmxzYNGa5T+O3J4MowK28XTd076tpjr7zwfMle?= =?us-ascii?Q?cFiVNsc+JZgk4l2fM2v6p9v0HEzvpKLg2zRdl760HFZBFozciDYtIBgOc2TC?= =?us-ascii?Q?C8SJGtPZKPLZlZtzsz1OED6uSHhqlgGk3b6GeEtB0jXXmtBnfvtUA52aQIkW?= =?us-ascii?Q?RxLwfzcptbKGYSe7Smgu9z2AMxyaHSyVMVhudy5V7TaD06eWnj+I8iisSaVo?= =?us-ascii?Q?EGSWOmCtH2Yh8resUqq+hG0xkdzXPh+aXXpZ+/A+1u+tOY9oBMEI5OPz/t2W?= =?us-ascii?Q?gw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3122.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1d8ad79-4f9b-41a6-d19b-08dbdb64d1fa X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2023 05:30:26.8826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WbcE3KnsGsoUgkMRiGLoLEU7borU3qC5hvCNbhZXijfbEfluJB4jDDlJrnvzfojzGTCVoG8GzbFmPgUjGBBAWhUWoLeZ7SN3G3ehgs2u9dqw42wvXeFGyQzM4rcY7xSk X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6358 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 01 Nov 2023 22:30:59 -0700 (PDT) > -----Original Message----- > From: Intel-wired-lan On Behalf Of I= van Vecera > Sent: Tuesday, October 24, 2023 6:21 PM > To: netdev@vger.kernel.org > Cc: intel-wired-lan@lists.osuosl.org; Brandeburg, Jesse ; linux-kernel@vger.kernel.org; Eric Dumazet ; Nguyen, Anthony L ; Keller, Jacob E ; Jakub Kicinski ; Paolo Abeni ; David S. Miller > Subject: [Intel-wired-lan] [PATCH net-next 1/2] i40e: Do not call devlink= _port_type_clear() > > Do not call devlink_port_type_clear() prior devlink port unregister > and let devlink core to take care about it. > > Reproducer: > [root@host ~]# rmmod i40e > [ 4539.964699] i40e 0000:02:00.0: devlink port type for port 0 cleared wi= thout a software interface reference, device type not supported by the kern= el? > [ 4540.319811] i40e 0000:02:00.1: devlink port type for port 1 cleared wi= thout a software interface reference, device type not supported by the kern= el? > > Fixes: 9e479d64dc58 ("i40e: Add initial devlink support") > Signed-off-by: Ivan Vecera > --- > drivers/net/ethernet/intel/i40e/i40e_devlink.c | 1 - > 1 file changed, 1 deletion(-) > Tested-by: Pucha Himasekhar Reddy (A Co= ntingent worker at Intel)