Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <0321430a-8666-4017-b791-127484c2b17e@amd.com>
Date:   Thu, 2 Nov 2023 11:09:16 +0530
User-Agent: Mozilla Thunderbird
Reply-To: nikunj@amd.com
Subject: Re: [PATCH v5 12/14] x86/kvmclock: Skip kvmclock when Secure TSC is
 available
Content-Language: en-US
To:     Tom Lendacky <thomas.lendacky@amd.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org
Cc:     bp@alien8.de, mingo@redhat.com, tglx@linutronix.de,
        dave.hansen@linux.intel.com, dionnaglaze@google.com,
        pgonda@google.com, seanjc@google.com, pbonzini@redhat.com
References: <20231030063652.68675-1-nikunj@amd.com>
 <20231030063652.68675-13-nikunj@amd.com>
 <cfc9f863-dc07-7c23-7621-d2dc115651bd@amd.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <cfc9f863-dc07-7c23-7621-d2dc115651bd@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnUyV0N6L2cxR1RldlhrWFFYMFExaGZWNFhpOENzOXozNGE3QkhZOFBoeUZ0?=
 =?utf-8?B?czQxMkloNkdYMm11dTYxZGwzRFFDTG9aL0pkb2JpTldNdEN0VTl1YnRtVnZ2?=
 =?utf-8?B?SkdVUDVmZHpsdWtSUFFhdXVQOHNraG9BanZCclg0TEc5YXJvOUtEekxIc0hm?=
 =?utf-8?B?TncrV0VISlRJTlRuemt0Q3RwZk1rdDFEM2c5Nzh1dWNzWm4yUGpJVW9yaFlM?=
 =?utf-8?B?dHJwZ3VUajhNc1orcmYvRWxOeUJmbXFhOVBWMGErUmVnR2pKaHBMYitHS282?=
 =?utf-8?B?TzFNVmpFd0ZsKzRXbUJjNEpDVHdjb0cwZzVvekdZcytJd0FwUUowTVhXUXli?=
 =?utf-8?B?dzUrWC9ZQ3lCdDRhZkJMbGwvbWVLbm1HMVYvcVFLVXl1djZNQ1ljL1oxSytF?=
 =?utf-8?B?ZHZpZnVRWjhMdFhnTmRYQ1NFNis2NmhqdVZ4T0ttVUx3RXlOeDFncDQyaEdL?=
 =?utf-8?B?NkxMYUxndXhreHB1d3JwVlNEb0VzYWpibEFlZ0JwSElXNlFRR1BONWk5VE9Y?=
 =?utf-8?B?UVFCRklZaGN4N1BkcUxPOVJVdkVpWWRyNjc3aEtlRHlZdDBJb2dHWEJUdDF1?=
 =?utf-8?B?U2ZTMnZ5eHFOODJWTllpZGVhb0sxa2dyY2tENm1sd2czYWljeGNkcnRBTlZk?=
 =?utf-8?B?YU05MG0veXkvR0NIOTVvcmd5aS9NdzIwaVpkMml2ajczbVorb2hPV0RING52?=
 =?utf-8?B?R3FXNHR2YzNpN01uS1NtSGFveUQvMVVxWEMxQ1RXNzVvRTBPWERkL0p5TmVs?=
 =?utf-8?B?SXhENVZIaDJaS3NSNjJNbFhsY05GQkZUSlBqZ1h5bk0zdWNCamo2YWVHRFZh?=
 =?utf-8?B?bDdNbjZFYUFPUklhLy9FWVYxTHRwTUpUUElDZ2tLZ0ZUMkZDK0NRR3FrUEw4?=
 =?utf-8?B?S2p3NVU3V3Npc2h6RWpxUGZMVXNSVjgrU1dYMSt5ajczNGlVemptYkliSWIy?=
 =?utf-8?B?UlllS09aMko0MFdEZWZXK0dlb2dwcGJtY0tnempMeWo0M3lRd0gvTk9kSnB4?=
 =?utf-8?B?Vkg2SG0xb3kzU043TFM5empzZ1dTeVRtUHlJN2VtamJScGdVUitvOFRTQ0pp?=
 =?utf-8?B?OFE2cjZOc2JrUG01U3kvZld3NWRCQ3owaSt4Mzhhb2tuM1J1MXhVdW5xa0Vy?=
 =?utf-8?B?bHlCSDlaeXByR2hrTnlKbUx5OVg3RjYwb2x0a0VlVHRQYnFxMDhaS1BCaWFZ?=
 =?utf-8?B?dUpyTnFqR09JaDljZjJtUnIrdjlrL002M1kvZStNODhLaUNKWDVqRHdZcmlo?=
 =?utf-8?B?cy90QytVNlYxSEJ1Wi9HRy9XK25IdlBMTjZGU2Z5cWpIbVNxcVRFdU50ZzlX?=
 =?utf-8?B?SHVHUlh6MXlVN1NoQ2RnTHppV3h0UzdmYmd2UlFLTmRQb0JDL0c2UmlVSkpU?=
 =?utf-8?B?VGhqa05YNE9EQ2pYeUlGanovOGE5T3Z3RE4zak9DTEhPZG54ZGw5TFdsRDFT?=
 =?utf-8?B?Z3Z1S0I0Y05VS0IzZFc5aHQ2MjBtMFh6a3lLS0VEMHZJUmFwZGZyVDYyeEph?=
 =?utf-8?B?bndkelM1aFRZRXI3Uk9jL0t6NW53Q0IyN2hJTlV6Y2ZDdkg2allocnRzK0Rh?=
 =?utf-8?B?aUx0MDk2UXZqVTNnWFRkTlZiNGdwU1JoaC82WmJXRTZhYnpxbGJMYWRpcmFz?=
 =?utf-8?B?TlRzSERaejRaQkcyd3pGYnBtWDcwaWd3aXZ1ZllkaGlYM1VsbERCaEtCMlor?=
 =?utf-8?B?V014RzFBVW44YkpwUWhWNWx4RGhKektVU1FiMGpZdTdvMWE3dWQ3WDNITktk?=
 =?utf-8?B?YjluLzk1YW1uSXBlZENhSGMzK0d2MVlOaktYdlc0Tzl5aitRWjBIU2svZUNH?=
 =?utf-8?B?MnE0bHZzWjZYWkNiK1h1aUlHOTRxYjBtMXFIbmJaSTBUbGx3Q2tJYU1vUnVM?=
 =?utf-8?B?SG9lb0xkS3VmaWoxZTdhUHZ6UHV0OTIrTDRUY2pOeU5UMUVkY0ZHQmlVajcw?=
 =?utf-8?B?TXdJdVplUEZVRS90UUJJR3dFSFN4UDY0NVBKbGJZb01PcUVCYXUycGdxRjNU?=
 =?utf-8?B?ZW16WWVlTjViaW5jekZiY2p5ZFZkQ0MxQ2o5endkMFcvSGV2b1FvUEVGQ3JS?=
 =?utf-8?B?YUErTjc3S3NDMFA3VzIxaCtlQXh3cEZ6UGpEYUF2b0RNM1c2bnYvKzhJSnlH?=
 =?utf-8?Q?9eYgSyn2X4u2htXAfhDkdcCzm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 016afbda-d7e0-43be-ff3a-08dbdb661475
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 05:39:28.3001
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oc0XUpf0vqeVGEGvnPbE7U+V8vAFtwBZ5DmixoN3tQcneQuCtZuz/2T8fkQWnzUTi5IAM9AujGScZrKpCKhW9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5972
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 01 Nov 2023 22:39:48 -0700 (PDT)

On 10/31/2023 2:30 AM, Tom Lendacky wrote:
> On 10/30/23 01:36, Nikunj A Dadhania wrote:
>> For AMD SNP guests having Secure TSC enabled, skip using the kvmclock.
>> The guest kernel will fallback and use Secure TSC based clocksource.
>>
>> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
>> ---
>>   arch/x86/kernel/kvmclock.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
>> index fb8f52149be9..779e7311fa6f 100644
>> --- a/arch/x86/kernel/kvmclock.c
>> +++ b/arch/x86/kernel/kvmclock.c
>> @@ -288,7 +288,7 @@ void __init kvmclock_init(void)
>>   {
>>       u8 flags;
>>   -    if (!kvm_para_available() || !kvmclock)
>> +    if (!kvm_para_available() || !kvmclock || cc_platform_has(CC_ATTR_GUEST_SECURE_TSC))
> 
> And is setting X86_FEATURE_TSC_RELIABLE, as Dave Hansen suggests, enough
> to prevent usage of kvmclock?

No that wasn't sufficient. kvmclock was always selected before SecureTSC even when X86_FEATURE_TSC_RELIABLE was selected.

> 
> There was a discussion here:
>  https://lore.kernel.org/lkml/20230808162320.27297-1-kirill.shutemov@linux.intel.com/
> 
> Thanks,
> Tom

Regards
Nikunj