Received: by 2002:a05:7412:b795:b0:e2:908c:2ebd with SMTP id iv21csp170490rdb; Wed, 1 Nov 2023 23:00:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGKtlZWGsQyf8p4U6ML110NUpX6G7Ntgc/2pZNVs4hRFA4yG70DvRV7KuuJo8yDKs3d9/UR X-Received: by 2002:a05:6a20:a103:b0:13a:6bca:7a84 with SMTP id q3-20020a056a20a10300b0013a6bca7a84mr19675238pzk.44.1698904852158; Wed, 01 Nov 2023 23:00:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698904852; cv=none; d=google.com; s=arc-20160816; b=kDwsrFc0+tsX5LkPJcE/VQe5GdXx2jnT6tjXi8zGtnI9weZ1Ig120UjuqKHxQXbtuQ ak6njbogby0Yr8y09Uf921V/mgPUCUETUyVWUbM5KcjedtTlzvZuqR07GZA8/q6eATjN eDgMe413PdcRAnUnSNmk5X3hJ0oF82k0IJ0GSu41xc0o92sJbCr4gICT+QEFvCbGljkp 2CoxkfzMsJ7OdAuuiciK9SX+53KT4CtVOQTSrSyWL7stvrGYqIC00G48jXAZ/Z9uaCyW tL50mOWaJP4r+lZqTTWf6n/bGKY5JjkaFe7pJ8xjoAwMiTqNJAHTlPrjvBBfpAL8KLXD pABg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=YuTSZ6jj3153GnvQdkjyKCcnE+KWyYN52FIi56kwHTA=; fh=q1elCwLfisEuTGmvoxXk1+Z5HGYLG63K0DcqQVros/E=; b=D2WJCoMVSw/9Ckz662F1XjgA8VvbUjpp0MRx42ocNAy5fDIdNpFaYw5/LC3dP1fWRc hsToaZt3fMN6PcwMg3e348PT3G7aCS9lctfjhD9gRFEIqjS6nzmfkj7lNvvjadoeMZth 5umbpkoTN5OCmoFnb44QAglcnRvXyFi0IfyE+HlkQb8MCdstZIJsh6Vl8YhxxhfoF1PN wzzZ8wblLA2f3RnHo6x4Q+uiIDzHnEMAO25VgdNNETAVrh55FJ2Nrtsgh3xNusQs9iOf 6S0Lq9Q0r4sS/mh2v98XKorniIai2+6Rm3AfnwLYvor5rTxdYBtcdaYtWBGUxZVg42oi 7ZWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Fs/XNKMM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id k185-20020a6384c2000000b0058978136247si1266948pgd.483.2023.11.01.23.00.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 23:00:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Fs/XNKMM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 2322D8069D83; Wed, 1 Nov 2023 23:00:33 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232461AbjKBGA2 (ORCPT + 99 others); Thu, 2 Nov 2023 02:00:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231673AbjKBGA1 (ORCPT ); Thu, 2 Nov 2023 02:00:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76D7B13A; Wed, 1 Nov 2023 23:00:25 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPS id 07157C433C7; Thu, 2 Nov 2023 06:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698904825; bh=jZrUndBvrEv3u0YCdJU/c6eAxBp8Q3jwTAt94lIXALU=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=Fs/XNKMMhI0XrZwGL3tvs7KG1yCxqK6r4iFL2tMX0O7f0EifJavA4IZUjtoTD6DZ5 vWEZuc4m+VMd2DEjRHlYJ0HNfO0Cs9QM0Vdmek5+1wvQRlPNEzt11++N4W/SNpsc7w VDZHKRs05Ui8yv7BIMZwGEEjL7X2eN49FqG/V12DujuzPlsXhL9g/wUnXvGvhxBhlT oB7rufhpdBNTlI5F4QbfMAk7W2zaCblz/QYK9aWvBJViP4ZVriASLOW5jYmtJQ2vg/ raT2dEBHH+pdIJjl+3TKx0wdfPOZIRTYCNZ2Y40niaCiuP2npS6MhiN8OQ/0El4wSz i56fNwrMba6rw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id E2268C4316B; Thu, 2 Nov 2023 06:00:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH bpf v3 0/2] bpf: Fix incorrect immediate spill From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169890482492.9002.15567040644206875649.git-patchwork-notify@kernel.org> Date: Thu, 02 Nov 2023 06:00:24 +0000 References: <20231101-fix-check-stack-write-v3-0-f05c2b1473d5@gmail.com> In-Reply-To: <20231101-fix-check-stack-write-v3-0-f05c2b1473d5@gmail.com> To: Hao Sun Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, mykolal@fb.com, shuah@kernel.org, eddyz87@gmail.com, shung-hsi.yu@suse.com, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, stable@vger.kernel.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 01 Nov 2023 23:00:33 -0700 (PDT) Hello: This series was applied to bpf/bpf.git (master) by Alexei Starovoitov : On Wed, 01 Nov 2023 13:33:50 +0100 you wrote: > Immediate is incorrectly cast to u32 before being spilled, losing sign > information. The range information is incorrect after load again. Fix > immediate spill by remove the cast. The second patch add a test case > for this. > > Signed-off-by: Hao Sun > > [...] Here is the summary with links: - [bpf,v3,1/2] bpf: Fix check_stack_write_fixed_off() to correctly spill imm https://git.kernel.org/bpf/bpf/c/811c363645b3 - [bpf,v3,2/2] selftests/bpf: Add test for immediate spilled to stack https://git.kernel.org/bpf/bpf/c/85eb035e6cfd You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html