Received: by 2002:a05:7412:b795:b0:e2:908c:2ebd with SMTP id iv21csp207439rdb; Thu, 2 Nov 2023 00:50:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEdlV/6i3DF5zTIymjaGljuNE7FXBuigEmbUFqwPQICSj5lSd3s/QUEYqJFFoR+IPUkFLfA X-Received: by 2002:a05:6358:6f09:b0:168:e2d5:ddcc with SMTP id r9-20020a0563586f0900b00168e2d5ddccmr22773937rwn.7.1698911441669; Thu, 02 Nov 2023 00:50:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698911441; cv=none; d=google.com; s=arc-20160816; b=xn6Ik8zVirV1VqS2cNHtNqh8a9BqfRdT1q8DaW3+bJgg7XTOkq06A3IKKNedZDiKSS tyBREsCzVU3C125TZu9qhacKQtScElol441GuVlsINyE88QwdSOl/dwEV4BKtLKMIdpm 7WvfHzOiHnaPpAgWl77l+e7la14UOzpz1DIqIGqb/mSvRUGxt19w+QuxfVoL/6YFmb5t HllLnMYEC0y7yF+Ki8Xt4eoa/U27LCwWr6W8V3NG2AgPUUnRyBV2Uyz98k9q+vMSMmKJ r+u0bb7+p26vaytpXxBLl03ZF0mJB59BNTD470hOalveuOgh77jZPIPVhnZmT1OgF7l/ za/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=cD6HIvwS1+eD7lmzk4U069SbWiB68SgbaID0yXccmhM=; fh=o9YoaEb/33NpADboDCpm3VHHhpZgU/GyEqxF+erI8xM=; b=dhmPnH5DTg6oigjuIRdfd6rR2cGtaBr4pnjMr+y32poSfJsLOxGHfB4yo8xAG2q2nK Uu/qHNnGKpfQi23DFRXni6Os91Yxa5Ah5QTjEAS9HGKBMLWaM0Mqhxfrosr1MMU2A1XK bjpjVvh6HfiK4XFcBD2lYewf1hHrtOIaZtseTwT2uoD2RCXauqmckj4sjsIdocgBTuKW 9FY9jXcMNUFUk7/K7MpE+B/xBv4SdSK0m79C3SkOlWdCyNeD0MGkNDe1mBIFmrMnKaOq 2A3+RJdmxLxU/sg6+tQfdx/TVz0e7+JPekLyrFufRHwB1syvhnOIsnkyc39UTJdtmH2c +V1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lexina.in header.s=dkim header.b=XXDo3QUD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=lexina.in Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id c5-20020a6566c5000000b005b910acbc8bsi374856pgw.21.2023.11.02.00.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 00:50:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@lexina.in header.s=dkim header.b=XXDo3QUD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=lexina.in Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 50BDB802A345; Thu, 2 Nov 2023 00:50:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234246AbjKBHte (ORCPT + 99 others); Thu, 2 Nov 2023 03:49:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjKBHtc (ORCPT ); Thu, 2 Nov 2023 03:49:32 -0400 Received: from mx.msync.work (mx.msync.work [62.182.159.68]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACBD6102; Thu, 2 Nov 2023 00:49:26 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 25750147B80; Thu, 2 Nov 2023 07:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lexina.in; s=dkim; t=1698911364; h=from:subject:date:message-id:to:mime-version: content-transfer-encoding:in-reply-to:references; bh=cD6HIvwS1+eD7lmzk4U069SbWiB68SgbaID0yXccmhM=; b=XXDo3QUDQez6r8fp1+UL4OuCuhJxp2tWksc8eDpgFkHOaUPxZJmoa2+uMCxI5iTvhJknNt t1x3grkVoj+J7HAnFgMqjusL1kqqsSE+jw5avzCrhUfSgMcLwbbUpNod1Yx0ysl1s3sI5G WbWE6IDGiJuNqYaJSgsAN/38CTqhT6dwlqmEHzLb7EZzT3FKdYzCsILoDyT42qMeGxLRPt DWDGpmYr3M79+0X97AwRpev0DNOthfXdFNMtzclvZG9X2BWqJnjV4mdUxiJwv4pfMiU99r 2crUzil/ADrHYLiCALecVnT5Kj5DsE0OnN/8toOwhpcVAoBCStukjn9c3wCYKg== From: Viacheslav Bocharov To: Neil Armstrong , Kevin Hilman , Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 1/4] firmware: meson-sm: change sprintf to scnprintf Date: Thu, 2 Nov 2023 10:49:13 +0300 Message-Id: <20231102074916.3280809-2-adeep@lexina.in> In-Reply-To: <20231102074916.3280809-1-adeep@lexina.in> References: <20231102074916.3280809-1-adeep@lexina.in> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 02 Nov 2023 00:50:05 -0700 (PDT) Update sprintf in serial_show frunction to scnprintf command to prevent sysfs buffer overflow (buffer always is PAGE_SIZE bytes). Signed-off-by: Viacheslav Bocharov --- drivers/firmware/meson/meson_sm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c index ed60f1103053..c1c694b485ee 100644 --- a/drivers/firmware/meson/meson_sm.c +++ b/drivers/firmware/meson/meson_sm.c @@ -265,7 +265,7 @@ static ssize_t serial_show(struct device *dev, struct device_attribute *attr, return ret; } - ret = sprintf(buf, "%12phN\n", &id_buf[SM_CHIP_ID_OFFSET]); + ret = scnprintf(buf, PAGE_SIZE, "%12phN\n", &id_buf[SM_CHIP_ID_OFFSET]); kfree(id_buf); -- 2.34.1