Received: by 2002:a05:7412:b795:b0:e2:908c:2ebd with SMTP id iv21csp208245rdb; Thu, 2 Nov 2023 00:53:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJcERYKWqUzL8gy8WX5Peni7K3G3cvHhvtN7EiY1yqY6+44kdLoQaM2GCiRGDISmrJVwxE X-Received: by 2002:a17:902:c146:b0:1c3:845d:a4 with SMTP id 6-20020a170902c14600b001c3845d00a4mr14912068plj.51.1698911587098; Thu, 02 Nov 2023 00:53:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698911587; cv=none; d=google.com; s=arc-20160816; b=l/vOJVPqTfIxezgBWWQ6jYYHdY/0ueXSCJxUxukMYt1c+FPeqjcyRgpQ2HqT6eZTmO mU2x/dzekImn3OZEk7E4q36KkWBIuAUuFyJaruxwekfP+jQQn/uNtye/PdBZaEAX1he5 +N1Aua7kgB6+iqMP2vDJjHZhlLXe54XKrsgsC6QaI3L/EOUl2Le0f0c0Yy7OjaFdqCB4 nQS0QzxsEeaJsBgLgb5CHMTslgjrlSW55xh8jlBVri/ukcVNzaEXnO/sQi2IeP6DgP/B J0czl9Go8SCsrtY2ZiMb2IQOW8ENz5HS/56IdIkaIYBe2v3uOaz9asOEr0uhRKWiV+i4 vi9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=AlnUT6WbHpXSzVlyi7x3j2h1bCcOSsfQ0+/D2gKrkP8=; fh=LE1cvsxnKQeN3SKEi5SOvkFJAEU5077TmlZX0AExyf0=; b=bCMo1m7IGMQnTnDSVJIaKPubfnw/V3bDQezXZVWqp4/PxvqZm3Ftish21wd6rwzBBe qaXycoah224Jutpbrs+M1DOaFJyEGRGow2Fizuy5UzgUc7iss5oZ5gZRoPUNKdD32MWg xDcH0+8cS42WzWYq62XWvXleoQKsXMtL+9mTzis1b11UtF8EvXmTgrYSG7fCH9C0Dnv8 6JQNeGc/30aor5hc0t+J97kkv+/WKO/eJWq91t0TlJOsOaV2Hny1WOW+ygY6HJz1EZCU Bga6dgNaZbU+/dz88w+F7hKwUY+Vigj3Ji74Mij53KMnEs18YyQAYywVKE3Fgti25mx5 TnDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id ld12-20020a170902facc00b001bdd35033efsi4397283plb.374.2023.11.02.00.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 00:53:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DF68581DD7C8; Thu, 2 Nov 2023 00:53:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344848AbjKBHxC (ORCPT + 99 others); Thu, 2 Nov 2023 03:53:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344681AbjKBHxB (ORCPT ); Thu, 2 Nov 2023 03:53:01 -0400 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A28412B for ; Thu, 2 Nov 2023 00:52:56 -0700 (PDT) Received: from localhost (unknown [124.16.138.129]) by APP-05 (Coremail) with SMTP id zQCowAAnR6hFVUNlvixZAA--.19531S2; Thu, 02 Nov 2023 15:52:37 +0800 (CST) From: Chen Ni To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, quic_schowdhu@quicinc.com, gregkh@linuxfoundation.org Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Chen Ni Subject: [PATCH] usb: misc: eud: Add IRQ check for platform_get_irq() Date: Thu, 2 Nov 2023 07:51:13 +0000 Message-Id: <20231102075113.1043358-1-nichen@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: zQCowAAnR6hFVUNlvixZAA--.19531S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Jw1rJr1fCFW5CFWUWrWktFb_yoW3KFb_Kr yDuFs7GrWF9rWYyr1agay3ZrW2kF1DWr18ZFnFqa43tFyDC34vqrWavF95AFW7urZ8GFyD W3s8WrW29FsavjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb2AFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUtVWrXwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY02Avz4vE14v_GF4l 42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJV WUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAK I48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r 4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY 6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JUT6wZUUUUU= X-Originating-IP: [124.16.138.129] X-CM-SenderInfo: xqlfxv3q6l2u1dvotugofq/ X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 02 Nov 2023 00:53:06 -0700 (PDT) The function eud_probe() should check the return value of platform_get_irq() for errors so as to not pass a negative value to the devm_request_threaded_irq(). Signed-off-by: Chen Ni --- drivers/usb/misc/qcom_eud.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c index 7f371ea1248c..26e9b8749d8a 100644 --- a/drivers/usb/misc/qcom_eud.c +++ b/drivers/usb/misc/qcom_eud.c @@ -205,6 +205,9 @@ static int eud_probe(struct platform_device *pdev) return PTR_ERR(chip->mode_mgr); chip->irq = platform_get_irq(pdev, 0); + if (chip->irq < 0) + return chip->irq; + ret = devm_request_threaded_irq(&pdev->dev, chip->irq, handle_eud_irq, handle_eud_irq_thread, IRQF_ONESHOT, NULL, chip); if (ret) -- 2.25.1