Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <91bc69e6-8c6a-4e36-9b09-b000444f6465@ti.com>
Date:   Thu, 2 Nov 2023 14:33:28 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] serial: 8250_omap: Add earlycon support for the AM654
 UART controller
Content-Language: en-US
To:     Ronald Wahl <rwahl@gmx.de>, <linux-kernel@vger.kernel.org>,
        <linux-serial@vger.kernel.org>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Peter Hurley <peter@hurleysoftware.com>,
        Nishanth Menon <nm@ti.com>,
        Ronald Wahl <ronald.wahl@raritan.com>
References: <20231031131242.15516-1-rwahl@gmx.de>
From:   Vignesh Raghavendra <vigneshr@ti.com>
In-Reply-To: <20231031131242.15516-1-rwahl@gmx.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 31/10/23 18:42, Ronald Wahl wrote:
> From: Ronald Wahl <ronald.wahl@raritan.com>
> 
> Currently there is no support for earlycon on the AM654 UART
> controller. This commit adds it.

Something like below should also work for just an early console
functionality

earlycon=ns16550a,mmio32,0x02800000

But, I think its better to have setup mapped directly to compatible. so

Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>


> 
> Signed-off-by: Ronald Wahl <ronald.wahl@raritan.com>
> ---
>  drivers/tty/serial/8250/8250_early.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c
> index 9837a27739fd..e3f482fd3de4 100644
> --- a/drivers/tty/serial/8250/8250_early.c
> +++ b/drivers/tty/serial/8250/8250_early.c
> @@ -189,5 +189,6 @@ static int __init early_omap8250_setup(struct earlycon_device *device,
>  OF_EARLYCON_DECLARE(omap8250, "ti,omap2-uart", early_omap8250_setup);
>  OF_EARLYCON_DECLARE(omap8250, "ti,omap3-uart", early_omap8250_setup);
>  OF_EARLYCON_DECLARE(omap8250, "ti,omap4-uart", early_omap8250_setup);
> +OF_EARLYCON_DECLARE(omap8250, "ti,am654-uart", early_omap8250_setup);
> 
>  #endif
> --
> 2.41.0
> 

-- 
Regards
Vignesh