Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Thu, 2 Nov 2023 17:06:44 +0800
From:   Philip Li <philip.li@intel.com>
To:     kernel test robot <lkp@intel.com>
CC:     Yonghong Song <yonghong.song@linux.dev>,
        <oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>
Subject: Re: kernel/bpf/helpers.c:1905:19: warning: no previous declaration
 for 'bpf_percpu_obj_new_impl'
Message-ID: <ZUNmpE2OTpuKcxjW@rli9-mobl>
References: <202311021613.I5dZri9c-lkp@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <202311021613.I5dZri9c-lkp@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dMXGHlPWxSq/9p4qX+y9IHAATO5wK3lgMzvcH2W12ulSCLAjmG03iMFACLb/?=
 =?us-ascii?Q?4HQvo/bv6i6eWWMdgBb/Wz6oH/Nd39z3liBUDLFu/biTOFtEZ0eDRSYB6fh9?=
 =?us-ascii?Q?7J0jMSVxTyDu/lSgBQa1Q55naYcq1zwnqjIglvrEZCdruFbwRWqRdnamCXsY?=
 =?us-ascii?Q?bDVF1S6V9gpdNd944+cOHuXMF5S+y32E5xYcQSZJfuMvCQomISXeMfdollcY?=
 =?us-ascii?Q?VaveOMv939jJMpZWMhVsIg0r88BiV3BMKgR0/Mb1ANzlL2Kl8ANWatJuKt2n?=
 =?us-ascii?Q?DHdwfN0fU//XtWL+pq0hiWmaVT64eKwsAN7rupqvQ9cSapPs1kerh45YZEqg?=
 =?us-ascii?Q?9U5RL6KRKIck0DDX8bIiKYBaQRKXigSWli7MxO16jZMX5nGxvSXbCPguH+Ht?=
 =?us-ascii?Q?tFe+KK5M1q9OR0hFDvpMqjjysl0CksI6DJ2IECe2pXQuQZQoGMJOToaaM2Ww?=
 =?us-ascii?Q?ifR9jiL3eYNT6pktmPsBk5z900rqpNcbLyU5nSPTFSZ44MgZwD+yFT3EGv5w?=
 =?us-ascii?Q?DCcZFh5BRtIE3y9Ccp8RqCLPM2O+8uNWxnBb9SDCzwFnOissg4wYNZgS8TKR?=
 =?us-ascii?Q?B9a+73mdMEvsIVYajFhG+9vaU+31P528TCT7KkAWF3hnQbNAugBUgaxzPorZ?=
 =?us-ascii?Q?nFVZaA1LGxbqr+jxx0F4vxavndiNHquWZzCB6mmoGAFfk0CXZhIZuzbtYNu1?=
 =?us-ascii?Q?uN4eRnRxDEwegYpKoJsRkY9MUQqeKtkJfjcQdr+w+ky1WpVIU8iVEawPzXBC?=
 =?us-ascii?Q?Jh13ExQnuHS5ltmCJQp2K5d09R8NJueSnznpC5VK1569nF0Wia4K27moNAD+?=
 =?us-ascii?Q?/CsXyGFtQSf162XcCwm7tMDyusGoPDlMYgpPljV6tHYSC2pNbzLmXsv9BsmM?=
 =?us-ascii?Q?QJb+tInh0/Hp0Ec4N6PiBXyphfuDlzIniUGUxQ77k3mB+Iyp4LfjN7GcByGQ?=
 =?us-ascii?Q?bbGXpPQvjmmh/cF3x3qiZDMQ4a/tZTt0VLTj0VkDst0xyRYs/Fdik+NknexN?=
 =?us-ascii?Q?c0cURM0OfPTJl5hXBc631P70Tpe+5OCORXxGU+Y0BrLHbo3mEmIHLFfUHc8c?=
 =?us-ascii?Q?UzULN+m2GmGjEFVqh5iCOViaPhQqLMzAr+m5vGaDu7I/rw0pOD6AtxONpKwJ?=
 =?us-ascii?Q?Q9HqmacOubGbciVc8hoIn1l/eI5HxKobgD3FE1nd0h4TmnoFWpj0Fmt/AUQi?=
 =?us-ascii?Q?lRmNsOXwskVpWINAlk3vCHdzE2W8224sfCsRqdNzXNrgm50mXi+ijLg5s5TU?=
 =?us-ascii?Q?RGfEVBKoTN9MIp3o1+/pLYPVDSCXGCNQjqT/aNHCBu2abKbNpIowUk9K2XNq?=
 =?us-ascii?Q?PoKUS5CgJgX+Za+0Ws8fsIz52dmdXYvCuLN1AFNOTspz0eFucArfCJq91Afq?=
 =?us-ascii?Q?LJFD/pe8sDVIZXjufghPHRgwzZuaSf9EDd+0Vhqx0bFr7Xkt9LHgqbUTZt8b?=
 =?us-ascii?Q?HEagwKdc98pSf3kPJHFNhNog336ugoGTcrQrC1JqAP32rEZxg6WxZIZexyGS?=
 =?us-ascii?Q?ywXSGo79/Tp1D+U0KcYAfYGEJFkqRqZ0F3jStG7hycb9Uc+a0lYGMciqawWU?=
 =?us-ascii?Q?R1aEAbxLGJqGnabNQCtTwHNfXjEgl+q/2uUv2LaD?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 77703494-566c-4263-fab0-08dbdb830df9
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB2995.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 09:06:53.1700
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SLoP16Ud9GPGfOH653JBnTHKkl3N0gTPgU22h+WMh4lBbZ03YzdNdUiLwV02TNGzug21ri51SVD6Q0oosjT4Rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6897
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 02 Nov 2023 02:07:17 -0700 (PDT)

On Thu, Nov 02, 2023 at 04:42:39PM +0800, kernel test robot wrote:
> Hi Yonghong,

Sorry, kindly ignore this report, it is similar one as https://lore.kernel.org/oe-kbuild-all/202309241550.JnHcYTZh-lkp@intel.com/,
and we haven't fixed the bot side yet.

> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   21e80f3841c01aeaf32d7aee7bbc87b3db1aa0c6
> commit: 36d8bdf75a93190e5669b9d1d95994e13e15ba1d bpf: Add alloc/xchg/direct_access support for local percpu kptr
> date:   8 weeks ago
> config: x86_64-buildonly-randconfig-006-20231102 (https://download.01.org/0day-ci/archive/20231102/202311021613.I5dZri9c-lkp@intel.com/config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231102/202311021613.I5dZri9c-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311021613.I5dZri9c-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    kernel/bpf/helpers.c:1891:19: warning: no previous declaration for 'bpf_obj_new_impl' [-Wmissing-declarations]
>     __bpf_kfunc void *bpf_obj_new_impl(u64 local_type_id__k, void *meta__ign)
>                       ^~~~~~~~~~~~~~~~
> >> kernel/bpf/helpers.c:1905:19: warning: no previous declaration for 'bpf_percpu_obj_new_impl' [-Wmissing-declarations]
>     __bpf_kfunc void *bpf_percpu_obj_new_impl(u64 local_type_id__k, void *meta__ign)
>                       ^~~~~~~~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:1933:18: warning: no previous declaration for 'bpf_obj_drop_impl' [-Wmissing-declarations]
>     __bpf_kfunc void bpf_obj_drop_impl(void *p__alloc, void *meta__ign)
>                      ^~~~~~~~~~~~~~~~~
> >> kernel/bpf/helpers.c:1941:18: warning: no previous declaration for 'bpf_percpu_obj_drop_impl' [-Wmissing-declarations]
>     __bpf_kfunc void bpf_percpu_obj_drop_impl(void *p__alloc, void *meta__ign)
>                      ^~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:1947:19: warning: no previous declaration for 'bpf_refcount_acquire_impl' [-Wmissing-declarations]
>     __bpf_kfunc void *bpf_refcount_acquire_impl(void *p__refcounted_kptr, void *meta__ign)
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:1992:17: warning: no previous declaration for 'bpf_list_push_front_impl' [-Wmissing-declarations]
>     __bpf_kfunc int bpf_list_push_front_impl(struct bpf_list_head *head,
>                     ^~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2002:17: warning: no previous declaration for 'bpf_list_push_back_impl' [-Wmissing-declarations]
>     __bpf_kfunc int bpf_list_push_back_impl(struct bpf_list_head *head,
>                     ^~~~~~~~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2035:35: warning: no previous declaration for 'bpf_list_pop_front' [-Wmissing-declarations]
>     __bpf_kfunc struct bpf_list_node *bpf_list_pop_front(struct bpf_list_head *head)
>                                       ^~~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2040:35: warning: no previous declaration for 'bpf_list_pop_back' [-Wmissing-declarations]
>     __bpf_kfunc struct bpf_list_node *bpf_list_pop_back(struct bpf_list_head *head)
>                                       ^~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2045:33: warning: no previous declaration for 'bpf_rbtree_remove' [-Wmissing-declarations]
>     __bpf_kfunc struct bpf_rb_node *bpf_rbtree_remove(struct bpf_rb_root *root,
>                                     ^~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2101:17: warning: no previous declaration for 'bpf_rbtree_add_impl' [-Wmissing-declarations]
>     __bpf_kfunc int bpf_rbtree_add_impl(struct bpf_rb_root *root, struct bpf_rb_node *node,
>                     ^~~~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2111:33: warning: no previous declaration for 'bpf_rbtree_first' [-Wmissing-declarations]
>     __bpf_kfunc struct bpf_rb_node *bpf_rbtree_first(struct bpf_rb_root *root)
>                                     ^~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2124:33: warning: no previous declaration for 'bpf_task_acquire' [-Wmissing-declarations]
>     __bpf_kfunc struct task_struct *bpf_task_acquire(struct task_struct *p)
>                                     ^~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2135:18: warning: no previous declaration for 'bpf_task_release' [-Wmissing-declarations]
>     __bpf_kfunc void bpf_task_release(struct task_struct *p)
>                      ^~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2224:33: warning: no previous declaration for 'bpf_task_from_pid' [-Wmissing-declarations]
>     __bpf_kfunc struct task_struct *bpf_task_from_pid(s32 pid)
>                                     ^~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2265:19: warning: no previous declaration for 'bpf_dynptr_slice' [-Wmissing-declarations]
>     __bpf_kfunc void *bpf_dynptr_slice(const struct bpf_dynptr_kern *ptr, u32 offset,
>                       ^~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2349:19: warning: no previous declaration for 'bpf_dynptr_slice_rdwr' [-Wmissing-declarations]
>     __bpf_kfunc void *bpf_dynptr_slice_rdwr(const struct bpf_dynptr_kern *ptr, u32 offset,
>                       ^~~~~~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2380:17: warning: no previous declaration for 'bpf_dynptr_adjust' [-Wmissing-declarations]
>     __bpf_kfunc int bpf_dynptr_adjust(struct bpf_dynptr_kern *ptr, u32 start, u32 end)
>                     ^~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2398:18: warning: no previous declaration for 'bpf_dynptr_is_null' [-Wmissing-declarations]
>     __bpf_kfunc bool bpf_dynptr_is_null(struct bpf_dynptr_kern *ptr)
>                      ^~~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2403:18: warning: no previous declaration for 'bpf_dynptr_is_rdonly' [-Wmissing-declarations]
>     __bpf_kfunc bool bpf_dynptr_is_rdonly(struct bpf_dynptr_kern *ptr)
>                      ^~~~~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2411:19: warning: no previous declaration for 'bpf_dynptr_size' [-Wmissing-declarations]
>     __bpf_kfunc __u32 bpf_dynptr_size(const struct bpf_dynptr_kern *ptr)
>                       ^~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2419:17: warning: no previous declaration for 'bpf_dynptr_clone' [-Wmissing-declarations]
>     __bpf_kfunc int bpf_dynptr_clone(struct bpf_dynptr_kern *ptr,
>                     ^~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2432:19: warning: no previous declaration for 'bpf_cast_to_kern_ctx' [-Wmissing-declarations]
>     __bpf_kfunc void *bpf_cast_to_kern_ctx(void *obj)
>                       ^~~~~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2437:19: warning: no previous declaration for 'bpf_rdonly_cast' [-Wmissing-declarations]
>     __bpf_kfunc void *bpf_rdonly_cast(void *obj__ign, u32 btf_id__k)
>                       ^~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2442:18: warning: no previous declaration for 'bpf_rcu_read_lock' [-Wmissing-declarations]
>     __bpf_kfunc void bpf_rcu_read_lock(void)
>                      ^~~~~~~~~~~~~~~~~
>    kernel/bpf/helpers.c:2447:18: warning: no previous declaration for 'bpf_rcu_read_unlock' [-Wmissing-declarations]
>     __bpf_kfunc void bpf_rcu_read_unlock(void)
>                      ^~~~~~~~~~~~~~~~~~~
> 
> 
> vim +/bpf_percpu_obj_new_impl +1905 kernel/bpf/helpers.c
> 
>   1904	
> > 1905	__bpf_kfunc void *bpf_percpu_obj_new_impl(u64 local_type_id__k, void *meta__ign)
>   1906	{
>   1907		u64 size = local_type_id__k;
>   1908	
>   1909		/* The verifier has ensured that meta__ign must be NULL */
>   1910		return bpf_mem_alloc(&bpf_global_percpu_ma, size);
>   1911	}
>   1912	
>   1913	/* Must be called under migrate_disable(), as required by bpf_mem_free */
>   1914	void __bpf_obj_drop_impl(void *p, const struct btf_record *rec)
>   1915	{
>   1916		if (rec && rec->refcount_off >= 0 &&
>   1917		    !refcount_dec_and_test((refcount_t *)(p + rec->refcount_off))) {
>   1918			/* Object is refcounted and refcount_dec didn't result in 0
>   1919			 * refcount. Return without freeing the object
>   1920			 */
>   1921			return;
>   1922		}
>   1923	
>   1924		if (rec)
>   1925			bpf_obj_free_fields(rec, p);
>   1926	
>   1927		if (rec && rec->refcount_off >= 0)
>   1928			bpf_mem_free_rcu(&bpf_global_ma, p);
>   1929		else
>   1930			bpf_mem_free(&bpf_global_ma, p);
>   1931	}
>   1932	
>   1933	__bpf_kfunc void bpf_obj_drop_impl(void *p__alloc, void *meta__ign)
>   1934	{
>   1935		struct btf_struct_meta *meta = meta__ign;
>   1936		void *p = p__alloc;
>   1937	
>   1938		__bpf_obj_drop_impl(p, meta ? meta->record : NULL);
>   1939	}
>   1940	
> > 1941	__bpf_kfunc void bpf_percpu_obj_drop_impl(void *p__alloc, void *meta__ign)
>   1942	{
>   1943		/* The verifier has ensured that meta__ign must be NULL */
>   1944		bpf_mem_free_rcu(&bpf_global_percpu_ma, p__alloc);
>   1945	}
>   1946	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>