Received: by 2002:a05:7412:b795:b0:e2:908c:2ebd with SMTP id iv21csp247067rdb; Thu, 2 Nov 2023 02:26:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGO6k4zfq9qmoEmp92eXzBbDmRwGBKGTRoXizAVD4ep5x0oWb6Sfi+hgxDPsPSBVZ0ZRP2j X-Received: by 2002:a05:6a00:13a2:b0:6be:c6f7:f9fd with SMTP id t34-20020a056a0013a200b006bec6f7f9fdmr9230146pfg.11.1698917217417; Thu, 02 Nov 2023 02:26:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698917217; cv=none; d=google.com; s=arc-20160816; b=LSt2ojDrfz7Q0BrvKviWcf6LoPU70AuLpMKDfNXGzsbSTSoe73sbourdyI5zBV/Ma+ 0OFf41JQgovOMkS7OFCk4p3GrhAoXx7R7v2B7JVtVLob3FuhZZbDG5YSSf+6Q0OT3upe dKGDtjl4tn2qupNZ5MonveT3sitkjQiNbUMGSzZ2J5kIzXXZh9jmwaHXKDeEjFw7TWCM D6aZPQW03Ff7WO3wQtoN3ISYV/eLUs5WE0xvbMANfnnn/etMwhAlLREnS2UyJBhSpR4g KeSSDjUEx7lLWJpMoGj2x7tas+/jkqI32dWQMsyt+lTgUpYt6azN/eylFCbSj3OnDL84 OrXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ataWuMCNQtSNjb1644V2WY/4XAYPsVlzI3aY0q4XTyc=; fh=JDk9QMfoBuCaTkWrvjwyHvlMvljXCbGC+pTJDNVB19E=; b=0vbuix8SFKsQ3Y/hqrPtIW61oVIyEIVxXRog2d8Ifb/aDWU5xpIEHPyqJ0IzJmwVpI 4ZIimBVZoOueBEKmdJa+sLN2DYnoXP0GWg19cif2azoKJvL+whteFUCoCXPXGGS/Thcj 5gtvZmHUDgzYzlTLnAk2YI7a/3v5N+epMhDw3braHRkmMpGFrBtsWzEuavuzZuIM2o95 vSb+YCQiEmACoTMlfDCxfeoSAh6jfMpvNxMwd+1D0UgOSmKWWO/k1XO0hpSXf9JHx8X8 DyiMryfk/YOWviE9XpWv/tzfg29FVYpI9smhCMDtq3uC6Um+ScCes5nqBRXp41rux2q+ FsnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fBIqUsmA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id g124-20020a636b82000000b005acf1d3b2a2si1627387pgc.174.2023.11.02.02.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 02:26:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fBIqUsmA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 4BF0F820E524; Thu, 2 Nov 2023 02:26:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345474AbjKBJ0y (ORCPT + 99 others); Thu, 2 Nov 2023 05:26:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234875AbjKBJ0w (ORCPT ); Thu, 2 Nov 2023 05:26:52 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28D3B132 for ; Thu, 2 Nov 2023 02:26:44 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9d8d3b65a67so98045766b.2 for ; Thu, 02 Nov 2023 02:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698917202; x=1699522002; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ataWuMCNQtSNjb1644V2WY/4XAYPsVlzI3aY0q4XTyc=; b=fBIqUsmAXA/SujvXJ4MJFaCIWcTSrCvNc/xOrEV+YZyRwQyqTm21p3Ihje0cTwEqhz sKBTbafUamSuFXYBQc+rw05U2rh9wDDZ7ZNtoC5IzqhCc6VxF2iWCTBzQWSkAbEB7G/M QFl2RuKzEUqVhdddCgEI2zb+JkfNMQtDX9aB8dOGxjf3YPhcPXkLdr/corV4/orKhPvG jqn8I7wPmaMD/bb+W0zyI/5uytQ8w1NyTe3iInHYqCGGPGsk68oqoHI3zkyxYbj4GGuS h19RubRQnZQNSwsXH5zeDKrwEHGfX6ZUCOTm26SWEeM15ofTBdMbE/pLQsuGcudXCAs/ T7Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698917202; x=1699522002; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ataWuMCNQtSNjb1644V2WY/4XAYPsVlzI3aY0q4XTyc=; b=scM1C5gow+1wonZ5wPXg8r/8hzRELZppVKy5VMxeI3BjqGCXrFZiIH3w7kya71+hFk 0MNSaaYQ8AovO8uDyLoLbbK8z5re3RHR672OrL9G2E6zX9Tsxjc+guQYec0FFuKBuh0J 7bkX4YZ+28XcNgIywaU2h0m3kRFr3oemQLGjpw9Qmy3B/WmCedEd4miW/gjaw5RNaiks eaJGShNIqysPyKYOFSCi/Pd6VHaZzojz4snnwc/gE5ZeQ8y1aoX03BZScVkQ7mNTw6JE YQs0PTp29TYu92rfp9Ad2EZ29ArE51Et2eIMNWYsadnq/62FyZEd6vzWlprhyfdrMXYZ YpyA== X-Gm-Message-State: AOJu0Yzk/3decCDv+9D2c2vmanNwwFsodSlVrBM3zMwUhHnqd7SfgTkd oMQJ0TEkgGdlW2xx4IE6QEul8O46rWx0fOlyDbQ= X-Received: by 2002:a17:907:3da2:b0:9be:e153:3f24 with SMTP id he34-20020a1709073da200b009bee1533f24mr3846557ejc.63.1698917202487; Thu, 02 Nov 2023 02:26:42 -0700 (PDT) Received: from [192.168.1.20] ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id f24-20020a170906561800b009920a690cd9sm891854ejq.59.2023.11.02.02.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Nov 2023 02:26:42 -0700 (PDT) Message-ID: Date: Thu, 2 Nov 2023 10:26:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] firmware: meson_sm: use meson_gx_socinfo for compatibility Content-Language: en-US To: Viacheslav Bocharov , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20231102074916.3280809-1-adeep@lexina.in> <20231102074916.3280809-5-adeep@lexina.in> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231102074916.3280809-5-adeep@lexina.in> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 02 Nov 2023 02:26:56 -0700 (PDT) On 02/11/2023 08:49, Viacheslav Bocharov wrote: > Use meson_gx_socinfo variable for chipid compatible call > from meson-gx-socinfo driver if available. > So we are back to something like ARMv7 platform/mach-code with drivers tightly coupled between subsystems. But it is not 2007 anymore and we have Devicetree for this. Use it instead. What's more, your commit msg does not explain at all why do you need to do it. This is some "show" callback, which does not exist in current code. Adding code in one patch and then changing it, looks like you add incomplete or buggy feature. Best regards, Krzysztof