Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Javier Martinez Canillas <javierm@redhat.com>
To:     Mark Brown <broonie@kernel.org>,
        Manivannan Sadhasivam <mani@kernel.org>
Cc:     linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        Liam Girdwood <lgirdwood@gmail.com>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        "Steven Rostedt (Google)" <rostedt@goodmis.org>,
        Tejun Heo <tj@kernel.org>, linux-doc@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Add option to prevent disabling unused
 regulators
In-Reply-To: <c1690b26-9004-4e5e-aa14-c61f679add12@sirena.org.uk>
References: <20231028102423.179400-1-javierm@redhat.com>
 <20231101045652.GA2897@thinkpad>
 <c1690b26-9004-4e5e-aa14-c61f679add12@sirena.org.uk>
Date:   Thu, 02 Nov 2023 10:33:38 +0100
Message-ID: <875y2kh53h.fsf@minerva.mail-host-address-is-not-set>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Mark Brown <broonie@kernel.org> writes:

> On Wed, Nov 01, 2023 at 10:26:52AM +0530, Manivannan Sadhasivam wrote:
>
>> On the other note, I'm wondering if we could use sync_state() for handling the
>> regulator_init_complete() work. This would ensure that the regulators are only
>> disabled when all the consumers are probed.
>
> That assumes that everything defined in the DT both has a driver and has
> the driver available for the currently running kernel neither of which
> is a good assumption.

Agreed. I believe the current logic of disabling all regulators using a
workqueue is the correct thing to do.

The only better option I think is to make user-space notify the kernel
that it won't load kernel modules anymore. But the delayed work would
sill be needed, since the kernel can't make an assumption on whether
user-space will notify of this or not.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat