Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20231101081726.1163042-1-xinglong.yang@cixtech.com>
In-Reply-To: <20231101081726.1163042-1-xinglong.yang@cixtech.com>
From:   sean yang <seanyang230@gmail.com>
Date:   Thu, 2 Nov 2023 17:55:37 +0800
Message-ID: <CADGqjF+qsrKcNntO7FdcUxJ+L4rC8jcMT94nv8uOOTH-VwG9mw@mail.gmail.com>
Subject: Fwd: [PATCH] firmware: arm_scmi: Remove inappropriate error log.
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
To:     unlisted-recipients:; (no To-header on input)
Precedence: bulk

---------- Forwarded message ---------
=E5=8F=91=E4=BB=B6=E4=BA=BA=EF=BC=9A xinglong.yang <seanyang230@gmail.com>
Date: 2023=E5=B9=B411=E6=9C=881=E6=97=A5=E5=91=A8=E4=B8=89 16:17
Subject: [PATCH] firmware: arm_scmi: Remove inappropriate error log.
To: <xinglong.yang@cixtech.com>, <sudeep.holla@arm.com>,
<cristian.marussi@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>


The platform may not support fastchannel, but this is a legal
operation.

        -Before this patch, when the platform not support fastchannel,
        goto err_xfer will print "Failed to ...". This log is misleading.

        -With this patch, when the fastchannel is not been supported,
        the "Failed to ..." log will be skipped.

Signed-off-by: xinglong.yang <xinglong.yang@cixtech.com>
---
 drivers/firmware/arm_scmi/driver.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/driver.c
b/drivers/firmware/arm_scmi/driver.c
index b5957cc12fee..2b990e50c8a5 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -1642,7 +1642,10 @@ scmi_common_fastchannel_init(const struct
scmi_protocol_handle *ph,
         * fastchannels at all.
         */
        ret =3D ph->xops->do_xfer(ph, t);
-       if (ret)
+       if (ret =3D=3D -EOPNOTSUPP) {
+               ph->xops->xfer_put(ph, t);
+               goto return_normal;
+       } else if (ret)
                goto err_xfer;

        resp =3D t->rx.buf;
@@ -1695,6 +1698,7 @@ scmi_common_fastchannel_init(const struct
scmi_protocol_handle *ph,
                "Using valid FC for protocol %X [MSG_ID:%u / RES_ID:%u]\n",
                pi->proto->id, message_id, domain);

+return_normal:
        return;

 err_db_mem:
--
2.42.0