Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Thu, 2 Nov 2023 18:10:21 +0800
From:   Philip Li <philip.li@intel.com>
To:     kernel test robot <lkp@intel.com>
CC:     Daan De Meyer <daan.j.demeyer@gmail.com>,
        <oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        Martin KaFai Lau <martin.lau@kernel.org>
Subject: Re: net/core/filter.c:11773:17: warning: no previous declaration for
 'bpf_sock_addr_set_sun_path'
Message-ID: <ZUN1je8hduANA0KQ@rli9-mobl>
References: <202311021257.nD9pHYSn-lkp@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <202311021257.nD9pHYSn-lkp@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IVR9bSpygXByxwFYIoqn7iq39ei3aVYfvK3MI9xDJZZ3ETw8FAd77/ynEejM?=
 =?us-ascii?Q?OCyK+3fWKovCVvJJAzMNqgPNl9YTWRMXmAuDO3aud8j2vGDE1zPdfoSRVnhn?=
 =?us-ascii?Q?8vrVNz9CBiCoLkapt/XDKLQ9LcNu177HfnMoz35svTVqbcPxvlBPqJoz++i2?=
 =?us-ascii?Q?9lGNSCsoIwwk0c2T9Yp9NQWwK7Ba464dILbHXvhBjvt/VhAs1Qtxbuc7XzCd?=
 =?us-ascii?Q?RQUwJdhUsRRkN+JNwuZ0Zl9JKA9t2PpCqmUzDMFSy2BPCZUGiUCI4stOwQW2?=
 =?us-ascii?Q?DfitWt9XccESXV1xoD2EuVZst12wfGy9Jviz8C2bKbSIzhkL64y3mVLk8gIL?=
 =?us-ascii?Q?xMTKutQQKFeklKMbLBZ+xmPca8ctqyBb7cOsMXlXWqePRxXCCAnayICZM7g+?=
 =?us-ascii?Q?BzT0a7/eiSHo8d4dUGGq2XPnqwtDj/5uul7MJ12ZhZmkCPPDJCp23cMtiarD?=
 =?us-ascii?Q?xwGp+tp0AK43qo2Ldv2hRiblgfLctXnx9ybvT671Yr+Xd4NC/puW+uGWIyKl?=
 =?us-ascii?Q?a37ybW8NFovLogOV1V1eCOrtYnuMO916y7h8gZfp9UaIuYNKNbWm06GuMo/3?=
 =?us-ascii?Q?dzAuRHXp3AMWGofw+xk5aeQBQAkdVkoWooyvN3UNmfKvJLi/0IOZi2es6njY?=
 =?us-ascii?Q?qRH7JNvaUQds7wnpeMGINpFXUDeAjEjwalypZ76AQhdA+kkCl0T2zgK/LpaV?=
 =?us-ascii?Q?dADl16T+2lMaAXZ48/QvpbG3DqhQMKqr7p0Pklf/icuOp7bAY4aP52mdL31l?=
 =?us-ascii?Q?dKnNmnShj2XHNMzaDNNUopaQBenLHC250qZ1oVS6MUFRM1GFiY2/kjOS8Vi4?=
 =?us-ascii?Q?h2mLYIjkUSv9p7YDAb4FpVJ1HzfrSPX9+LgJTEK8cVUEq6sbLhSzoLlEHDOG?=
 =?us-ascii?Q?234IIlVieoLHPg2g+8ZRsNkyzkwzYTgRFJ/NhFTV1R2Xp7h1HCUy50kIjsuz?=
 =?us-ascii?Q?R7mNbiS0EhDyemx8VuhBzXjxEs1b1k9Po9G18+938vvTbRi3GG1cE1u5nJDI?=
 =?us-ascii?Q?O3xSw6yd0uI4/cZE1x2HRDtgxuJgg/oFFtdN8rakdJ1Ulx7oakJez0qMN0zD?=
 =?us-ascii?Q?Dzp4YkjidwT/ucdDI9SWhMJ0r3bSKMfPkWy9sI10qzO9s2v1DTdMFOKgygFj?=
 =?us-ascii?Q?xpV52mXuymtU3gZdLRU7ySLHOek+ZjgHEPnZugjdtP9FoNfqpkX6xf+in0BK?=
 =?us-ascii?Q?09JnO1A1IUjQwUKeTtFK95N/gIMplvn977ZyfTZyVSUCffPGfq4ZyuLtIT1Q?=
 =?us-ascii?Q?/GjNXYntTvNQl5/tQhu3nAfk1moCEiIuONb+OcMckbvT7959n7NOHpPj8qVH?=
 =?us-ascii?Q?XW/qREAT4EE/zFkeFg1LvH1L5n16Cxy3VCkjQbJ6srCYn2n6e/hU8/mmUVln?=
 =?us-ascii?Q?XTPhxqkTd3ul5MK4Z6+GcX9FjpuXIzsVEbaAant6JN+4lmJhPpFkhG3eMyNm?=
 =?us-ascii?Q?EkLsEhsSi79h1FdNVXMiUmTYHAo5WaEUjV3hYamWsYl6s9ANcZfNYV2g3Z76?=
 =?us-ascii?Q?TwVUE5efXUDga6kml8dJ3YcdZPJPuOyD6l5gKLEWm9YwkoKRpmhJdxxQYOnm?=
 =?us-ascii?Q?Iso26GMgdffXga/vM/3EslcAzM6TpZbw5UnLacp4?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dbda67e4-f9ae-47fa-4d6d-08dbdb8bf187
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB2995.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 10:10:30.5630
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mu6gUAm2KSWxrYKFs1vmdYF9Fb7rZbB8a7Fd3naZ92HIMalcBjnV1hKvMwM1FFszn7E0u997fiZGgczQCbC5Ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6758
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 02 Nov 2023 03:11:12 -0700 (PDT)

On Thu, Nov 02, 2023 at 12:14:31PM +0800, kernel test robot wrote:
> Hi Daan,
> 
> FYI, the error/warning still remains.

sorry for the false report, kindly ignore this. We will resolve the problem
in short time.

> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   babe393974de0351c0e6cca50f5f84edaf8d7fa1
> commit: 53e380d21441909b12b6e0782b77187ae4b971c4 bpf: Add bpf_sock_addr_set_sun_path() to allow writing unix sockaddr from bpf
> date:   3 weeks ago
> config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20231102/202311021257.nD9pHYSn-lkp@intel.com/config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231102/202311021257.nD9pHYSn-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311021257.nD9pHYSn-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    net/core/filter.c:11747:17: warning: no previous declaration for 'bpf_dynptr_from_skb' [-Wmissing-declarations]
>     __bpf_kfunc int bpf_dynptr_from_skb(struct sk_buff *skb, u64 flags,
>                     ^~~~~~~~~~~~~~~~~~~
>    net/core/filter.c:11760:17: warning: no previous declaration for 'bpf_dynptr_from_xdp' [-Wmissing-declarations]
>     __bpf_kfunc int bpf_dynptr_from_xdp(struct xdp_buff *xdp, u64 flags,
>                     ^~~~~~~~~~~~~~~~~~~
> >> net/core/filter.c:11773:17: warning: no previous declaration for 'bpf_sock_addr_set_sun_path' [-Wmissing-declarations]
>     __bpf_kfunc int bpf_sock_addr_set_sun_path(struct bpf_sock_addr_kern *sa_kern,
>                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    net/core/filter.c:11877:17: warning: no previous declaration for 'bpf_sock_destroy' [-Wmissing-declarations]
>     __bpf_kfunc int bpf_sock_destroy(struct sock_common *sock)
>                     ^~~~~~~~~~~~~~~~
> 
> 
> vim +/bpf_sock_addr_set_sun_path +11773 net/core/filter.c
> 
>  11772	
>  11773	__bpf_kfunc int bpf_sock_addr_set_sun_path(struct bpf_sock_addr_kern *sa_kern,
>  11774						   const u8 *sun_path, u32 sun_path__sz)
>  11775	{
>  11776		struct sockaddr_un *un;
>  11777	
>  11778		if (sa_kern->sk->sk_family != AF_UNIX)
>  11779			return -EINVAL;
>  11780	
>  11781		/* We do not allow changing the address to unnamed or larger than the
>  11782		 * maximum allowed address size for a unix sockaddr.
>  11783		 */
>  11784		if (sun_path__sz == 0 || sun_path__sz > UNIX_PATH_MAX)
>  11785			return -EINVAL;
>  11786	
>  11787		un = (struct sockaddr_un *)sa_kern->uaddr;
>  11788		memcpy(un->sun_path, sun_path, sun_path__sz);
>  11789		sa_kern->uaddrlen = offsetof(struct sockaddr_un, sun_path) + sun_path__sz;
>  11790	
>  11791		return 0;
>  11792	}
>  11793	__diag_pop();
>  11794	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki