Received: by 2002:a05:7412:b795:b0:e2:908c:2ebd with SMTP id iv21csp275467rdb; Thu, 2 Nov 2023 03:31:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZygSepEYsobHQHysxEBAfavixDjfaJBPL28cFL615mxSm1kx/rUm+yWXzOt6tq8icjZSR X-Received: by 2002:a05:6a00:3a21:b0:6c3:41d3:9630 with SMTP id fj33-20020a056a003a2100b006c341d39630mr309042pfb.28.1698921112836; Thu, 02 Nov 2023 03:31:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698921112; cv=none; d=google.com; s=arc-20160816; b=Y3Zu3W99gAOjG+KYVkIU7VPdwWb2h1PGyxhINV21dza0+AsG24OIgnPV6SYiDQCoTB topMQ3hXpP1D8TLvX+rSbqmKfxQLBpsQUb2I0tCATZbU4Cn6kMBENIlFqwXvHUXyHIrV AWFRA1gmMV1qn3VE3Iq/wz4duMw6CydHOXTV1/FbsLWpUqQuFGJpcKWqQbCRrHh8TfB9 E9PUoHfieBEP+eBQNtRMKz+7xc5X0OhpKLBXQEU1elbiw1gJ1YgkXELw9RFYf3S4wKZl RyR59Jr8xgjH+lP6DjZqPJUMpbj26SkeTwIcBGA/JwdbWQqCXAskTGmFxyT1J1Eylyjp d2Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CpjOzif0QjYVITE4SJqbyNSX7vVCExngH+2bDixVO2k=; fh=KoqND1vp4CRkMPdj5rLlABGGCR7swoDhkg2AuKyDFIU=; b=Y/yJzmYj4eCUoci6Uz31oBPSYivjX2/2848xvEpdlOmWT5K7+6q7m615WcRUna7dDc DjkzXEzuDURUdSk1q3V0ERb73bYU/NoqyltK9XpZ6GC7Xkq1tVZUGXIc0dTg8aon31EY 89kDigkVqjk908C6ChukA5ZuuFbDjkbjish2AGUx/6XQ37or8EIdyxaBwPwqwK1DzSOz /AS3uXIGAdIQPOiyp0MCm9wxBEDj3kJW5E2YkcOb2bzjJDYsHhjGyc3rgDAVWtXQP4pV l6c/+UE97bcFIY3MP6tFO78TUAGtobpsxljPaQGnphPvF7xwq+Pk3OgsPxWjOUd9SvXD p2oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=EwgFi+Js; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id p6-20020a056a000b4600b00690d695b113si3596089pfo.337.2023.11.02.03.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 03:31:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=EwgFi+Js; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id DF1E781489F4; Thu, 2 Nov 2023 03:31:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346804AbjKBKbb (ORCPT + 99 others); Thu, 2 Nov 2023 06:31:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346802AbjKBKba (ORCPT ); Thu, 2 Nov 2023 06:31:30 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0FAE187; Thu, 2 Nov 2023 03:31:27 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9d242846194so111823066b.1; Thu, 02 Nov 2023 03:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698921086; x=1699525886; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CpjOzif0QjYVITE4SJqbyNSX7vVCExngH+2bDixVO2k=; b=EwgFi+JsreEx26PQchIxW9xob6QlXxDTvO9COoSPNCvMBhEp9rre2XRhvrX3i/uPro NKeNAwil1do8CU0Rpw3RjyMzQL7Gao1WsPM4UzR67/yy74tBtmQgSrOO6Bebo+ritXjN 3e4l+3uNOTyOg7sSgNjtdOUUDSRnAvHINqTqMD3V5jBN8kZoOr7b0Mu9eNj1hxkh3vSZ FqEiY43YJI3W4xhVtQYmZhz4ziRCWH7xlJR0PfyE4b7DuoGPOLlW5O5KmL0wumGMiqLk itkqoYh3uHyQmIuWDlq5M5yc/7HQpoNBiMu8WityL+ZyiY+uB9hM7ZkIzmcQk8WWH0It MDqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698921086; x=1699525886; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CpjOzif0QjYVITE4SJqbyNSX7vVCExngH+2bDixVO2k=; b=aaZbk+fKTUxVAiQ7RzTcMt5+F7vb50ADaTvRzTOPwKCkBqbQP1k+TQbDSY34Kb9osA bVAVZ0A1zNXA9FHdZi3MOnHFKWkoHtIEcrKfqesPBhfgZj2bmxL15hB3b8qMYrsSffnv s6RlwI+PnaQeCMcqH886B7I5yIGWALnqLU9oscTc+xuUwHZ6IVECwXHPYkybceF8SYpn 8cBtAxwRmNekViIcjkbrHda8Q3POlv/2eJ9VoeDv7ux8pcaOvl4UWeqiPqdY7NfbRIRY dG5WYpaad/4Q1OA6iKzBY2xoOS2hYXb4/3z4Gl0/SG6uRfxq4rsKpaFPj+Prqv03d0Ae zpHw== X-Gm-Message-State: AOJu0YyMG4TSER5TsXJtwmtW/90syhA7I2rqe+MSzf+xtAhzSEgbe3kR rQ7LVM/itQxgRKbthDa4iPRpjFKvofzoxA== X-Received: by 2002:a17:906:3b53:b0:9c3:afd3:6136 with SMTP id h19-20020a1709063b5300b009c3afd36136mr3685529ejf.72.1698921086079; Thu, 02 Nov 2023 03:31:26 -0700 (PDT) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id d14-20020a170906370e00b009b2d46425absm969205ejc.85.2023.11.02.03.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 03:31:25 -0700 (PDT) Date: Thu, 2 Nov 2023 12:31:23 +0200 From: Vladimir Oltean To: Luiz Angelo Daros de Luca Cc: Linus Walleij , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: dsa: tag_rtl4_a: Bump min packet size Message-ID: <20231102103123.hklqlsbb5kbq53mm@skbuf> References: <20231030-fix-rtl8366rb-v2-1-e66e1ef7dbd2@linaro.org> <20231030141623.ufzhb4ttvxi3ukbj@skbuf> <20231030222035.oqos7v7sdq5u6mti@skbuf> <20231030233334.jcd5dnojruo57hfk@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 02 Nov 2023 03:31:50 -0700 (PDT) Hi Luiz, On Wed, Nov 01, 2023 at 09:35:30AM -0300, Luiz Angelo Daros de Luca wrote: > Hi Linus, > > Sorry but I noticed no issues: > > From the router: > > No. Time Source Destination Protocol Length Info > 1 0.000000000 192.168.1.1 192.168.1.2 ICMP 1514 Echo (ping) request id=0x0789, seq=23/5888, ttl=64 (reply in 2) > 2 0.000040094 192.168.1.2 192.168.1.1 ICMP 1514 Echo (ping) reply id=0x0789, seq=23/5888, ttl=64 (request in 1) > > From the host: > > No. Time Source Destination Protocol Length Info > 1 0.000000000 192.168.1.2 192.168.1.1 ICMP 1514 Echo (ping) request id=0x0002, seq=8/2048, ttl=64 (reply in 2) > 2 0.000391800 192.168.1.1 192.168.1.2 ICMP 1514 Echo (ping) reply id=0x0002, seq=8/2048, ttl=64 (request in 1) > > If I go over that limit, it fragments the packet as expected. Could you run the shell command that sweeps over the entire range, fromhere? https://lore.kernel.org/netdev/20231030222035.oqos7v7sdq5u6mti@skbuf/