Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Thu, 2 Nov 2023 11:49:20 +0100
From:   Larysa Zaremba <larysa.zaremba@intel.com>
To:     =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>
CC:     Andrii Nakryiko <andrii@kernel.org>,
        Mykola Lysenko <mykolal@fb.com>, <bpf@vger.kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        <netdev@vger.kernel.org>,
        =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@rivosinc.com>,
        Alexei Starovoitov <ast@kernel.org>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf] selftests/bpf: Fix broken build where char is
 unsigned
Message-ID: <ZUN+sBGnyT2Op7r5@lzaremba-mobl.ger.corp.intel.com>
References: <20231102103537.247336-1-bjorn@kernel.org>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231102103537.247336-1-bjorn@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?ySHDhGMj3vQaYPT35jEK9+JZEPocBswT8mB57HWfp13Dyl0r0nXw2JewFJ?=
 =?iso-8859-1?Q?14KrGoQT/7atAlMYf+NsgLS44XH+Z59pSSv8Nky0cehVGvOb25hJSN5vlw?=
 =?iso-8859-1?Q?fb5Jj4D7SoEWi2TPh1IkIHtO4yQmW4PqSUwQ1PYK0XdREGcG4Bi5ba8tAB?=
 =?iso-8859-1?Q?hPifBcCFAu+On7d9i2WswsDOXk2DcLa1Th3Kpm4JLmW3JEssIJd0HieX6b?=
 =?iso-8859-1?Q?lkukYd7Yg3KdiUihiqjk/ZYYZemL7P2Zd72F6o5rPAPniH//8j9CRyqT7h?=
 =?iso-8859-1?Q?avNFF8GJhIillsBti+rZy17B27XTjn+iVd7LMuhcO/HJ4XzXOtKF+cjT+C?=
 =?iso-8859-1?Q?HMmHyLp3cV06861kz/0uq3/l+xZYt+oh1XT5VUy0oDrazWzmkqMjRFMUaw?=
 =?iso-8859-1?Q?fv+M1ZuEbrg8UOUtw3WVFGODhwrDxf7PD5D70JeHPdfpJqFzaQGPIOW8+7?=
 =?iso-8859-1?Q?VxKavtIYciQVRJqhBs9zv52ocR1W2epQkNjIA/gTwkAh0dqiOwimYraiuU?=
 =?iso-8859-1?Q?kX9fiPpk6HNnDf1B45tZZSNWBrmQRDVRwUOfyAz6cwVFiZldBUA7QJkqkx?=
 =?iso-8859-1?Q?bRM+dWhQNC24kdJZADvkl0Wr5NXtioXfGuAX2qN3no84xQi0eGlDXTXwC/?=
 =?iso-8859-1?Q?Ftn34is1pMkThzae7XSH2JjfaQbkX8ToHn+lKWBbiJx/UC170bZKTf+7fE?=
 =?iso-8859-1?Q?+pk6EYYcS0GdWVRVgDWZz042ytXSTNlC/INgABL1l39Um83kz5Dm+Nvh/X?=
 =?iso-8859-1?Q?9uvU4ZRViS7FhhImSvsPL5qo0Hw68THuysoUo6+zz+U9aSKkBieWe3C2yU?=
 =?iso-8859-1?Q?IJPmPyCHhxhV4qVyTfjHPJHaXFG2065OtYY0vlIRPTlJMAoU0Gkt3KGgEB?=
 =?iso-8859-1?Q?Cb+lpBMx4FMf9azAsm6bBxV+ZlLVhn1weWWvFnF4BtwmhtMgF23t+l6epP?=
 =?iso-8859-1?Q?T8mH6A29hAl7p3vekK5/+KHFRmdF8qKSx2tNkdFl/O91dTJte/E/HtUpXp?=
 =?iso-8859-1?Q?FFNct+t9ni3D7HXdDxnLJYfhzqPz0eHh1fxtD0P+oVKqabzZwi7SHj+KYk?=
 =?iso-8859-1?Q?ldNxlkr/vGqVjVNgVgxWGJsVazcZVkT8J3eewN1JYTl3vcBFGYoykknAUV?=
 =?iso-8859-1?Q?rr1aPQrlJ9MT1K3a/s7bBCdYb7HE+tyYAd0ow7UsP7y+JUeGWzyTjgUz8V?=
 =?iso-8859-1?Q?K+SbHmL/13ZvvJ41eTatL5jQmpWLBYVwrS675ZqyHKEqB1J2kL9Yvwd+ZW?=
 =?iso-8859-1?Q?zIlHiINlSGqove6V0h/L7zwt/qyppBMZc/UEomsdxhLOnVnm1Qw8hQWvqq?=
 =?iso-8859-1?Q?wgogbb7glMFMbYaSVg7pGY5zl4C0IIB+4xqau8Vm0ICqd1XnuLowpwaogm?=
 =?iso-8859-1?Q?Eq8vEUdS723f3w09yHlwqfJ3xHPYWpr4XYEWMIEoypqcRJNcIPpr6HlWyp?=
 =?iso-8859-1?Q?DOLXXfv5AsTWf8vE5m68KdPfpx9XxBhdUgtUDYdQWgDqOoGL+wVl6uYaTT?=
 =?iso-8859-1?Q?ZQKI/4nYBLRNMUJlB97kBi4Orn6xBgQFekCE3lbpdoxSaztMJYz4ua30UN?=
 =?iso-8859-1?Q?g56xxkurUuVA8nEXl8joQgSZwNjMmjXJc9YGa/7xFUqUCE3no3n8OtwMGn?=
 =?iso-8859-1?Q?iJ/yASTyBMLawIt/n1HrcNfUtyn16fueVEf70g6QxZXaIpsx4EZrZAbg?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cfc200b-e4ed-4c9d-f725-08dbdb916275
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7540.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 10:49:27.2845
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 64c9X8sFm3NJ3E8BHQGTKeHPYYXDBp3fEv34Jxwlge+ZpPmK1hB1oRAXmuLmL9UxLiq7Q9kGQwvcvYwCzIKuB+TfuRUd+99Oj90fIBDGw00=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7550
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 02 Nov 2023 03:49:40 -0700 (PDT)

On Thu, Nov 02, 2023 at 11:35:37AM +0100, Bj?rn T?pel wrote:
> From: Bj?rn T?pel <bjorn@rivosinc.com>
> 
> There are architectures where char is not signed. If so, the following
> error is triggered:
> 
>   | xdp_hw_metadata.c:435:42: error: result of comparison of constant -1 \
>   |   with expression of type 'char' is always true \
>   |   [-Werror,-Wtautological-constant-out-of-range-compare]
>   |   435 |         while ((opt = getopt(argc, argv, "mh")) != -1) {
>   |       |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~
>   | 1 error generated.
> 
> Correct by changing the char to int.
> 
> Fixes: bb6a88885fde ("selftests/bpf: Add options and frags to xdp_hw_metadata")
> Signed-off-by: Bj?rn T?pel <bjorn@rivosinc.com>

Acked-by: Larysa Zaremba <larysa.zaremba@intel.com>

> ---
>  tools/testing/selftests/bpf/xdp_hw_metadata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/xdp_hw_metadata.c b/tools/testing/selftests/bpf/xdp_hw_metadata.c
> index 17c0f92ff160..c3ba40d0b9de 100644
> --- a/tools/testing/selftests/bpf/xdp_hw_metadata.c
> +++ b/tools/testing/selftests/bpf/xdp_hw_metadata.c
> @@ -430,7 +430,7 @@ static void print_usage(void)
>  
>  static void read_args(int argc, char *argv[])
>  {
> -	char opt;
> +	int opt;
>  
>  	while ((opt = getopt(argc, argv, "mh")) != -1) {
>  		switch (opt) {
> 
> base-commit: cb3c6a58be50c65014296aa3455cae0fa1e82eac
> -- 
> 2.40.1
> 
>