Received: by 2002:a05:7412:b795:b0:e2:908c:2ebd with SMTP id iv21csp319425rdb; Thu, 2 Nov 2023 04:57:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmRiMTz5EcIFwvA1TDhHcihTSD8nQ3vVvPa9vtcbAPjQL6+F0MHor1dpanZfrzPOEgXUY+ X-Received: by 2002:a05:6a20:9153:b0:17a:4871:63fd with SMTP id x19-20020a056a20915300b0017a487163fdmr10361179pzc.0.1698926245219; Thu, 02 Nov 2023 04:57:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698926245; cv=none; d=google.com; s=arc-20160816; b=Ur2UigZuDTh06M+mXp5G1Uzt148nB0474Szu4E/WKDqBwkBR7+6oJeYC4jAgeQa02c s0q1aKkun4RqLPaU2FT9yd1nGwpbdMruZ/FPO99pYbyrKHEsIbBz1dw4NalwCa5ehP0r EQfA++n0LL0t3AgJu0wjWYo1PiU2zrHNxAByO3cKpa+8OgacDjGQniW4s5L3hBQCOXod 8GQ3Ff5oVdyrI8Sn5BtYwoCVh7Z6rPgOs2UaTaM8iw85cSFfdh3/BZ2jbgWHVXk9fJcd ghAw8MBPVE9/tp/5H/s3J2BQCQ90vOjOEhWdn/Tx0c9tPYCVU41G8qbb8Wvm1aN6y7zz SJdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zpoyf0umzevL48zlxPDHoMyyBJL1AYvLijGDL66r8U0=; fh=Uy/4dU/oFQl9I9p3t1iqR6OPxvM6mEHVRCPnvwnQzNs=; b=y4UOg60a77MTk51m+e1eCzEDSVH/i3ZgOeHCr20aotCy3oLqAnXWzagsdjFdKcaY7C ZtkrOac6YXbYVXyXLalVVHXdRvPCftTOWYLOfasLhArVlVk4Ece8rJAtbBlaDT9i3ZS9 Xu7wTVN7aknkzwjVaiPcAf7ztxD1KJfr0N7O+u477sTRt7tTPu0zx/pxtS0U56yOrvtz whckYulYlcLnAdwZN0/tuBeq3XMjduCiSt5VeQAXAaub//TcDCRtDLKO+zVVRglOtrWy Ob/cNa5AOzNXcFdI51vB04IbYKPdLRaxFS+Fng0PJGn1lnhIfgCKlMK6ElzIT4dXDiGt VU2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=Y8nBbUmH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id f5-20020a056a00238500b006933c57195esi3398754pfc.399.2023.11.02.04.57.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 04:57:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=Y8nBbUmH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0455F804DDB3; Thu, 2 Nov 2023 04:57:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345340AbjKBL5X (ORCPT + 99 others); Thu, 2 Nov 2023 07:57:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbjKBL5W (ORCPT ); Thu, 2 Nov 2023 07:57:22 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3C28DC for ; Thu, 2 Nov 2023 04:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zpoyf0umzevL48zlxPDHoMyyBJL1AYvLijGDL66r8U0=; b=Y8nBbUmHyrFCPnUpfg4L/wT/tV Rb9l5vEDe9EsOi3GmhjiXaKLGJNAyhnCPu4XE9yqoSv/3a1b00CCQcPWjs1mJJsxLobKREw0MQQzM 7flM8kXa6gnUknd6kM0i9Rthlrg8YugyVA3/4NmF4VZhqzWjS7GgBBbE6ZSevRlhNB2g1IX/j6p4l D4M7CLHRgDfTSCzb1frM3xspjlE1iRZE+zACAhWakUtlckePnHeLw31IPlrghznuTX/IamKeIZSQk Fy57/AXyMIc8r2koEwuZQ+Pkl5XiERF5TPVM/tckiidjluvqxr1z8++d2RQMQXPPiUb3gIEDSS1G/ mPCcpIrg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qyWJU-006Y20-01; Thu, 02 Nov 2023 11:56:40 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id AA92F3004AB; Thu, 2 Nov 2023 12:56:39 +0100 (CET) Date: Thu, 2 Nov 2023 12:56:39 +0100 From: Peter Zijlstra To: Uros Bizjak Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH 2/3] x86/callthunks: Handle %rip-relative relocations in call thunk template Message-ID: <20231102115639.GC3818@noisy.programming.kicks-ass.net> References: <20231102112850.3448745-1-ubizjak@gmail.com> <20231102112850.3448745-3-ubizjak@gmail.com> <20231102114422.GB3818@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 02 Nov 2023 04:57:24 -0700 (PDT) On Thu, Nov 02, 2023 at 12:50:01PM +0100, Uros Bizjak wrote: > > Remove static, add decl, stuff like that? > > On second thought, you are right. Should I move the above function > somewhere (reloc.c?) , or can I just use it from alternative.c and add > decl (where?) ? Yeah, leave it there for now, perhaps asm/text-patching.h ?