Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20231005133059.917577-1-naresh.solanki@9elements.com> <f8dd6d53-7c0b-4a89-9ec4-400aa242c020@sirena.org.uk>
In-Reply-To: <f8dd6d53-7c0b-4a89-9ec4-400aa242c020@sirena.org.uk>
From:   Naresh Solanki <naresh.solanki@9elements.com>
Date:   Thu, 2 Nov 2023 17:35:42 +0530
Message-ID: <CABqG17iufSniSLZ2vU5fFduFwV2FL8jNzMcsveOgFUME1jXmgg@mail.gmail.com>
Subject: Re: [PATCH] drivers/regulator: Notify sysfs about status changes
To:     Mark Brown <broonie@kernel.org>
Cc:     zev@bewilderbeest.net, Liam Girdwood <lgirdwood@gmail.com>,
        Patrick Rudolph <patrick.rudolph@9elements.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Mark,

On Thu, 5 Oct 2023 at 22:30, Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Oct 05, 2023 at 03:30:58PM +0200, Naresh Solanki wrote:
>
> >  static int _notifier_call_chain(struct regulator_dev *rdev,
> >                                 unsigned long event, void *data)
> >  {
> > +     const char *name;
> > +     int ret;
> > +
> >       /* call rdev chain first */
> > -     return blocking_notifier_call_chain(&rdev->notifier, event, data);
> > +     ret =  blocking_notifier_call_chain(&rdev->notifier, event, data);
> > +
> > +     if (event & REGULATOR_EVENT_VOLTAGE_CHANGE) {
> > +             name = dev_attr_microvolts.attr.name;
> > +             sysfs_notify(&rdev->dev.kobj, NULL, name);
> > +     } else {
> > +             name = dev_attr_status.attr.name;
> > +             sysfs_notify(&rdev->dev.kobj, NULL, name);
> > +     }
>
> We probably should filter the events more, there's events for pre and
> post voltage change for example which aren't status changes so would be
> spurious.  It ought not to break anything but we should still avoid
> unneeded work.
Can you please provide me inputs on the additional filtering needed for this.
Like some list of events for notify on status?