Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Thu, 2 Nov 2023 14:38:31 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     Chen Ni <nichen@iscas.ac.cn>, lee@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: intel-lpss: Fix IRQ check
Message-ID: <ZUOYR1l9D5s3bI37@smile.fi.intel.com>
References: <20231101062643.507983-1-nichen@iscas.ac.cn>
 <20231101070310.GF17433@black.fi.intel.com>
 <ZUIclOuVocLUUk7_@smile.fi.intel.com>
 <20231101104717.GH17433@black.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231101104717.GH17433@black.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Nov 01, 2023 at 12:47:17PM +0200, Mika Westerberg wrote:
> On Wed, Nov 01, 2023 at 11:38:28AM +0200, Andy Shevchenko wrote:
> > On Wed, Nov 01, 2023 at 09:03:10AM +0200, Mika Westerberg wrote:
> > > On Wed, Nov 01, 2023 at 06:26:43AM +0000, Chen Ni wrote:

...

> > > > -	if (!info || !info->mem || info->irq <= 0)
> > > > +	if (!info || !info->mem)
> > > 
> > > This check (info->irq <= 0) covers both "invalid" interrupt numbers
> > > (that's the negative errno and 0 as no interrupt) so I don't see how
> > > this change makes it any better and the changelog does not clarify it
> > > either.
> > 
> > It makes sense. The IRQ here may not be 0. We should actually fix
> > the PCI code to guarantee that (platform_get_irq() guarantees that
> > in platform driver).
> 
> Yeah but I mean the check above handles any "invalid" interrupt number
> just fine regardless. I don't see any point changing that.

The point is to have proper error code to be returned. Currently it's shadowed
in this check.

-- 
With Best Regards,
Andy Shevchenko