Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Feedback-ID: i68a1478a:Fastmail
Date:   Thu, 2 Nov 2023 08:26:12 -0500
From:   Patrick Williams <patrick@stwcx.xyz>
To:     Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
Cc:     Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: emc1403: Add support for EMC1442
Message-ID: <ZUOjdGPDX06ehrLB@heinlein.vulture-banana.ts.net>
References: <20231102090808.427351-1-Delphine_CC_Chiu@wiwynn.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="9y/QB9703V4eDch+"
Content-Disposition: inline
In-Reply-To: <20231102090808.427351-1-Delphine_CC_Chiu@wiwynn.com>
Precedence: bulk


--9y/QB9703V4eDch+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 02, 2023 at 05:08:07PM +0800, Delphine CC Chiu wrote:

I have a datasheet for this chip with a "Revision 1.0 (10-25-10)" in the
footer.  Reviewed the change against the datasheet.

> Add support for EMC1442 which is compatible with EMC1403.
>=20
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> ---
> change in v2:
> Revised emc1403 to emc1402

> +	case 0x60:
> +		strscpy(info->type, "emc1442", I2C_NAME_SIZE);
> +		break;

Confirmed against datasheet.

Section 2.2 "Register Set Delta" specifies:
    - Product ID | 60h

>  static const unsigned short emc1403_address_list[] =3D {
> -	0x18, 0x1c, 0x29, 0x4c, 0x4d, 0x5c, I2C_CLIENT_END
> +	0x18, 0x1c, 0x29, 0x3c, 0x4c, 0x4d, 0x5c, I2C_CLIENT_END

Confirmed against datasheet.

Section 5.1.2 "SMBus Address and RD/WR Bit" has a table indicating that
a 22k pull-up resistor corresponds to `0011_100?` binary.

>  	{ "emc1422", emc1402 },
>  	{ "emc1423", emc1403 },
>  	{ "emc1424", emc1404 },
> +	{ "emc1442", emc1402 },

Datasheet section 2.1 is titled "Functional Delta from EMC1412 to
EMC1442", with minimal differences.  We map "emc1412" to `emc1402`, so
mapping "emc1442" to the same should be appropriate.


Reviewed-by: Patrick Williams <patrick@stwcx.xyz>

--=20
Patrick Williams

--9y/QB9703V4eDch+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmVDo3IACgkQqwNHzC0A
wRno2w/9EP6FkMIG1Z66KQ9SB7n41ROCzu00EHnKD4IJ8v1p0crAFeeboxl3/QAU
/gp+M3yyQXRobr0tn3AmCgPHBUpOx6nqVSN/X1XruE0G5eFLRosou+qJQl10LeVJ
qEuyKL4tSgRX1sL5HP9zcNQqwqyDXYwqWDiShgLfuJhMKt9g4mi8EUS3JvU+DWwb
Fa9uZRCkb+eAMjfGZXlZDf+dRAjSnm+euuKcHUaKQy+EX4VMx0B0fvZ2DGuIhXy4
5/DfXi9dXIR1BoDNHXjkeqrycerWdXU73h4puNBgim+c6hCA3iplCYcwx7rsthk3
P8m0pyqCP2sFLE4K32n/j1ZFKwy+b9+SBwmqpLnQuyT1ukdLa1xJEVh2yY5vECNO
M9zHLhUcUlj4NgqN3o9sxrtYAZn4SgEOuV3dPxjNOJyfw3P+CMm2gZ5aDTkGGTM3
1JzGomy20LOvweUWPxnQ7VRS8WedAFWgZPVeyAU+1ThFICRvRKELn3xz9beblAlO
IzUVPsODOPZ7QW5htxYCMUXidN8i8nxUOY+UgLuq8/xLmoM3HkcHKgdaqw8v+QYm
FC7ycXgXQvhfwxWoJaFzQ1QLSF3HOthHounyYsflqKG8dRnfrQVoaS6G6JMu9SbE
iQ+OL3n+B3E1SmRFBqVYYuWSwZlEAqmTQWiK3CFXlMFjkrkWy24=
=Cngv
-----END PGP SIGNATURE-----

--9y/QB9703V4eDch+--