Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <9cca73d6-9089-4a0f-af8d-fac2ca8cd30b@amd.com>
Date:   Thu, 2 Nov 2023 08:28:17 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/4] platform/x86/intel/wmi: thunderbolt: Use bus-based
 WMI interface
Content-Language: en-US
To:     Armin Wolf <W_Armin@gmx.de>, jithu.joseph@intel.com,
        maurice.ma@intel.com, hdegoede@redhat.com, markgross@kernel.org,
        ilpo.jarvinen@linux.intel.com
Cc:     Dell.Client.Kernel@dell.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231102042959.11816-1-W_Armin@gmx.de>
 <20231102042959.11816-4-W_Armin@gmx.de>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20231102042959.11816-4-W_Armin@gmx.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2JpcmZ1bmd4WGl6VVQ2c1kvZ2l6TTBMUzh5NFdXVjI5enI3SG9zRzhaaDla?=
 =?utf-8?B?NVpxMjJYWFNJR29Fd3JPT2RQeXVmYVVsSm1JNkZQRUp1dzg2WUI1K2psY0Jt?=
 =?utf-8?B?ckZDa1NmUnVFcmhRSXVWVlpiUlBnandNV3YrTWQwZUNBQ2ZOVTJnYUlwdFBk?=
 =?utf-8?B?YlBSVUtPWmVIOWdxcnh3T2ZXS1llTGRyUDBXNGZNa213TDFNNWZWamFxZ2Jo?=
 =?utf-8?B?L1gzTmZrOGhGSU4zYnB2andWN08zaEdMNm5GS0graWtWUTduSFgyTURJQTUr?=
 =?utf-8?B?UitYb2RiVkFqSHlEMWNqOHZLRDFYTWhyUEorZ0luN2J0Vyt3Qmp3a1V5U1M5?=
 =?utf-8?B?NytyekxrRkNkZE5vVWFVY1E2RGlpQ1A2Y0I5eTBVdG93MEtDVFBMMjA0dkFV?=
 =?utf-8?B?SENOTU9hN3R3TlBGZkNjUXRhMWhRTitQeldPZTlUQ2svb09sSXZiRS9EUjA5?=
 =?utf-8?B?Z0ZrVkVPMmtjblZoQms3c3BSTysxeml1YzZMd3c4UldLUXl3M0lVSGd1NWNn?=
 =?utf-8?B?Wms4ZG1jSTFLMnBTdGZlUWFiY29SSXFrMWRXaFBDNm9kcmU5blNBNnBHQU9i?=
 =?utf-8?B?Z1ByRnlCbVh4a3RCUU0xTE12K1hYNlBPY2dvUmJBWlg5ZWkwRTI1T2Y4bEVP?=
 =?utf-8?B?bXlFS2FNU0E3WHp5Y1JnWXd4cVpxdEhpODY5czJlM3NVNjBpQUYwM3diY3Yv?=
 =?utf-8?B?V2FlZ1drMjhkallMZDZKZzVBZXNaeVNDU2xDVzVtUExvUWpoM2tsdjZFL2I5?=
 =?utf-8?B?Ykg0d0tKays3cXRWcVFlKzJZMlhKZzUzOXkzMktoKzJTd2pkb2J1N1ZOR0ZN?=
 =?utf-8?B?c1RpemhXQ3QyVkxEWW9LRUczRDhRZGRDQ0lNalhZU0dGendReGtoaUpQRk9v?=
 =?utf-8?B?MGlVYXdtMEhycE1GWkpZYnhxMFFsNEErTkxZVEJaaERYcHVCY2pUOXVhWnU1?=
 =?utf-8?B?V1NPc2w0ZUwzcGhQQ3lnWTRJMG4renlFVUtocEFmb3JTVEIvMW94eHk1cVND?=
 =?utf-8?B?Wm5xODdNaU1VQlU3UmF5czQzL0tUeXZHOS96WFdUOWNMaXczUDZwRXltVE1Y?=
 =?utf-8?B?TU45MjcweWZPdWdTa1VURldrYmdEREs2dU1mbCtjWjRHY0VuRkgxTVlCUzdC?=
 =?utf-8?B?anFSRFJXMHVBUFZGcjNtS3NITnZFWGdlNkgxZElnbERibDVYWjdwSTVXVERK?=
 =?utf-8?B?RFpUNGtIUzhEMUV0L3hqdzJSazBFUEVDZUc5L2lMSU12WTUvTzBualYxbHhX?=
 =?utf-8?B?MzM3UHJuNTFxZk5nSHBQTHRHZGRieGI2aHFPTmtYbnVVMVMxTXhjMzJQUTJ1?=
 =?utf-8?B?NGR0OGJWV1BLbVRDZSsxREVDZW1yZTlDRXh6Zmt0R3YzcjZZclpyQ2xDaG50?=
 =?utf-8?B?R0JjODQ0bWxQc1dKeFdqNjFqbjRZKzgwa09XNm1LVitKTThMTnlFMEpCMHZt?=
 =?utf-8?B?eDBWQlgxNGhvc3VUQ1ZtczFObE1TOGJsRGhob2JnbnEwWXZSTUhOQWQwaDRp?=
 =?utf-8?B?WTh6QVdVR2lwOHJySjZpSjlhYmVGTE84eDMyb004RFdnNHZzUXBvZklkTThW?=
 =?utf-8?B?eTVoN096WkJpWjJ6Zk9aWHJjWUN2UVo3aThKaVRjbjh2eHlNd3BIZjNHYzVo?=
 =?utf-8?B?QkozdXFFRjN3L0p1b0ZjVDQ4bWo4dm5QajFURnZPZCtBRndxV3lVQk95UEpZ?=
 =?utf-8?B?VWxBYW1WMGVWM1p0aGJyaG45TUo3WFpTR2JCZ2lTSVliekFWa0N1eWFXSldv?=
 =?utf-8?B?MVV4dW54Y3JDS3haVEJQTURJOFgvZnpwLzBEa3BRWjFUbjJNTFBGKzZIaDJy?=
 =?utf-8?B?MWU1YUo3SitiYmp0ZFNGUlVnMTFpYUN3OTlndnVCWUxTa05xV1NrS2VYMmpF?=
 =?utf-8?B?OEFsdEZFOS9iRzlienI0eUFkNEZiczBGWFNwQ3haM3ZwT2h6dG1iQUpJbGxu?=
 =?utf-8?B?TXBNRE84V2dQWjlsa3pkdHlNSGVwY0c0eUFqcy91bHYxbDRNNjlOZGJxSmlT?=
 =?utf-8?B?YXpkc242VTRGc2VOSldCaHc4cklrLzBiVEFEa1ZBekNoVUt2SHNxdVhBbmRM?=
 =?utf-8?B?eGo3amMvcnlGQzNWVVlkUitQS2FNbUtDZmIxeVV5WjduNDdpWXRQNHhweVd6?=
 =?utf-8?Q?PsqhZrLwP2hgyd9ErCc3Nxsif?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 551397f8-3bd9-4519-bba9-08dbdba79442
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 13:28:19.8381
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vJy1cjzwx5rlIbz3oDy2Lwzls1Sb3G7Erq1Oyuocm4x9PZt2jkgKdklxYXDTeA6S1A24BqhbeAXU0S4Z259fjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5130
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 02 Nov 2023 06:28:32 -0700 (PDT)

On 11/1/2023 23:29, Armin Wolf wrote:
> Currently, the driver still uses the legacy GUID-based interface
> to invoke WMI methods. Use the modern bus-based interface instead.
> 
> Tested on a Lenovo E51-80.
> 
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
>   drivers/platform/x86/intel/wmi/thunderbolt.c | 3 +--
>   drivers/platform/x86/wmi.c                   | 1 +
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/wmi/thunderbolt.c b/drivers/platform/x86/intel/wmi/thunderbolt.c
> index fc333ff82d1e..e2ad3f46f356 100644
> --- a/drivers/platform/x86/intel/wmi/thunderbolt.c
> +++ b/drivers/platform/x86/intel/wmi/thunderbolt.c
> @@ -32,8 +32,7 @@ static ssize_t force_power_store(struct device *dev,
>   	mode = hex_to_bin(buf[0]);
>   	dev_dbg(dev, "force_power: storing %#x\n", mode);
>   	if (mode == 0 || mode == 1) {
> -		status = wmi_evaluate_method(INTEL_WMI_THUNDERBOLT_GUID, 0, 1,
> -					     &input, NULL);
> +		status = wmidev_evaluate_method(to_wmi_device(dev), 0, 1, &input, NULL);
>   		if (ACPI_FAILURE(status)) {
>   			dev_dbg(dev, "force_power: failed to evaluate ACPI method\n");
>   			return -ENODEV;
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index 4c4effc883ae..58e7d5d535ba 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -107,6 +107,7 @@ static const char * const allow_duplicates[] = {
>   	"05901221-D566-11D1-B2F0-00A0C9062910",	/* wmi-bmof */
>   	"8A42EA14-4F2A-FD45-6422-0087F7A7E608",	/* dell-wmi-ddv */
>   	"44FADEB1-B204-40F2-8581-394BBDC1B651",	/* intel-wmi-sbl-fw-update */
> +	"86CCFD48-205E-4A77-9C48-2021CBEDE341",	/* intel-wmi-thunderbold */

s/thunderbold/thunderbolt/

>   	NULL
>   };
> 
> --
> 2.39.2
>