Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <0c4ea410-4213-4ab6-9151-da312a50aacf@amd.com>
Date:   Thu, 2 Nov 2023 09:29:22 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 09/14] x86/sev: Add Secure TSC support for SNP guests
Content-Language: en-US
To:     nikunj@amd.com, linux-kernel@vger.kernel.org, x86@kernel.org,
        kvm@vger.kernel.org,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc:     bp@alien8.de, mingo@redhat.com, tglx@linutronix.de,
        dave.hansen@linux.intel.com, dionnaglaze@google.com,
        pgonda@google.com, seanjc@google.com, pbonzini@redhat.com
References: <20231030063652.68675-1-nikunj@amd.com>
 <20231030063652.68675-10-nikunj@amd.com>
 <b5e71977-abf6-aa27-3a7b-37230b014724@amd.com>
 <60e5b46c-7e4b-44bb-a76f-a4b30b154d4a@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Autocrypt: addr=thomas.lendacky@amd.com; keydata=
 xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1
 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn
 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN
 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb
 aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez
 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA
 udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6
 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg
 hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U
 NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj
 a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK
 CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAl/aLz0FCQ7wZDQACgkQ
 3v+a5E8wTVPgshAA7Zj/5GzvGTU7CLInlWP/jx85hGPxmMODaTCkDqz1c3NOiWn6c2OT/6cM
 d9bvUKyh9HZHIeRKGELMBIm/9Igi6naMp8LwXaIf5pw466cC+S489zI3g+UZvwzgAR4fUVaI
 Ao6/Xh/JsRE/r5a36l7mDmxvh7xYXX6Ej/CselZbpONlo2GLPX+WAJItBO/PquAhfwf0b6n5
 zC89ats5rdvEc8sGHaUzZpSteWnk39tHKtRGTPBSFWLo8x76IIizTFxyto8rbpD8j8rppaT2
 ItXIjRDeCOvYcnOOJKnzh+Khn7l8t3OMaa8+3bHtCV7esaPfpHWNe3cVbFLsijyRUq4ue5yU
 QnGf/A5KFzDeQxJbFfMkRtHZRKlrNIpDAcNP3UJdel7i593QB7LcLPvGJcUfSVF76opA9aie
 JXadBwtKMU25J5Q+GhfjNK+czTMKPq12zzdahvp61Y/xsEaIGCvxXw9whkC5SQ2Lq9nFG8mp
 sAKrtWXsEPDDbuvdK/ZMBaWiaFr92lzdutqph8KdXdO91FFnkAJgmOI8YpqT9MmmOMV4tunW
 0XARjz+QqvlaM7q5ABQszmPDkPFewtUN/5dMD8HGEvSMvNpy/nw2Lf0vuG/CgmjFUCv4CTFJ
 C28NmOcbqqx4l75TDZBZTEnwcEAfaTc7BA/IKpCUd8gSglAQ18fOwU0EVo1liQEQAL7ybY01
 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb
 r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I
 bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2
 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO
 lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9
 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M
 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8
 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob
 pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+
 LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe
 /5rkTzBNUwUCYSZsLQUJDvBnJAAKCRDe/5rkTzBNU+brD/43/I+JCxmbYnrhn78J835hKn56
 OViy/kWYBzYewz0acMi+wqGqhhvZipDCPECtjadJMiSBmJ5RAnenSr/2isCXPg0Vmq3nzv+r
 eT9qVYiLfWdRiXiYbUWsKkKUrFYo47TZ2dBrxYEIW+9g98JM28TiqVKjIUymvU6Nmf6k+qS/
 Z1JtrbzABtOTsmWWyOqgobQL35jABARqFu3pv2ixu5tvuXqCTd2OCy51FVvnflF3X2xkUZWP
 ylHhk+xXAaUQTNxeHC/CPlvHWaoFJTcjSvdaPhSbibrjQdwZsS5N+zA3/CF4JwlI+apMBzZn
 otdWTawrt/IQQSpJisyHzo8FasAUgNno7k1kuc72OD5FZ7uVba9nPobSxlX3iX3rNePxKJdb
 HPzDZTOPRxaRL4pKVnndF2luKsXw+ly7IInf0DrddVtb2647SJ7dKTvvQpzXN9CmdkL13hC5
 ouvZ49PlXeelyims7MU0l2Oi1o718SCSVHzISJG7Ef6OrdvlRC3hTk5BDgphAV/+8g7BuGF+
 6irTe/qtb/1CMFFtcqDorjI3hkc10N0jzPOsjS8bhpwKeUwGsgvXWGEqwlEDs2rswfAU/tGZ
 7L30CgQ9itbxnlaOz1LkKOTuuxx4A+MDMCHbUMAAP9Eoh/L1ZU0z71xDyJ53WPBd9Izfr9wJ
 1NhFSLKvfA==
In-Reply-To: <60e5b46c-7e4b-44bb-a76f-a4b30b154d4a@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjFOcTgwUHczT1JPYm1NK1dsU3I0RTlVaEpnaGFSNFNleThxTDBqbkZPQy96?=
 =?utf-8?B?SDFVNnV0dGlkUjZUTUlqRGRwZlhmSnNvOE9RSVBPcUVLSU9hL3lzNXBtckZC?=
 =?utf-8?B?QzBPOHRLdVZKOXF0aGxvcEVQdzJHR29iTDJvbittWWRGdmhqeDdzUG42L2c0?=
 =?utf-8?B?WlRhbjU4dGlOZXY1c3hmS3NLNGE0T0ZvYlArR0syRnF1aFM5NnpDdi84Smd0?=
 =?utf-8?B?QStaRS9EeU1jS2R4N3Jnbm1aM3pWSlBRUVlBMWZDbXUrTUVTY0RWRmR1K09Y?=
 =?utf-8?B?VnJjc1J4OENUL0szN2xvTHgyUzJkRzZZaVpmQWVPT3l1czNrS0xkMlVnQjJ4?=
 =?utf-8?B?Uk85QVJmNmdRKzdSb3dqbklVbmFQYUFNNDRPa1RaWHNFN0FrLzlGMUdBU1Yv?=
 =?utf-8?B?S2I2K0VnSXlvVHZLVEtYdXRFRmhSWHlPSWlvMGptVzRiWWZyVC80eWxHZTdu?=
 =?utf-8?B?dXlXZnUxMzBxSE5aZlhIakc3N1R6dWhCaTRiUGlpNi95cnpReFV5eVRwV3Ew?=
 =?utf-8?B?MWE4dDJkdlI2WmxkZ3NwakJuV01EL0R6VTF3MnlORTU5NXJLbEJHdHJFalFP?=
 =?utf-8?B?T3RmVXFSWEZJeXBqNC9JM2FWY2VDM3FFd3R6c3F2czZET1B3VEFXSFFUUDgr?=
 =?utf-8?B?dkVxd0FNRFREYmtFK1JZcGV5aGZ3bGkvbjFQeWx2VXp4a0EzaWhmWTQ5VTg2?=
 =?utf-8?B?L2hQVEF6eVpzZUl3T25MMWdKWXd0bytLSjJ3MUdXdVc2Q3VBRWVLMGlaaEtU?=
 =?utf-8?B?WEFYeStrS2xmUHVVTlFHK05zRlNqLzFZQWZMT0hhaUNORmRvcEtpVGZwQTlK?=
 =?utf-8?B?YUJKUHJSYXRQbUVUR2krSUZRb0JBNlEvaGxDNHQxUmtRd1EyRVJkOTlEakpB?=
 =?utf-8?B?WEVYK2xuTzRkQ2ppdWN6cDBBVUV3WW9OS0dNUFdQTXIzM2RjcUdCM3Q3NE9u?=
 =?utf-8?B?OWZRdXdJWnJXak5zUkh6ekU3L2NYeXZVTkp5M3lMUEZBclJPNXJXd1ZaSnpl?=
 =?utf-8?B?eEVDb1hXeXZzRkg5MW9peXJJSE1FWEhXL1N5emg1UXlpYmc5aDBKZE1SRTNU?=
 =?utf-8?B?STVsaHpvU1Z3VjFXUVJqUnlSV1QyU05hSHA5bTk1VkFiWmhWUjc4UnM0bWxT?=
 =?utf-8?B?NVorZ0dmYlFrTUxBaVMwbHdsSlQ1dmh4aFhtaDQvc2NOOWZLSjh2R291NG15?=
 =?utf-8?B?N1VUbmwwSVhONmdjZTBFZjVNVHM3aGlHcTJHTHM2Vk8zYVF1bTZ0aDlQVE55?=
 =?utf-8?B?R2VreHdWZTRVTTRjOFc5N0RTUGNLTldGbmVQOGVXeXgwUlJsd2ZWaWdRMEkv?=
 =?utf-8?B?T1pTUUpoY0FjZ1dkaXFFUWVzUWRDcmhFUzlxRkFNdzVpWWpIU1lsRWUyTWVy?=
 =?utf-8?B?bEg2Sm8zK0NzMmlNclFSMGVVOUp4dklXRnNRS2xGWGRjaFNFWGNnSWcraGd0?=
 =?utf-8?B?VUJRRzVYcThncERjRk5FQTZNdGpYUEZmYmNUL2hpWHBiWTZDMjJrZkhOUGdx?=
 =?utf-8?B?bktXNEJ0OWJrTGtFaWdISk1ZUUlzZTRSODdTNkR1cmQ3R3pmY2tLV2ZWNy8w?=
 =?utf-8?B?WlhNVENhK2wrTURocHlBV0RIdjVocHovZGFWc0VNUXdiM0ExVHlwWUxRNHZ3?=
 =?utf-8?B?YzAxK29LdkYzaFhzcmYyTnpMaFVOUnRDYXVGcFgzclgwR0RGQUNEcjhZNUpH?=
 =?utf-8?B?eHEvb3hWVjZpeTM3TmVtWGh5NE1yTi9CNG5IYnYzUXp0NE9pWHFza3J0ay95?=
 =?utf-8?B?dWNlL250cDQvbWZRQnJmdTAyeGpjWVpUeXdyYTVmbnpKaUowNkM5SCtOejZH?=
 =?utf-8?B?a0c4M3hCeCtNenQyMmRhQTgzQzJrZHF3WGpGb3lJTTVKczdTNTU5MVpQeW9r?=
 =?utf-8?B?dFdYZ0pBY3Z0WVYxWVV3bDZCdnp1YjFqT250anBCdFJJcUw2VTF0S296NHdD?=
 =?utf-8?B?OTJpbWpxRTFYTTE4MDk4Vitwekl4bmxqSEhnK3ZwdkhJZU5DUGY3VzBhUXNx?=
 =?utf-8?B?aFdDTnAwZFY5TjZKNlZGY2N3VTRCVm4rbTBoWEI3ZVRFMFpBczFnNHI5MlI0?=
 =?utf-8?B?VU5KYWlldG9GcnRURUx3VFVzR0VqVlhSVW1WNk5QeDBEZTFCajkyY2JVUVUx?=
 =?utf-8?Q?AnF6GOA5Rb2Pk6IZLfIXJPrBr?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2332115-ec17-43bf-0b5d-08dbdbb01d36
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 14:29:25.5294
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n0KCoida6k2QBUyqr/I9nDMcT2KKrvplLvt0Pa9g8bI9YO2KAB+t6/LXosuCQWeetK/HlR+kOZwXwIGB9WU7OA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6840
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 02 Nov 2023 07:30:25 -0700 (PDT)

On 11/2/23 00:36, Nikunj A. Dadhania wrote:
> On 10/31/2023 1:56 AM, Tom Lendacky wrote:
>> On 10/30/23 01:36, Nikunj A Dadhania wrote:
>>> Add support for Secure TSC in SNP enabled guests. Secure TSC allows
>>> guest to securely use RDTSC/RDTSCP instructions as the parameters
>>> being used cannot be changed by hypervisor once the guest is launched.
>>>
>>> During the boot-up of the secondary cpus, SecureTSC enabled guests
>>> need to query TSC info from AMD Security Processor. This communication
>>> channel is encrypted between the AMD Security Processor and the guest,
>>> the hypervisor is just the conduit to deliver the guest messages to
>>> the AMD Security Processor. Each message is protected with an
>>> AEAD (AES-256 GCM). Use minimal AES GCM library to encrypt/decrypt SNP
>>> Guest messages to communicate with the PSP.
>>
>> Add to this commit message that you're using the enc_init hook to perform some Secure TSC initialization and why you have to do that.
> 
> Sure, will add.
>   
>>>
>>> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
>>> ---
>>>    arch/x86/coco/core.c             |  3 ++
>>>    arch/x86/include/asm/sev-guest.h | 18 +++++++
>>>    arch/x86/include/asm/sev.h       |  2 +
>>>    arch/x86/include/asm/svm.h       |  6 ++-
>>>    arch/x86/kernel/sev.c            | 82 ++++++++++++++++++++++++++++++++
>>>    arch/x86/mm/mem_encrypt_amd.c    |  6 +++
>>>    include/linux/cc_platform.h      |  8 ++++
>>>    7 files changed, 123 insertions(+), 2 deletions(-)
>>>

>>> +void __init snp_secure_tsc_prepare(void)
>>> +{
>>> +    if (!cc_platform_has(CC_ATTR_GUEST_SECURE_TSC))
>>> +        return;
>>> +
>>> +    if (snp_get_tsc_info())
>>> +        sev_es_terminate(SEV_TERM_SET_GEN, GHCB_SNP_UNSUPPORTED);
>>
>> How about using SEV_TERM_SET_LINUX and a new GHCB_TERM_SECURE_TSC_INFO.
> 
> Yes, we can do that, I remember you had said this will required GHCB spec change and then thought of sticking with the current return code.

No spec change needed. The base SNP support is already using it, so not an 
issue to add a new error code.

Thanks,
Tom