Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Content-Type: multipart/mixed; boundary="------------GnluoRzsnuYax0s2uyTESTIh"
Message-ID: <f9a5fda5-30db-f805-f079-a53a9c0218ce@redhat.com>
Date:   Thu, 2 Nov 2023 15:28:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2 6/7] drm/i915/dsi: Replace poking of CHV GPIOs behind
 the driver's back
Content-Language: en-US, nl
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Jani Nikula <jani.nikula@intel.com>,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
References: <20231024155739.3861342-1-andriy.shevchenko@linux.intel.com>
 <20231024155739.3861342-7-andriy.shevchenko@linux.intel.com>
 <ZTfssxRsrDxhzSQ6@smile.fi.intel.com>
 <b489675d-e9de-4bca-9622-78545aa8606d@redhat.com>
 <16e533e2-81bb-47ba-9e23-460a626bcad7@redhat.com>
 <ZUIbPtEEbl6pjdqg@smile.fi.intel.com>
 <f68dca47-d9ed-a146-b152-c19bcc9d8828@redhat.com>
 <ZUOwAn158pUELTBq@smile.fi.intel.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <ZUOwAn158pUELTBq@smile.fi.intel.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------GnluoRzsnuYax0s2uyTESTIh
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

On 11/2/23 15:19, Andy Shevchenko wrote:
> On Wed, Nov 01, 2023 at 11:20:23AM +0100, Hans de Goede wrote:
>> On 11/1/23 10:32, Andy Shevchenko wrote:
>>> On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote:
>>>> On 10/31/23 17:07, Hans de Goede wrote:
>>>>> On 10/24/23 18:11, Andy Shevchenko wrote:
>>>>>> On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote:
> 
> ...
> 
>> Note you still need the first part of my patch which is
>> an unrelated bugfix:
>>
>> --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
>> @@ -219,8 +219,7 @@ static void soc_exec_gpio(struct intel_connector *connector, const char *con_id,
>>  	} else {
>>  		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
>>  						 con_id, gpio_index,
>> -						 value ? GPIOD_OUT_LOW :
>> -						 GPIOD_OUT_HIGH);
>> +						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
>>  		if (IS_ERR(gpio_desc)) {
>>  			drm_err(&dev_priv->drm,
>>  				"GPIO index %u request failed (%pe)\n",
> 
> Can you attach or send a formal submission, so I can incorporate it into one
> (v3) series among other changes?

I thought this fixed new code in your series and it is a trivial fix,
so my idea was that you would just fold the fix into the patch
introducing the code.

But I see now that this is existing code from bxt_exec_gpio().

A formal fix to use as a prep patch for your series is now attached,
this is based on top of drm-misc-next (I guess drm-intel-next
would be better but I had an up2date drm-misc-next handy).

Regards,

Hans


--------------GnluoRzsnuYax0s2uyTESTIh
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-drm-i915-dsi-Fix-wrong-initial-value-for-GPIOs-in-bx.patch"
Content-Disposition: attachment;
 filename*0="0001-drm-i915-dsi-Fix-wrong-initial-value-for-GPIOs-in-bx.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBjMzAwZWQwZTA5ZDFmZDE0YmY5NjZkYzE3MmM2ZGI1NGI4ODhmYWYzIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUByZWRoYXQu
Y29tPgpEYXRlOiBXZWQsIDEgTm92IDIwMjMgMTE6NDk6MDEgKzAxMDAKU3ViamVjdDogW1BB
VENIXSBkcm0vaTkxNS9kc2k6IEZpeCB3cm9uZyBpbml0aWFsIHZhbHVlIGZvciBHUElPcyBp
bgogYnh0X2V4ZWNfZ3BpbygpCgpGaXggd3JvbmcgaW5pdGlhbCB2YWx1ZSBmb3IgR1BJT3Mg
aW4gYnh0X2V4ZWNfZ3BpbygpLgoKU2lnbmVkLW9mZi1ieTogSGFucyBkZSBHb2VkZSA8aGRl
Z29lZGVAcmVkaGF0LmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2lu
dGVsX2RzaV92YnQuYyB8IDQgKy0tLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp
LCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp
c3BsYXkvaW50ZWxfZHNpX3ZidC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9p
bnRlbF9kc2lfdmJ0LmMKaW5kZXggZTU2ZWMzZjJkODRhLi4wNTg3Y2JjMmU1ODQgMTAwNjQ0
Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNpX3ZidC5jCisr
KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNpX3ZidC5jCkBAIC0z
NTYsOSArMzU2LDcgQEAgc3RhdGljIHZvaWQgYnh0X2V4ZWNfZ3BpbyhzdHJ1Y3QgaW50ZWxf
Y29ubmVjdG9yICpjb25uZWN0b3IsCiAJaWYgKCFncGlvX2Rlc2MpIHsKIAkJZ3Bpb19kZXNj
ID0gZGV2bV9ncGlvZF9nZXRfaW5kZXgoZGV2X3ByaXYtPmRybS5kZXYsCiAJCQkJCQkgTlVM
TCwgZ3Bpb19pbmRleCwKLQkJCQkJCSB2YWx1ZSA/IEdQSU9EX09VVF9MT1cgOgotCQkJCQkJ
IEdQSU9EX09VVF9ISUdIKTsKLQorCQkJCQkJIHZhbHVlID8gR1BJT0RfT1VUX0hJR0ggOiBH
UElPRF9PVVRfTE9XKTsKIAkJaWYgKElTX0VSUl9PUl9OVUxMKGdwaW9fZGVzYykpIHsKIAkJ
CWRybV9lcnIoJmRldl9wcml2LT5kcm0sCiAJCQkJIkdQSU8gaW5kZXggJXUgcmVxdWVzdCBm
YWlsZWQgKCVsZClcbiIsCi0tIAoyLjQxLjAKCg==

--------------GnluoRzsnuYax0s2uyTESTIh--