Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Thu, 2 Nov 2023 15:01:34 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Naresh Solanki <naresh.solanki@9elements.com>
Cc:     zev@bewilderbeest.net, Liam Girdwood <lgirdwood@gmail.com>,
        Patrick Rudolph <patrick.rudolph@9elements.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/regulator: Notify sysfs about status changes
Message-ID: <c2dd0533-3a60-4481-8621-86578e62aab6@sirena.org.uk>
References: <20231005133059.917577-1-naresh.solanki@9elements.com>
 <f8dd6d53-7c0b-4a89-9ec4-400aa242c020@sirena.org.uk>
 <CABqG17iufSniSLZ2vU5fFduFwV2FL8jNzMcsveOgFUME1jXmgg@mail.gmail.com>
 <aa3f5615-dddf-4c94-88c7-494cf7cd80ab@sirena.org.uk>
 <CABqG17h949R+3NFgA1MvPLZFc6zkBi+WRPSE9qP4fCBv5gdXHw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="WEH39aLhKbvS+56k"
Content-Disposition: inline
In-Reply-To: <CABqG17h949R+3NFgA1MvPLZFc6zkBi+WRPSE9qP4fCBv5gdXHw@mail.gmail.com>
Precedence: bulk


--WEH39aLhKbvS+56k
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Nov 02, 2023 at 08:17:35PM +0530, Naresh Solanki wrote:
> On Thu, 2 Nov 2023 at 18:36, Mark Brown <broonie@kernel.org> wrote:
> > On Thu, Nov 02, 2023 at 05:35:42PM +0530, Naresh Solanki wrote:

> > > > We probably should filter the events more, there's events for pre and
> > > > post voltage change for example which aren't status changes so would be
> > > > spurious.  It ought not to break anything but we should still avoid
> > > > unneeded work.

> > > Can you please provide me inputs on the additional filtering needed for this.
> > > Like some list of events for notify on status?

> > I think I'd start off with just reporting things that are obviously
> > errors and not things that should ever go off during normal operation.

> This is what I could come up with:
>         if (event & REGULATOR_EVENT_VOLTAGE_CHANGE) {
>                 name = dev_attr_microvolts.attr.name;
>                 sysfs_notify(&rdev->dev.kobj, NULL, name);
>         } else if (event & (REGULATOR_EVENT_DISABLE | REGULATOR_EVENT_ENABLE)){
>                 name = dev_attr_status.attr.name;
>                 sysfs_notify(&rdev->dev.kobj, NULL, name);
>         }

That's the opposite sense to what I was thinking of - we're reporting
voltage changes and enables to userspace rather than just errors.  My
concern here is that this could generate an awful lot of notificaitons
for normal operation on systems that don't use the uevents, I was
expecting this to be used for errors.  Could you remind me what the use
case is here, I think I might've got myself confused sorry?

--WEH39aLhKbvS+56k
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVDuc4ACgkQJNaLcl1U
h9AP2gf/T9vW4sXkzI9WXS9YG/AYUayuS/T91MPXRfPvenhWPwjUdUUeyVyPcmec
coSmMfbdsWMvD+tqhlqdowUqqJfqiTsRtBzWi4Jk9+u4QId7wbPyGptXiNSMOh8l
N/zipc8O/IFet9DaiWeIeqfvbSC2E68eesOR/sJ9wwHFqM4mcVQREZ+aRfU+0dpW
uW+XSMgXOe2f1ibyEnkKw5doPNpiTo3/RFKI1X93j6PjNN9Fiy9Kjsypmr+UzKW9
1P4YiMZCw8TMLI3duKBRWFydSEalvzKoPjlzp+xYqabl/0K8ICyZ6KgZxvm+677Q
2YRB8g2o/fpnu/iDrkhlrhAHqF6jUg==
=ipEo
-----END PGP SIGNATURE-----

--WEH39aLhKbvS+56k--