Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   "Doug Smythies" <dsmythies@telus.net>
To:     "'Peng Liu'" <pngliu@hotmail.com>,
        "'Wyes Karny'" <wyes.karny@amd.com>
Cc:     <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <liupeng17@lenovo.com>, <lenb@kernel.org>,
        "Doug Smythies" <dsmythies@telus.net>
References: <TYCP286MB214616F6AE3E088C5D781A2EC6C8A@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM> <TYCP286MB21465F970BF56AAE5D0CEB72C6A1A@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM>
In-Reply-To: <TYCP286MB21465F970BF56AAE5D0CEB72C6A1A@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM>
Subject: RE: [PATCH] tools/power turbostat: Fix Bzy_MHz calculation equation
Date:   Thu, 2 Nov 2023 08:31:40 -0700
Message-ID: <002801da0da1$adb83fc0$0928bf40$@telus.net>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQG3BHz+VfofbgYKyoMXwr1Kb5XJSwLFIQsTsJcLg0A=
Content-Language: en-ca
Precedence: bulk

Hi Peng and Wyes,

Just for your information about your recent "ping"s about your turbostat =
patches:

Please be aware that there is rarely any reply. There tends to be about =
2 turbostat updates released per year. Your patches are in patchworks =
[1], as are some others, including an old one of mine from 2023.04.03
Eventually there will be an update, and hopefully it will include all =
our patches.

[1] =
https://patchwork.kernel.org/project/linux-pm/list/?series=3D&submitter=3D=
&state=3D&q=3D&archive=3D&delegate=3D107

... Doug

On 2023.10.29 08:12 Peng Liu wrote:

> Ping
>
> On 2023/10/7 13:46, Peng Liu wrote:
>> From: Peng Liu <liupeng17@lenovo.com>
>>
>> To calculate Bzy_MHz, TSC_delta should multiply APERF_delta instead
>> of dividing it.
>>
>> Signed-off-by: Peng Liu <liupeng17@lenovo.com>
>> ---
>>   tools/power/x86/turbostat/turbostat.8 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/power/x86/turbostat/turbostat.8 =
b/tools/power/x86/turbostat/turbostat.8
>> index 8f08c3fd498d..1ba6340d3b3d 100644
>> --- a/tools/power/x86/turbostat/turbostat.8
>> +++ b/tools/power/x86/turbostat/turbostat.8
>> @@ -370,7 +370,7 @@ below the processor's base frequency.
>>  =20
>>   Busy% =3D MPERF_delta/TSC_delta
>>  =20
>> -Bzy_MHz =3D TSC_delta/APERF_delta/MPERF_delta/measurement_interval
>> +Bzy_MHz =3D TSC_delta*APERF_delta/MPERF_delta/measurement_interval
>>  =20
>>   Note that these calculations depend on TSC_delta, so they
>>   are not reliable during intervals when TSC_MHz is not running at =
the base frequency.