Return-Path: <linux-kernel-owner+w=401wt.eu-S1754505AbXKXCyk@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754505AbXKXCyk (ORCPT <rfc822;w@1wt.eu>);
	Fri, 23 Nov 2007 21:54:40 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753735AbXKXCyd
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 23 Nov 2007 21:54:33 -0500
Received: from srv5.dvmed.net ([207.36.208.214]:48108 "EHLO mail.dvmed.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753676AbXKXCyd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 23 Nov 2007 21:54:33 -0500
Message-ID: <47479260.7010101@garzik.org>
Date: Fri, 23 Nov 2007 21:54:24 -0500
From: Jeff Garzik <jeff@garzik.org>
User-Agent: Thunderbird 2.0.0.9 (X11/20071115)
MIME-Version: 1.0
To: Ian Wienand <ianw@gelato.unsw.edu.au>
CC: e1000-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       Auke Kok <auke-jan.h.kok@intel.com>
Subject: Re: [PATCH] e100: free IRQ to remove warning when rebooting
References: <20071120053044.GE29070@cse.unsw.EDU.AU>
In-Reply-To: <20071120053044.GE29070@cse.unsw.EDU.AU>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -4.4 (----)
X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary:
	Content analysis details:   (-4.4 points, 5.0 required)
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3378
Lines: 78

Ian Wienand wrote:
> Hi,
> 
> When rebooting today I got
> 
> Will now restart.
> ACPI: PCI interrupt for device 0000:00:03.0 disabled
> GSI 20 (level, low) -> CPU 1 (0x0100) vector 53 unregistered
> Destroying IRQ53 without calling free_irq
> WARNING: at /home/insecure/ianw/programs/git-kernel/linux-2.6/kernel/irq/chip.c:76 dynamic_irq_cleanup()
> 
> Call Trace:
>  [<a000000100014340>] show_stack+0x40/0xa0
>                                 sp=e00000407c927b40 bsp=e00000407c920eb8
>  [<a0000001000143d0>] dump_stack+0x30/0x60
>                                 sp=e00000407c927d10 bsp=e00000407c920ea0
>  [<a0000001000e58e0>] dynamic_irq_cleanup+0x160/0x1e0
>                                 sp=e00000407c927d10 bsp=e00000407c920e70
>  [<a0000001000106b0>] destroy_and_reserve_irq+0x30/0xc0
>                                 sp=e00000407c927d10 bsp=e00000407c920e40
>  [<a0000001000508f0>] iosapic_unregister_intr+0x5b0/0x5e0
>                                 sp=e00000407c927d10 bsp=e00000407c920dd8
>  [<a00000010000aa70>] acpi_unregister_gsi+0x30/0x60
>                                 sp=e00000407c927d10 bsp=e00000407c920db8
>  [<a00000010042e300>] acpi_pci_irq_disable+0x140/0x160
>                                 sp=e00000407c927d10 bsp=e00000407c920d88
>  [<a000000100774200>] pcibios_disable_device+0xa0/0xc0
>                                 sp=e00000407c927d20 bsp=e00000407c920d68
>  [<a0000001003778d0>] pci_disable_device+0x130/0x160
>                                 sp=e00000407c927d20 bsp=e00000407c920d38
>  [<a000000100525d20>] e100_shutdown+0x1c0/0x220
>                                 sp=e00000407c927d30 bsp=e00000407c920d08
>  [<a00000010037d0e0>] pci_device_shutdown+0x80/0xc0
>                                 sp=e00000407c927d30 bsp=e00000407c920ce8
>  [<a0000001004ecb70>] device_shutdown+0xf0/0x180
>                                 sp=e00000407c927d30 bsp=e00000407c920cc8
>  [<a0000001000ac4e0>] kernel_restart+0x60/0x120
>                                 sp=e00000407c927d30 bsp=e00000407c920ca8
>  [<a0000001000ac990>] sys_reboot+0x3b0/0x480
>                                 sp=e00000407c927d30 bsp=e00000407c920c30
>  [<a00000010000b4e0>] ia64_ret_from_syscall+0x0/0x20
>                                 sp=e00000407c927e30 bsp=e00000407c920c30
>  [<a000000000010620>] ia64_ivt+0xffffffff00010620/0x400
>                                 sp=e00000407c928000 bsp=e00000407c920c30
> Restarting system.
> 
> I think the solution might be to free the IRQ before the pci_device_shutdown
> 
> Signed-off-by: Ian Wienand <ianw@gelato.unsw.edu.au>
> 
> ---
> 
>  e100.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/e100.c b/drivers/net/e100.c
> index 3dbaec6..8ae5ac3 100644
> --- a/drivers/net/e100.c
> +++ b/drivers/net/e100.c
> @@ -2782,6 +2782,7 @@ static void e100_shutdown(struct pci_dev *pdev)
>  		pci_enable_wake(pdev, PCI_D3cold, 0);
>  	}
>  
> +	free_irq(pdev->irq, netdev);
>  	pci_disable_device(pdev);
>  	pci_set_power_state(pdev, PCI_D3hot);

agreed, though I think free_irq() should come after pci_disable_device() 
like it does in e100_suspend().

auke?


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/