Received: by 2002:a05:7412:b795:b0:e2:908c:2ebd with SMTP id iv21csp505730rdb; Thu, 2 Nov 2023 09:39:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6wlIUqBCmRc5tI27HEYNXBSgCWJW93We5qMUu32GgmKXi0YqG3W0JV7y7LxAHWiqqblPb X-Received: by 2002:a05:6a21:3607:b0:161:76a4:4f79 with SMTP id yg7-20020a056a21360700b0016176a44f79mr12133640pzb.23.1698943168116; Thu, 02 Nov 2023 09:39:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698943168; cv=none; d=google.com; s=arc-20160816; b=IYuTHDhHCk2350mhiFiVBElF0xuOtKnCwhrwus7fhSO7zteSBVZjX/1xs45GColeij 0XpFGsIBuQYMbCyyjpT0xSILog9dgsu1Dhdpot87hUf43ilCARF/jxYTuaFb0BEQWpBd BySmyO2PuoGKc5Zc6yYg2Bp/8BG2r+KBzS5uPq0thfL3Xw/ma3FDVF85xPU/dFBiy2Ks v6FbV5DbvQeXWSd9cHj2hLE9v5vQAIMA8CGkKUdYLhFctX1EpvazMQ7kfVn/jJP0463W syj2SQJXyTE4qWXkoknxL1VJmRycr22Tn5nwP5hZb6+QlRvcPla3vJ/Rqig8y4gL8JYQ Xf9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=kmdCFuNosBAt2YCKTuiIufjW7EWkmvZiDcBt4+dO64Y=; fh=ncr8ZaSLjGjnnAS2PtKJfjvJzObSD3HJkB2L202vEdI=; b=Po7ju80EA7/Cy7P0Zuh+LxPd007z9ey6pyFJdaF1QwOLKeUE2bCGJ1kGxVfAi4l9pJ EkXI8OTIvcoEehW8QNXSgyh4j/+sumz+qa3FSCW1CtXVkAV6WMxoKy1vsob8bUwB/9ei OYA4tQK1J7VLuGWbI4bX/jbFjjvN22PsKjVtnX3nPdNn6x5cHcgwPgXjs0Y1Bq/cPYlr bY5nEccv6/j9th80FfdJ7/sydPfNTwpK1zbyQ8+iQ3EXqzP6nuZENZ48YyrKVjn4J4VR sIRGX3vhjWACMtM/eges2mM7zuG0u5xUo3aawxU5HYWXM7iNJB64A8n7GY3xc5WhA/Km sxMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CPazedrG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id bk13-20020a056a02028d00b005b930582e76si2065868pgb.892.2023.11.02.09.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 09:39:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CPazedrG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 698C38133CA3; Thu, 2 Nov 2023 09:39:16 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376886AbjKBQjA (ORCPT + 99 others); Thu, 2 Nov 2023 12:39:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377128AbjKBQi6 (ORCPT ); Thu, 2 Nov 2023 12:38:58 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7996197; Thu, 2 Nov 2023 09:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698943130; x=1730479130; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TbgSOUP/KBLYQvMLt1e9jTgTHS7bUT2DGs5jbUlh/Cc=; b=CPazedrGsSez9xyXLEqN7Ve6DHspY5smfnMxH1IOPOKfDxn9C26H5ki1 E1mn2pyxoKIwrUAHZSir0opyxW1fbe1b2juUBoNjF3vdLmfqKDV4NTvrd ZQwdtTVfkooGiD/SSyyciChxgCOftYFhC4hrMGCt6sT9S3LMxVcy4W4Yq +2IlNlt4mI92+eiktmIhSJoYTTTdxAtboadoACvaxFa9tZHjfHYQg89kD dCaydPOGgKEA1I/0SWXRM2QixpzqTqC/Lxeq40Z6u800fUprrqKdW0dU9 KmLm595eIFrPNNCdPxlokkqG0P/CmljYX7bdGsEHZTFKzMeSyA6NnAFh8 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="419863626" X-IronPort-AV: E=Sophos;i="6.03,272,1694761200"; d="scan'208";a="419863626" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2023 09:38:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="851974439" X-IronPort-AV: E=Sophos;i="6.03,272,1694761200"; d="scan'208";a="851974439" Received: from kookjinl-mobl.amr.corp.intel.com (HELO [10.212.164.123]) ([10.212.164.123]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2023 09:38:49 -0700 Message-ID: <203cf76c-3855-408c-9a7c-8ff3f74a88bd@intel.com> Date: Thu, 2 Nov 2023 09:38:49 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/lib: Fix overflow of variable m when val >= 1410065408 Content-Language: en-US To: Colin Ian King , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231101153237.2214698-1-colin.i.king@gmail.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20231101153237.2214698-1-colin.i.king@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 02 Nov 2023 09:39:16 -0700 (PDT) On 11/1/23 08:32, Colin Ian King wrote: ... > int num_digits(int val) > { > - int m = 10; > + long m = 10; > int d = 1; > > if (val < 0) { Isn't this still broken on 32-bit where sizeof(long) == sizeof(int)? Seems like we need 'm' to be able to hold values that are ~10x larger than 'val' if we need this to work for the entire int range. Also, performance doesn't matter here at *all* with the current use in a couple of printk()'s. Just making 'm' 'long long' or u64 probably be just fine.