Received: by 2002:a05:7412:b795:b0:e2:908c:2ebd with SMTP id iv21csp535717rdb; Thu, 2 Nov 2023 10:26:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEyNb/8gSvY291b4OshrKu1buEm53+JzFAJY9dZTDsxWGUUtp5N2rh4kftM411eSM1DQ8CU X-Received: by 2002:a05:6a00:10d4:b0:690:c75e:25c8 with SMTP id d20-20020a056a0010d400b00690c75e25c8mr18524275pfu.7.1698945996469; Thu, 02 Nov 2023 10:26:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698945996; cv=none; d=google.com; s=arc-20160816; b=LdQQePxzwIlBgxnUB95GeIktTM5J3EXxtM04bG1+Y+st/9xUCzJjrg5LflO49Ilmb7 BDKWgg89y6Uh7gHLyn/ZcEoG/aZir09jkaPKZs3a4vOYRnyBahNb5gsWKzal1rrQq4x3 FgbEUcFQkGWOyReyAYg4PuNq1a6LqH6E1heNWEkcA7zaAS6hDIO6VD6CAqkcP9EyBCeN 2DyfvwHjRgKAV6wzc9jWdlX0MS+3NpUKi00nk0roNTkXHuM/mvNyh5kY+zy2fPT3G823 tLwJbZ7pIOGOBZ+EhPGus018UwKQfqbqx4iKAKJKEKbqb8+t99mQ20ZV2rGrezts6prG OTWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=u5nTFczinMbKC419gGXDYXffxQCYXXRjYzsEU4unQ0k=; fh=i7PxnWV9Tplw2Rt92djrIsLkm9evZSF8QF7nEJ5PVyE=; b=NFunLO5gFFHxQpxg787/xqqLgRl8Lwa4DWrDV/p2keTY9m3E0EEuJZDoIQWT+h+1gp kWPnd0kea80GFDYYBhNux7BGUlwkYd1/tMBl1teIJ0hhJDs9Wphq+Bhqb/RsA2gE1L9/ RBA66MxEjDnMfRklvHBMT1yTRDnWtEnmJbfSIC0ODgV8OBZTmhj0m1B9K5Gz9z5DnwIA ocvkiFxv42gkSw+lBzIBv8aFammuE2ILj08tJvmaZYzRao0O2Akd1UmxcpZxnyNgkPA/ Tkhc9B4qML1LrzpBdSDG2EsSJOT67Mf2VTh31HkUE5V1Y3ePqtdsz6x2bvjm/9axnZ5Y /M/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@spacex.com header.s=dkim header.b=FNmbrpb0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=spacex.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id c20-20020a62e814000000b0069023e4bcb4si36955pfi.114.2023.11.02.10.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 10:26:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@spacex.com header.s=dkim header.b=FNmbrpb0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=spacex.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id C5A2E8075015; Thu, 2 Nov 2023 10:26:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229762AbjKBRZi (ORCPT + 99 others); Thu, 2 Nov 2023 13:25:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbjKBRZf (ORCPT ); Thu, 2 Nov 2023 13:25:35 -0400 Received: from mx1.spacex.com (mx1.spacex.com [192.31.242.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C24B8186; Thu, 2 Nov 2023 10:25:28 -0700 (PDT) Received: from pps.filterd (mx1.spacex.com [127.0.0.1]) by mx1.spacex.com (8.17.1.19/8.17.1.19) with ESMTP id 3A2FpdVM024140; Thu, 2 Nov 2023 10:25:27 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spacex.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=dkim; bh=u5nTFczinMbKC419gGXDYXffxQCYXXRjYzsEU4unQ0k=; b=FNmbrpb07laHEXAFNbjH0N5QJN5rNBJiXT+iS1CfZhHC+3KA7IvxxrykZnApU6HbsfAx 2H6t3MNmcs4vfdgMjLQC8tIX/q3idnuIgYFJJ4l0Cs0dUXgd8z095VAGpcUZrYmJzQIM cJ5H0dxn29U8XkSdYGwt7TdVSASXpAA8HqUeBlziYVGOBcdY6EciFvKfQcFcbumcti41 +QLVLPzuv2whhb0Kq7O3cQbRCdAA8XkLuS1jDZVTjjsxheFADHLBJzXA2I/0gLSmaJ7j HxvY7HfoXmyyfZl0xwLDV810+D/QFpMyNQgD5khvZn6F2MT3dSd+/RRwnYGsNiwgZ6PK ww== Received: from smtp.spacex.corp ([10.34.3.234]) by mx1.spacex.com (PPS) with ESMTPS id 3u0yqhja34-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 02 Nov 2023 10:25:26 -0700 Received: from apakhunov-z4.spacex.corp (10.1.32.161) by HT-DC-EX-D2-N2.spacex.corp (10.34.3.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 2 Nov 2023 10:25:26 -0700 From: To: CC: , , , , , Alex Pakhunov Subject: [PATCH v2 1/2] tg3: Increment tx_dropped in tg3_tso_bug() Date: Thu, 2 Nov 2023 10:25:02 -0700 Message-ID: <20231102172503.3413318-2-alexey.pakhunov@spacex.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20231102172503.3413318-1-alexey.pakhunov@spacex.com> References: <20231102172503.3413318-1-alexey.pakhunov@spacex.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: HT-DC-EX-D2-N1.spacex.corp (10.34.3.233) To HT-DC-EX-D2-N2.spacex.corp (10.34.3.234) X-Proofpoint-GUID: IehV9YORpeDyNv2Cqoen79_rvluU8GBt X-Proofpoint-ORIG-GUID: IehV9YORpeDyNv2Cqoen79_rvluU8GBt X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 malwarescore=0 impostorscore=0 spamscore=0 bulkscore=0 phishscore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000 definitions=main-2311020143 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 02 Nov 2023 10:26:06 -0700 (PDT) From: Alex Pakhunov tg3_tso_bug() drops a packet if it cannot be segmented for any reason. The number of discarded frames should be incremeneted accordingly. Signed-off-by: Alex Pakhunov Signed-off-by: Vincent Wong --- drivers/net/ethernet/broadcom/tg3.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 14b311196b8f..99638e6c9e16 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -7874,8 +7874,10 @@ static int tg3_tso_bug(struct tg3 *tp, struct tg3_napi *tnapi, segs = skb_gso_segment(skb, tp->dev->features & ~(NETIF_F_TSO | NETIF_F_TSO6)); - if (IS_ERR(segs) || !segs) + if (IS_ERR(segs) || !segs) { + tp->tx_dropped++; goto tg3_tso_bug_end; + } skb_list_walk_safe(segs, seg, next) { skb_mark_not_on_list(seg); -- 2.39.3