Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <1e948a35-b450-444f-ac1d-5bded729422a@intel.com>
Date:   Thu, 2 Nov 2023 10:46:20 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 01/24] selftests/resctrl: Split fill_buf to allow tests
 finer-grained control
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231024092634.7122-1-ilpo.jarvinen@linux.intel.com>
 <20231024092634.7122-2-ilpo.jarvinen@linux.intel.com>
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231024092634.7122-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1NQZ1QzVkRBZnFQQTVuUDVpWHFHQ1p2bmVMVzVabEJ2Ly85WHExcUFOczFP?=
 =?utf-8?B?UUROK3NGa2FlRVBOZGN2ZmNndFc1ajJWU0dQQzdaVDFVRk55cFQyVHJXeHYv?=
 =?utf-8?B?c292TDBqRGFyOUI1eC92d3crdUUvbGYrWTJQVElwZENZT05qckJTa1pjMG9o?=
 =?utf-8?B?c3p3U2dubjFvRThLZGNpbHd1OWFYNUsrV3lZNGgzbVhYNW83TUhlK0FHd0hH?=
 =?utf-8?B?U1lYcnlMMUo1ZW5nTmJNdG1Cd1dKRnRDNWlENVhHZGxFNDR3NmR2eGczNTll?=
 =?utf-8?B?bUxDOWZoYTl0SXRoUVo5YSsyaDhIYmUwODd2bC83TW5hUnRpUUFNSzlTRkpO?=
 =?utf-8?B?RDU5TDBTU0JUcWdseEw1WVhFbmNMTDNPWnlESjZLQlhFNEx4R3p1S2o3QlAx?=
 =?utf-8?B?MDdzSFNxdlRkRFVGNnZpL21INWFQYStXVEFHU0hkWXU1R2szVEhVVGtNUHZ4?=
 =?utf-8?B?dXMza1RkQm4zOTJNN0dJVlgyeDhUdUx4NndRTEFGNk4wTm9JcUNZV3dkL2M4?=
 =?utf-8?B?Snp4Ry93MDhUcC85cHllcDJpcUNYdHJMNU5EYmlCRnArb1BYZSs0VjRwcEEv?=
 =?utf-8?B?VnJEd1B4OHBaa2toZWIxT3dIUGVtWExSM2c2WXQrazNtbFE0RGxQQlptNm93?=
 =?utf-8?B?ZGs3ejlVdVVOTFQ5ZjRjY3ErTjVrWVluS2JCcHo1dTIwUHhES2ZOM1RtLy9D?=
 =?utf-8?B?ZGszYTJxUFpmNC93N3ZFMk1CNm1mOUJOVU1IZ051ZHN1RlFaZkVHSzkwUHdI?=
 =?utf-8?B?RW53N0d5eVhKUHp0aDlPZE9TUmNSQm5Nd2FodWtSR0tEYjF4UXNHQ2ZqeXJz?=
 =?utf-8?B?cnV0OElxRjRuVVUzNUVoc3ZUQ3RUVGhYTW1LQjFJZ1h1ZzFDU2hOZTdCTFlx?=
 =?utf-8?B?RkFEb3gvelh6SzFoQk9FL3VuaGxzZllRVTVlYUpJa21SVTRIN1IrdHE5cnpj?=
 =?utf-8?B?N0g0WE00alMwclc0UWQ3SVF1dFBjOWxHaGVzMEcxYzYvbFZ2dVpxalYydjlP?=
 =?utf-8?B?Y3J6SHpSZUlJTkRlNmdKcVpmTzdSTk53MDcyVFkrNjRxOVkrKzgwblJwSmFj?=
 =?utf-8?B?QkVVd0F2U1RjbENpVlZWbUhGRXB4dnRseXpzN2JkbmRKdzRNOVFyOE4xM1JN?=
 =?utf-8?B?T1JwWm1iQ3BIaWJMbVp4enRmeEtuOEowc3lXVytjR1o4SVpMaHZzci8vc2Qy?=
 =?utf-8?B?M3hMdk1pUjgra2IvS3orSkJXRWRIc1Z2cmVQZWVvU2NIRml1cWJZeGxRUTVz?=
 =?utf-8?B?Q1dZVnRWQmxHaWZERHJQVEtRMkE4TUphWWFQb1ZoMDBDdndtamJaMUYwaTdu?=
 =?utf-8?B?QUwwaEIzU2pBMkFwUXJkbXdVQ0YveHBhRlp4S2duOE52VVhTODNKUUN1Ni9P?=
 =?utf-8?B?eTUvN2QrNndzVnhBeFZBK3VwK3JaN283QnpEZHpKYXJBQ2hqSFlnOE9BTDY0?=
 =?utf-8?B?MjNLQWpnSlV3WWYzcGZsVjVjU3g1WFR4SThrY2FtaW53K3FEUlIyTGxMdDBS?=
 =?utf-8?B?OWhFY21QYVIzNkxtT3d5K3RDTm5HRkJRc25kYUxwai9aQ04vWDRPNm0vK0FQ?=
 =?utf-8?B?djJsTHdnbjYvMUFWS2xkbnFEdFV6N24vZ2tUc1RvZ1NxOGVEQjF1RDloZnJp?=
 =?utf-8?B?UVZMaEhEcXB5aHRtSStrNU5KVEF6bEdZZlRHajRRQ0hscmJTYXhINDZIQkdN?=
 =?utf-8?B?bEFSQVBJWFUya3F1eEx0SVlRZWxYYnZXMU5TL2I4MWJiS3E5eEt1RzFXaEJ6?=
 =?utf-8?B?LzVZaFdwMThiOGpROXpHbDhqTzd1V1k2RVczcENuMWQwS2Y3bEdOZmVBbDc4?=
 =?utf-8?B?UVc1aHFPdndZMVY4eWFVbkZQQURjNFhtUDJwZ3BTbDBvNDBnbGFCKytnaTE5?=
 =?utf-8?B?QnJ5cXo0TUdQWXcwTzVFQ1BsamZ6eWJINFkzT1VnZGNUNlBxVWpta2xHWkxN?=
 =?utf-8?B?UEl1ditDdHlaYVNTUFZZV0t6S2lkQkNDS1kvWnhHcFFqaEMzMEswNUI3aHNi?=
 =?utf-8?B?VUtXcGRnVExGM25NZzVIQlV0QmZhYVRYRysvd09STWl3dUtUaDkvOXNleTlk?=
 =?utf-8?B?ejJCdW1MbkVtZTVIWWo2Q3FOZ2d0ZGJJRHNIeVFIQkw1endscTFCSXlEUGR0?=
 =?utf-8?B?L05LOTVoSENON2x6bWtYWXBDVlB0SnhGQlM3aXhKY3dzc3RSb0Y5R1dDZTVQ?=
 =?utf-8?B?MFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8bbcdc35-a8c8-4147-ce4f-08dbdbcba11f
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 17:46:23.2998
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g72c/9sYyQ/xsDyYtL4OMvJNwkpQxB47PuJLvX+/VN1QMr3JkDk6Bn06JF+eE6ZwM18Y1WLhtHWetZf5Sk5sgJrhdZLgx4NwLofAYPkydEU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6857
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 02 Nov 2023 10:46:50 -0700 (PDT)

Hi Ilpo,

On 10/24/2023 2:26 AM, Ilpo Järvinen wrote:
> MBM, MBA and CMT test cases use run_fill_buf() to loop indefinitely
> around the buffer. CAT test case is different and doesn't want to loop
> around the buffer continuously.

Please do not that the changelog starts by describing issue with
run_fill_buf() (that does not appear in patch) and then switches to
describe solution for fill_cache() below.

> 
> Split fill_cache() so that both the use cases are easier to control by
> creating separate functions for buffer allocation and looping around
> the buffer. Make those functions available for tests. The new interface
> is based on returning/passing pointers instead of the startptr global
> pointer variable that can now be removed. The deallocation can use
> free() directly.

Seems like startptr removal has been done already:
5e3e4f1a03f0 ("selftests/resctrl: Remove unnecessary startptr global from fill_buf") 

Reinette