Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <3849d986-caf4-41ad-85c7-11f11f986e1c@intel.com>
Date:   Thu, 2 Nov 2023 10:47:33 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 05/24] selftests/resctrl: Create cache_size() helper
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231024092634.7122-1-ilpo.jarvinen@linux.intel.com>
 <20231024092634.7122-6-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231024092634.7122-6-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWxNbkpvU3FMM010TzhjQklxd1BjbWx2K3BDUUl2d0NBeHY0YlhoR0lxNEdo?=
 =?utf-8?B?QXY5YzUxSG93citYZWhidCs1TEpwcFFxMERPbE1XcXpBbHIzUEkyT1N3R0VD?=
 =?utf-8?B?SlI0SDZxd1lLK3lVR2JsNytsNmtnb1Vva0xaSVB3QU84c003OC9HWEYvK3R4?=
 =?utf-8?B?UkVINVhOUWtOKzRMa3NWQWczb0JKaWI3cXh5Uks4RFlVbHZNRW9vbStBMEQ0?=
 =?utf-8?B?RlZ2b0pnbzdjQk1tdHZaV2JMdjZIc0Q3aHV1UHQ4WVcrT0ZIWGNxc25ZeW1K?=
 =?utf-8?B?TEhPY0xtem1BZHEyblZrdUlmYWRXQzV2am5FQmQvRVhZa1RUY002Ty9ScTVa?=
 =?utf-8?B?eDZwUEdwZWdzbERjaTMzWjFFOUljK0J3eGZxQmI5N2dMRDBIYnZJamJ2RG9E?=
 =?utf-8?B?Q0JGRklDK2l1MnV3bkcxSEwwUzRlay95bE83THJmRmR6TUNhVENJL3MzZ2I3?=
 =?utf-8?B?ZzIvWkpFV0hrOU02bm1nR3J0TkQ0MElHd1hlZWhtMVVkcjBESFNHUndVUFln?=
 =?utf-8?B?WitaWXl0U0Z2ZHFKZDlCdDZkcTErLyt4WStIK3VDcjN2ZWd0aktqZlRWTWZI?=
 =?utf-8?B?Yjd2a20xaExtWDVxRUdTZEZOVDl2eWtaRXJpK2JveGdpVGlGRUdnUTJCbEYz?=
 =?utf-8?B?ZlFlRW1OZCtyNEQ1V2l5dk9ITW0wVW1qYy9sUG8vUGNhN3ZJc2hyWk80bGNa?=
 =?utf-8?B?d1pQQ1V0aVZrMzdiSEkzMDBpMzRrVVFnOUdYeHJRK09aeUR6T0NDTkw2QWJL?=
 =?utf-8?B?RHIyOTdrS1FXbDJuRS92VXBzWkFmVHkwdndJYSs4a2VaZFd2cy9aV3EzMnE2?=
 =?utf-8?B?azd6VlJMcmFBT01sWlk3R2dGS3FPRFZtWFQrbnN5MzE4M2VNcU5jcGhUQUM5?=
 =?utf-8?B?SlFLa1JNQ1I2U1FYYkRPU1dOUUdCQVlCcE9tbW9JeU5jdGlNMkNZTnhQOVVX?=
 =?utf-8?B?MGorR0diTUZ5YTMySUMrOXdjVm4zQjM0SlVIUDRmMzdNbGxsd0RvQnNyS2Zq?=
 =?utf-8?B?ZjJIbmhISjFnYnNlbVNxSkcxR2EzeWN2WTBPa1ZnbTRjUWZIZzJaNlErb2Vp?=
 =?utf-8?B?YmwzL2pUZzdLaXhXMWk2U2V1KytjVndPNzZLSENLWHlLZ1c2ZnlzUWNvRW1p?=
 =?utf-8?B?aWNBSDJkUFl4eDErMllVekFHYjh1ck1NVUFGc0NxbmsxTHl3SFEvUnFWOXUx?=
 =?utf-8?B?TUQyYVFCZThpTHplT0xMend1ZGtTSjk5K0lFU2c2ckg2S3p5NmIyd0tZTWpj?=
 =?utf-8?B?MVRPWE5RMWZ3T3poNk9sd1g0L3dqYkwvVXRZRmsrSXJuc3V3dk0ySDVRUFlz?=
 =?utf-8?B?L0ZVVncyU0pvaW1yVzdjdkxZTGtTdWt6cnRkMVY0YitibTcvdS8rKzhJcFVM?=
 =?utf-8?B?UTBTejV0dk1nUlcyYUxiMi9zNHk0S1RkTWJ1V1pXU0ZnRmY1bnBST2JON0FY?=
 =?utf-8?B?aU9jNUFRZ2JBcjFqdFJUNXdZQmlBM0lmMHBGeGZNei90SG1jN0UydU04RWpz?=
 =?utf-8?B?dlkwMnFIY0VmL2dWTmtHTGwvKzVHQTZKSDhBUHR4dlMzTGdHQ1Q4bjlPbnBH?=
 =?utf-8?B?dHJoNWduR00wTS9QQjc0L2lEdG9UQjlPNVZFSlBONndYQm41ZHE0OUIwcGhX?=
 =?utf-8?B?RXh4Z0VDQzk2UzZXZE80VkN6Tkw1MklIT2JzZ0o4NzRmTWdJQS80Unl2TVQv?=
 =?utf-8?B?elBNUUJyZkFlZFN6SWhqR1c2akRYWWQ4TVBLTXpJZ3czWmJISDdrTTJjNWVS?=
 =?utf-8?B?eXdQLzF6Z09UTnZmNlJCSjV0WVdrQWljdU0vMzJRYXlTWnpkRnlJVTlOdnhw?=
 =?utf-8?B?cjZ6ckRXaHlMVWIvY1JqNjU5RkdsRncyNERQNk9sMWZOWUtoVU8waWZkOHg5?=
 =?utf-8?B?Zk5Hb3BZTzdJRU1qM3JnSzQ4WUYxVnVEbmNrN1JiQmI0WTFVM0FhbjNpeldw?=
 =?utf-8?B?RGQ5TzhBeGR2UlpDUmZVd0dwQVREV1RsNXFxcEVBa1VSTGJrdGczdHMzMzBk?=
 =?utf-8?B?RHVFYUlRSndlNUJETllJL0hXelpVclMxc2RRckpLMXNBMk9LcGpzcTZwa2U1?=
 =?utf-8?B?RTlBQ082byt6U3VlVU1xWDVDRnI4ZGJ0R1VvekZwanoxRm05ejhva3pQQlRD?=
 =?utf-8?B?OHU2SS90S1VaNjBBdjZaNmI1NFhPZW9WK2VsbDVqbnBBSTAybGdHUDhwS3Ry?=
 =?utf-8?B?clE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd83f3ef-8eb1-4fc0-c234-08dbdbcbcb27
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 17:47:33.7319
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: USSZzLy/Ho7DtGO2AeYf2G5TWpmsempc1KJ0yCiRpp0nKu4tfWXdzEewx/MWfgS+QFRDHqgTLicyBLNeJzYzhak/eZXgzgC6gSx8yj7vofY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6857
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 02 Nov 2023 10:48:11 -0700 (PDT)

Hi Ilpo,

On 10/24/2023 2:26 AM, Ilpo Järvinen wrote:
> CAT and CMT tests calculate the span size from the n-bits cache
> allocation on their own.
> 
> Add cache_size() helper which calculates size of the cache portion for
> the given number of bits and use it to replace the existing span
> calculations. This also prepares for the new CAT test that will need to
> determine the size of the cache portion also during results processing.
> 
> cache_size local variables were renamed out of the way to
> cache_total_size.

Please do stick to imperative mood ... "Rename cache_size local
variables ..."


...

> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
> index 2f3f0ee439d8..da06b2d492f9 100644
> --- a/tools/testing/selftests/resctrl/resctrl.h
> +++ b/tools/testing/selftests/resctrl/resctrl.h
> @@ -117,4 +117,18 @@ int show_cache_info(unsigned long sum_llc_val, int no_of_bits,
>  		    unsigned long max_diff_percent, unsigned long num_of_runs,
>  		    bool platform, bool cmt);
>  
> +/*
> + * cache_size - Calculate the size of a cache portion
> + * @cache_size:	Cache size in bytes
> + * @mask:	Cache portion mask
> + * @cache_mask:	Full bitmask for the cache
> + *
> + * Return: The size of the cache portion in bytes.
> + */
> +static inline int cache_size(unsigned long cache_size, unsigned long mask,
> +			     unsigned long cache_mask)
> +{
> +	return cache_size * count_bits(mask) / count_bits(cache_mask);
> +}
> +
>  #endif /* RESCTRL_H */


The get_cache_size() and cache_size() naming appears similar enough to me
to cause confusion. Considering the "portion" term above, what do you think
of "cache_portion_size()" or even "cache_portion_bytes()"?

Reinette