Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <d22a4ce2-9e81-4d65-8381-e5ab5fa706ed@intel.com>
Date:   Thu, 2 Nov 2023 10:51:48 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 17/24] selftests/resctrl: Create struct for input
 parameter
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20231024092634.7122-1-ilpo.jarvinen@linux.intel.com>
 <20231024092634.7122-18-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231024092634.7122-18-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFp4NDhYd1F6bFdMTElwYVhMcVdhbFgvZG0yTVhhNU9oZys1K2VVTkVTSVdR?=
 =?utf-8?B?dHgyM0JaNVBnVFVzV3EwOFBTaFY3dEV6U01KOWxTMHJ6U1N2NDJ5dTArbkIr?=
 =?utf-8?B?T29XY2h2WjVzS3J6TmhSeENmTDluQXh5dFR3RW5VS1c3aDh0cFhBTE9wZzNY?=
 =?utf-8?B?RDNjMzZpeWZxT0JabW1qbmdITit5eExJRmJmWnFMMm9EVUt4UUphYjYxN0Ni?=
 =?utf-8?B?VDBCMWIwcTFvVzVWb0xuM0FhYzZsUDNOb2RZRkRFNGJSTzA4VkxST3lLQUh2?=
 =?utf-8?B?UGJpRWV2VEhlNjlEZzJFeDFRekljeHZGbG5FVnp4S1FKZXlZRm9IN2Z2djY4?=
 =?utf-8?B?M1grOGJCMzhwVEVsT2d3RVluR1M3VGRvTUY0dnpJUSsvb25zY25USmp3VTNh?=
 =?utf-8?B?UDJZbVMzN1Nya1VBZ2VXTDVWSkRmL0l3UTdtNWVqWUpteWV4SVBWdEFJNTNt?=
 =?utf-8?B?REc5cnJRU21rSFA4WGR1NUZWeDNYNDNwbW5EQlhmdnY3ZHhYdC9lblpJbVlR?=
 =?utf-8?B?UzU4b0RNU0F2aEpVMG9TVG9oLytTWWl6NTlVYTRQNnhJcWZ1Q3YwU3krc3J1?=
 =?utf-8?B?RGJZZDdEU2RxT0RiMmFmaHBudnBaZGMyYXZNc0h5M2JPK1lRZDN6MHQweVNF?=
 =?utf-8?B?WmM3d1liRXlPNEFuV1l6VDBUR2dWWnlQdDZNd1BiN05Wd1NVdE9acGQvbDRH?=
 =?utf-8?B?REREaWR0OU45SlB0SmRKWkc0MGdIQ2dpdzdFZTFzajNtTkVFcG51dVpSQWxh?=
 =?utf-8?B?YjFIRnF1ZDI3M3FFMlc0K1RNVjZ3bWlTbmxCRWtiQTBIenhaSVprU20vWktG?=
 =?utf-8?B?MHNFWkhOSnJIZFFsWmZuT0FRVVQxK05QZFlzOUJLUGNPTTZQVktUSEZDZEw5?=
 =?utf-8?B?Y3lpTGpjU3l0T2RJMkZjd0E5UnNxWGpaWDlZeExNV1BldlhhWkdvRXlLYW4v?=
 =?utf-8?B?OWV3SGtZbHdvWWpXWmI2d2Izd3gzVDh2MnpFemVkN1h2WC9USGFBUkMxTDQ1?=
 =?utf-8?B?SytuTzdoZFFYaGcxdmRYSHpyeGRvV2hHT2ZvOEgyNHlLNzM0Y2hPMG9tRW45?=
 =?utf-8?B?ZVVkQzFQbXZ6NEZlU3Z2MnkxbHNMT2VSU0dOMk1vSUJ2UTJoaG1yUEM5Mnhm?=
 =?utf-8?B?MWJuZjgxUk84bjAxbHo4T2ZheS9wQjR6WkZwcHBTL0RXYnhxdXJja2RmaEpx?=
 =?utf-8?B?L0F0TWgrMmg2bWZTZDd6VWNFS3JqOExiYWlIV1J6UUtWSW1mTWVmQ0c5cFFW?=
 =?utf-8?B?WTZYUnFoeG83aHNPT2puV0c5aGIwRnAzejJEam0zRWhRL1NwbXhzWVpTNTV3?=
 =?utf-8?B?bnM0SmZ6MGlZWXlDY2lsbHRaVnNpNmVvR2l0TW1RVnRDVitDZnNNWityd1Rv?=
 =?utf-8?B?Y1dBbStMZjlsOC9PbWx0RDJOcG42ajZlWG4ySUdYZUpKMVB2VEJncUZFZEFv?=
 =?utf-8?B?eG9UUUMvc3FBblhTWjd0R0VuUVRaaWdzcXl0UGRhc0NvanF6TU8ramorR2xC?=
 =?utf-8?B?YnU3UGpPazVqUWgxeWpRdndmYlJ0V0tyL3dIRDBmSE1FSEdKaTZGWWQwVDYz?=
 =?utf-8?B?ak5TeGZJN2JCM2ptTStSR1loYzVjMWsrL3h2MXNNR1Q4eHlJSVl1Q1hBTGNt?=
 =?utf-8?B?Q1pOL2pqRmhPKzAvT1R1bWpWeWdaOWo5WXlwSTM1Zm5teExGYW1TWDF2b0RP?=
 =?utf-8?B?WG1yRzBkaU1vOGRXNTNDdy96S29CZFNMQTBLTnAvY2FtMVorNWFmay9xY1VK?=
 =?utf-8?B?d3ZtQndVSHhkKzNEV0M2VEkwQkt4WnpLeUpJcmROTWZlMmM1ZUlEZ0wwanVO?=
 =?utf-8?B?allUUFhmK3NWWE5pci9oM3dmL1ZYZ2UxYW84T2dWVTF2d1pVMWNlRk9EUlNC?=
 =?utf-8?B?ckdWVGNTaDV3R0o4SDlTMnFDMU9QcTVraTMwWU1aaUJPK1pxSjRqanFCc0Zx?=
 =?utf-8?B?MkVjQVRxZnlFek1BNWJ1b1N5L1pmN21ZUW52aUprVisrb092V0Uwa1Z6elk1?=
 =?utf-8?B?QUZjOWpSYVp5T3FWSkZ0aXk1S2o4VHdXY3FoTWtxQlN5SmRwRllwSys4SFps?=
 =?utf-8?B?ZU84ejdQN0RYUG9DT0pHVnJHSVdPaitlMmFRRVV5NWhZejVJdXkyTVBuLzJ5?=
 =?utf-8?B?UDlZbk1vd1JLeE03UXp4aGFpM1VSLzdUSkpWakJHUUpseVFheHRQTWlxMndK?=
 =?utf-8?B?NGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cea3d09-a2e4-4077-6cfe-08dbdbcc6366
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 17:51:49.1926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Aqjjmay1dP4kBhz4VI8yjay57B4CvSwycEnxUUOhaOhhOlnu58nl60BQAR7Y6eZLQMmQR14u2cQ+s30l8t25pY7p6RtakweS1WbKGlN1dlQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8361
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 02 Nov 2023 10:53:03 -0700 (PDT)

Hi Ilpo,

On 10/24/2023 2:26 AM, Ilpo Järvinen wrote:

...

> diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c
> index d3bf4368341e..5157a3f74fee 100644
> --- a/tools/testing/selftests/resctrl/mba_test.c
> +++ b/tools/testing/selftests/resctrl/mba_test.c
> @@ -141,13 +141,13 @@ void mba_test_cleanup(void)
>  	remove(RESULT_FILE_NAME);
>  }
>  
> -int mba_schemata_change(int cpu_no, const char * const *benchmark_cmd)
> +int mba_schemata_change(const struct user_params *uparams)
>  {
>  	struct resctrl_val_param param = {
>  		.resctrl_val	= MBA_STR,
>  		.ctrlgrp	= "c1",
>  		.mongrp		= "m1",
> -		.cpu_no		= cpu_no,
> +		.cpu_no		= uparams->cpu,
>  		.filename	= RESULT_FILE_NAME,
>  		.bw_report	= "reads",
>  		.setup		= mba_setup
> @@ -156,7 +156,7 @@ int mba_schemata_change(int cpu_no, const char * const *benchmark_cmd)
>  
>  	remove(RESULT_FILE_NAME);
>  
> -	ret = resctrl_val(benchmark_cmd, &param);
> +	ret = resctrl_val(uparams->benchmark_cmd, &param);
>  	if (ret)
>  		goto out;
>  

How about a new member of struct resctrl_val_param that points to 
uparams? That would remove cpu_no from resctrl_val_param
and have everything available when a test needs to run ... not copying
some user parameters into struct resctrl_val_param and passing
others as parameters.

Reinette