Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Thu, 2 Nov 2023 14:01:06 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     bhelgaas@google.com, imx@lists.linux.dev, kw@linux.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        lpieralisi@kernel.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com,
        robh@kernel.org, roy.zang@nxp.com
Subject: Re: [PATCH v3 1/4] PCI: layerscape: Add function pointer for
 exit_from_l2()
Message-ID: <ZUPjaKOeBzZ9EUvg@lizhi-Precision-Tower-5810>
References: <20231017193145.3198380-1-Frank.Li@nxp.com>
 <20231017193145.3198380-2-Frank.Li@nxp.com>
 <20231102165808.GC20943@thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231102165808.GC20943@thinkpad>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3lGQlNMekszZTZkZUhlTTFxS2VJbGlsWWtHdzhVYkVBc1RCZFc3UmdaK2g2?=
 =?utf-8?B?R1pPK0NHMzNVaVM1TDhadW9CYmJvRnJzN2xSc25iYzlvTUVDZUlkYk9ZTTZF?=
 =?utf-8?B?YlpGUklsaVBiN0E5ZEVxTU04cUF0YUsvcGdFWUlyZStaM2FnZGNtVFpFUG1j?=
 =?utf-8?B?VWZHRk1SbDZ3QlQ5RXVUMHlJOFNmSkRiVjJEd3JFL1RZaXF6ZzlCcDBKVmFC?=
 =?utf-8?B?S3ErSUZ6bUI3bGRiU29qbXhnOXVKRS8rTks2Tkg3Mllub1JNdmlGZlpPeXA5?=
 =?utf-8?B?WXRTLzdZQkJzMnlCZkxNMEZwMStVSG94bW5ENGtiaE12citBKy9GNGhUN1Fj?=
 =?utf-8?B?bXdTWHNFK09weXRIbkRXR1ZKU0U2a2FKMTJ6Y2FQRnFhSjVTM1M1S0tDSUcy?=
 =?utf-8?B?c0RVcE80TVlOUmtxNXJWeFlLdkIveXVWcm1TREtEdWF5WEJNc0o1T2EwczJB?=
 =?utf-8?B?b0JzQjJYTVdnOW01a04yY1QrV2tPWlVybGh6S203WUV5aEo4dTBNUzVtbTdw?=
 =?utf-8?B?a1dDZlFuRFdDYUhkNDNrNGluZlA1M0N3ak9lM1Y1c0YyZ3lTTEJnWUMrYlRD?=
 =?utf-8?B?TzlaL21EaWRkS1hLa092RDRIVm1uUzNKSTlFWFBFVXpkS1Y2VTgzSG9wLysz?=
 =?utf-8?B?K2VlcDlLd2lKNk1RcUZjZ2ZrS0RmeDdJWW9UTXZTZ2hmL2dvODNlNzhHUjg0?=
 =?utf-8?B?S3hNUHYvU0YwUTgyUzZVT0h1S0kyL0JpdHZPTmYrM3c5ZXZjbHJZa3ZtaExO?=
 =?utf-8?B?ZUtTQ21sN0UrM1l4d1huU0pqRTlMWEdqeVlqMG9rWm00U0ZkTTdWcVhrRm1n?=
 =?utf-8?B?VkdFRWY0Q1Y4WWFxeW4yREo4TFhoV1ZiSnhUMWFFRWNlTjRJeW4yK3RvaTdo?=
 =?utf-8?B?RHJHSWhkVFdtVUsySmN1d3dNRkw1S1lEeWlERTZiQ3l2SnE1QXVkK3AzSkYz?=
 =?utf-8?B?a003U0lHNE9CSS9tU054bnAzY0VpR25XdnJBWmg1MUlIL1llUWN0dVJJbHJL?=
 =?utf-8?B?ajhFTXc0V2M0WjBSR3I5RzMwdkl4a2IyZHBTWjZ5NmFQckF5R3FSY1dXNmow?=
 =?utf-8?B?MzlxR2lFNWhkUGFkTjZ5S3UrbEt4MW9DNmlFU1d6U09aNTJBNStOaWkxdlk0?=
 =?utf-8?B?SmNzazlzbEhUNHQvc3N6cWQwYW43RStoajJwWnBnZG5UOWdaOWJxeWpSNE5z?=
 =?utf-8?B?N1JzWlRBTjdBUk9NaDJRem9ocU9ZMHVYYzA3bk1Dc1I3TWJEbW1LV3NETU9G?=
 =?utf-8?B?VisyZHc0d1JNYy8xS2RhQk1XTERMYWlnMkdFSW9oaVpBVDR4bllDT1IyN0hI?=
 =?utf-8?B?d0dCTDZaT2RhY1lBNGVpN1pSM051UGlBc0Q3SGVEVkpmYUQzN1ZqVnZudVRD?=
 =?utf-8?B?YStZQXllVStzSEZlRXhxaHFMa0dVSHNLZzgySE5qS2JoOENIL2p1WDNYT01V?=
 =?utf-8?B?T3ZpUmJBZE9MdDNobUpkeUMrek5yMm53clRMYU1xdFRwVFZPOWtoc3RxMVR0?=
 =?utf-8?B?WXgvMENvSld2M1lkWkl1bGdDVkNMU09CV3RodmdkeElZNkVVYlpIYnA2akR2?=
 =?utf-8?B?YnRpK0s1b3REOEt2OUFlN0VUUEhNK3FuV3dFZEY2bG9yWUptK0FQd1FsVGFI?=
 =?utf-8?B?L1JPYWdVc244RUZZQ2QwMkMzMzk5UWdZd2t3Ymx4L29ybGFpOHkvTy9XNXRw?=
 =?utf-8?B?aG1HQ1oyaExKcEJKdDM0YVFNQ0dBUWVVY2dRYTVIT0xqVkViK3IxMWp4TU5u?=
 =?utf-8?B?RFlqSU5nelVKOWFReFZId2F6RU9BdkJvYkJFOXZmTkVPME1wd3U3b2pjNlBi?=
 =?utf-8?B?WEtPUlVob2FIZ3NSWkhDc3hVYllEbVVLbkF3Z0txNmZvRzY4T0RZSDlqVGYx?=
 =?utf-8?B?N2hPcGNVYlh6UFlkbXZpTDFMdkJvUmZwTmRWRndqeWI4YmJBa0NMdlcrMnpr?=
 =?utf-8?B?aXdKdGlxQmVKYmduemVDU0ZVR05PRkFDNWVqVXNxdEVtYUJ3cWY2WEY2dmxG?=
 =?utf-8?B?aWpHRk9GMVNGbUhXdWp4VnhkVGZ3M21qT08ydGFWWEV5SzFhc0dyUFNTa1Zk?=
 =?utf-8?B?bC9GcUpCUS9wT0NTWDBhMVAyRk1OcWU5blcyVythL0ppbmw0S3lEQlpiN1JI?=
 =?utf-8?Q?1kokAH3v/YBDhhpa+2lH6pmje?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae53330a-dd52-4e50-ad62-08dbdbcdb525
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 18:01:15.8325
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AuZwJ69+f1OQqUtZS7K+YF8wwEndvNcvDvgUCwgSunlaAIcnDAfz4rNw/IYFqkeLNkyAyCUeHtQKH/MtaYL3ww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7666
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE,
        T_SPF_PERMERROR,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 02 Nov 2023 11:13:30 -0700 (PDT)

On Thu, Nov 02, 2023 at 10:28:08PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Oct 17, 2023 at 03:31:42PM -0400, Frank Li wrote:
> > Since difference SoCs require different sequence for exiting L2, let's add
> > a separate "exit_from_l2()" callback. This callback can be used to execute
> > SoC specific sequence.
> > 
> 
> I missed the fact that this patch honors the return value of the callback (which
> was ignored previously). So this should be added to the description as well.

How about add below?

"Change ls_pcie_exit_from_l2() return value from void to int. Return error
when exit_from_l2() failure to exit suspend flow."

Frank


> 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> With that,
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 
> - Mani
> 
> > ---
> > 
> > Notes:
> >     Change from v2 to v3
> >     - fixed according to mani's feedback
> >       1. update commit message
> >       2. move dw_pcie_host_ops to next patch
> >       3. check return value from exit_from_l2()
> >     Change from v1 to v2
> >     - change subject 'a' to 'A'
> >     
> >     Change from v1 to v2
> >     - change subject 'a' to 'A'
> > 
> >  drivers/pci/controller/dwc/pci-layerscape.c | 11 +++++++++--
> >  1 file changed, 9 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
> > index 37956e09c65bd..aea89926bcc4f 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> > @@ -39,6 +39,7 @@
> >  
> >  struct ls_pcie_drvdata {
> >  	const u32 pf_off;
> > +	int (*exit_from_l2)(struct dw_pcie_rp *pp);
> >  	bool pm_support;
> >  };
> >  
> > @@ -125,7 +126,7 @@ static void ls_pcie_send_turnoff_msg(struct dw_pcie_rp *pp)
> >  		dev_err(pcie->pci->dev, "PME_Turn_off timeout\n");
> >  }
> >  
> > -static void ls_pcie_exit_from_l2(struct dw_pcie_rp *pp)
> > +static int ls_pcie_exit_from_l2(struct dw_pcie_rp *pp)
> >  {
> >  	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> >  	struct ls_pcie *pcie = to_ls_pcie(pci);
> > @@ -150,6 +151,8 @@ static void ls_pcie_exit_from_l2(struct dw_pcie_rp *pp)
> >  				 10000);
> >  	if (ret)
> >  		dev_err(pcie->pci->dev, "L2 exit timeout\n");
> > +
> > +	return ret;
> >  }
> >  
> >  static int ls_pcie_host_init(struct dw_pcie_rp *pp)
> > @@ -180,6 +183,7 @@ static const struct ls_pcie_drvdata ls1021a_drvdata = {
> >  static const struct ls_pcie_drvdata layerscape_drvdata = {
> >  	.pf_off = 0xc0000,
> >  	.pm_support = true,
> > +	.exit_from_l2 = ls_pcie_exit_from_l2,
> >  };
> >  
> >  static const struct of_device_id ls_pcie_of_match[] = {
> > @@ -247,11 +251,14 @@ static int ls_pcie_suspend_noirq(struct device *dev)
> >  static int ls_pcie_resume_noirq(struct device *dev)
> >  {
> >  	struct ls_pcie *pcie = dev_get_drvdata(dev);
> > +	int ret;
> >  
> >  	if (!pcie->drvdata->pm_support)
> >  		return 0;
> >  
> > -	ls_pcie_exit_from_l2(&pcie->pci->pp);
> > +	ret = pcie->drvdata->exit_from_l2(&pcie->pci->pp);
> > +	if (ret)
> > +		return ret;
> >  
> >  	return dw_pcie_resume_noirq(pcie->pci);
> >  }
> > -- 
> > 2.34.1
> > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்