Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Rahul Rameshbabu <rrameshbabu@nvidia.com>
To:     =?utf-8?Q?Asbj=C3=B8rn?= Sloth =?utf-8?Q?T=C3=B8nnesen?= 
        <ast@fiberby.net>
Cc:     Saeed Mahameed <saeedm@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        Yevgeny Kliteynik <kliteyn@nvidia.com>,
        Muhammad Sammar <muhammads@nvidia.com>,
        Alex Vesker <valex@nvidia.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: Fix reserved at offset in
 mlx5_ifc_fte_match_set_lyr_2_4_bits
References: <20231102175924.3456007-1-ast@fiberby.net>
Date:   Thu, 02 Nov 2023 11:17:26 -0700
In-Reply-To: <20231102175924.3456007-1-ast@fiberby.net> (=?utf-8?Q?=22Asbj?=
 =?utf-8?Q?=C3=B8rn?= Sloth
        =?utf-8?Q?T=C3=B8nnesen=22's?= message of "Thu, 2 Nov 2023 17:59:22 +0000")
Message-ID: <87o7gc58ax.fsf@nvidia.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NG5RbW8zL1k3TGtMVHFzMEF6RDl1cG81SUoxRC9IUUQ0a1daT1Y4UURhbWp0?=
 =?utf-8?B?NzV0blpVR0N1aHljdDF2MGZ2TnN5UkRSZ2tndzh4Q2RWNGJPMHlwbEdLZlNa?=
 =?utf-8?B?dno4SFlPSzVHUFNySnNpaktrc0ZlRklDMU0rdE9LYkJYS0psWSs5NlZwK2tV?=
 =?utf-8?B?ekkyMkxQNWFTenFkZi80dCthRk51RGhNc1RtVm1MdXR0T0VSTDFBemJHRURQ?=
 =?utf-8?B?cjM5SjFqS1JuZmVwOVRycDNDYXU5UU1QbW1sdjFNdjMvK0Y1V3JyQXEyeUph?=
 =?utf-8?B?WVQ4U0xxajFGbjVNQmlNb2RQM3hRbVBYMG9WMEI1emdJQ1d3bXZSV0ZDUUVp?=
 =?utf-8?B?bGZEQnp6MUJ4REpTUFNIV1MzaWRXNzFGZWVIZi95UlVnd0xzREorTnc2eHBx?=
 =?utf-8?B?R1NQbVhtZFdBaVNTT09DclYwR2tUUGs1c0xXS054bTMxNzBsNHFXRTJjMzI5?=
 =?utf-8?B?Sno1eXdwc3F6SkhJeTR1RHRmKzlwMGg1YmpMUExwVHdpTzZjbHNueTZDL2xq?=
 =?utf-8?B?aitmNmM5cmxuMXo2aWE2UUtjMGpOTFFsd2xwMWExSUo1VmloOUlSSk1NZk1U?=
 =?utf-8?B?VVFDWExieW5ENzlvT1lJa2hDS3NoMlJ1NUxXTWZIM2dWQ3pFZHZCK3h3dDQ5?=
 =?utf-8?B?N2JLMmM4U3NVUHhTVE8xOWp4YndzN3BlM2hORnREc3AwZUtMcVVRdlhndDVO?=
 =?utf-8?B?YjZybDhxNFpHb1YvZ1cvN285bVZZZGNxZGFSQmtkUGhyU0MwWDN2RDNTeGxl?=
 =?utf-8?B?YkN5cThqdW9ORXdCNG8xV2xHRzlxZ1ljZjRFays4M215SFEyL1BTNHlnK3RZ?=
 =?utf-8?B?dGM5ZG9yaWpTNVdkbklUdDErWWpjL1ZiWGlzTlNIKzdDRDNKZGJ3ajBRZkZl?=
 =?utf-8?B?VzZxazZ3MzVtSXlNbEFzekcvSzRGY3FJaUpwVm9OdUdUSUZuWDZ4dXlYdi84?=
 =?utf-8?B?Q0pXeVRxTXZiN2x4ZXFHMk5TMWJNMWN0ZEtDR2M3dUR6MHpIY05tb0gvckZl?=
 =?utf-8?B?ZlExTDV4N010bjhBeDBzQ0Rwa2d2eEF2M2tHc3RYY1dVcVE5K3VqVkhEQUhV?=
 =?utf-8?B?ZnROWjRUNzRad2JxV3FCT3BySHFyaXNTUTN6SWcvRmRSK1RJSE5wUTY4ZnNn?=
 =?utf-8?B?dTJVaTdYZVpONXRPKzlJZHRtUTJHZEJ1WDJabXlZbmxqTVp2UVl1aFI2TDJk?=
 =?utf-8?B?Z2NmYzBhM0ZLeWtQanZGdlVIMncwOE5OUzBBTnJ4WWhzWFFCZmtCdVc1bFlB?=
 =?utf-8?B?bEhtbWVDK0s3bnJ4NzVsbzNYWUZaV2Q0N09KUDkrekRhQXdnWjlaV3d4d1By?=
 =?utf-8?B?TzlIN3R0MW0vc2JTMW5WSDA3dTYrVjBLZE5OUGxSc1l5dGV0emdKZkQ1aHRJ?=
 =?utf-8?B?YWp5RDRDM2xReHdrbVlIWVFLL0hKREdCeHRiU05zdUtTbi9BN0tSU3E2cGtJ?=
 =?utf-8?B?Wis5OCtNbUtXbE92SWYyMitqZWJxWVdUYk9wS0JzSFlDVTVhaXlSSXI2UE5P?=
 =?utf-8?B?c0I4OTZoazNoVGhITjA3VjJ0RFVYVFdpdW5wZWRneDJFejV6ekJycitWdHNY?=
 =?utf-8?B?SUlDV3NkZ0Y4b1lUU1NRK1g1WFljY0svZlJnTkZnbTZ6TC8xUGRiMFM0L09E?=
 =?utf-8?B?MzRZVDZIVUxwUGhXb29kOHpwVG05bTlMS0QzSW53UEZja05UREE4dzBtS2pw?=
 =?utf-8?B?ckRyTDFQVk1LWmxjVWhFQkhydnhkZnpOMVBQaGpTaHJCaERoWG1QMTcybmV4?=
 =?utf-8?B?ZTNRem9kWms2cCtrTG80U09qWkNyZm14dFhIQTZqSzBGcW5oVHlkV0tTb1Bz?=
 =?utf-8?B?V0N5M3VrSU55dm9BVFRZeXhmYkVNOTFkZWVrWWoxZ1pWcEovMUJqQXdOWXNY?=
 =?utf-8?B?ZEg5b3JuWGRZdFVoRGxWLzdGOHhnVG5FL2t0SkN0aGV5Wmt5MHNteFdlbE5F?=
 =?utf-8?B?YkhqaHBDQXR6YzZhQU5rMHBJTlJaaVhuTTdQRlBYdld4dWlDQnpCbEIvZ2lq?=
 =?utf-8?B?azZJZWpqSG5INkVCVXIwTmdHQVlvUzhuSXJlZTNKM24zdGdQY3FOV08rdmZi?=
 =?utf-8?B?b3BwUjBBaUN3RkIxV1c4WHQ0OUM2aXdkUmlwTDJNSDdUYUtKM2hHOWV2ZWhF?=
 =?utf-8?Q?54XcVZnCfLCTppTiFw4U3kniW?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c054409-9152-4660-1263-08dbdbd000b5
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 18:17:41.9034
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SbttuBuK4p++6iCNyWJGaraO5wr7n2a3gcCqn7lwhPhX+tCn3B5xiMWvAc8zt55QMvPno+GFAzCQtglzEMYlQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9008
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 02 Nov 2023 11:18:06 -0700 (PDT)

On Thu, 02 Nov, 2023 17:59:22 +0000 Asbj=C3=B8rn Sloth T=C3=B8nnesen <ast@f=
iberby.net> wrote:
> A member of struct mlx5_ifc_fte_match_set_lyr_2_4_bits has been mistakenl=
y
> assigned the wrong reserved_at offset value. Correct it to align to the
> right value, thus avoid future miscalculation.
>
> Fixes: 5c422bfad2fb ("net/mlx5: DR, Add support for matching on Internet =
Header Length (IHL)")
> Signed-off-by: Asbj=C3=B8rn Sloth T=C3=B8nnesen <ast@fiberby.net>
> ---
>  include/linux/mlx5/mlx5_ifc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.=
h
> index 4df6d1c12437..09c50e786ff4 100644
> --- a/include/linux/mlx5/mlx5_ifc.h
> +++ b/include/linux/mlx5/mlx5_ifc.h
> @@ -552,7 +552,7 @@ struct mlx5_ifc_fte_match_set_lyr_2_4_bits {
> =20
>  	u8         reserved_at_c0[0x10];
>  	u8         ipv4_ihl[0x4];
> -	u8         reserved_at_c4[0x4];
> +	u8         reserved_at_d4[0x4];
> =20
>  	u8         ttl_hoplimit[0x8];

In general, patches should target one of net or net-next on the netdev
mailing list as a heads up.

  https://docs.kernel.org/process/maintainer-netdev.html#tl-dr

Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>