Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Thu, 2 Nov 2023 14:21:12 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     bhelgaas@google.com, imx@lists.linux.dev, kw@linux.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        lpieralisi@kernel.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com,
        robh@kernel.org, roy.zang@nxp.com
Subject: Re: [PATCH v3 3/4] PCI: layerscape: Rename pf_* as pf_lut_*
Message-ID: <ZUPomPAwdjFS9HmC@lizhi-Precision-Tower-5810>
References: <20231017193145.3198380-1-Frank.Li@nxp.com>
 <20231017193145.3198380-4-Frank.Li@nxp.com>
 <20231102173314.GE20943@thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231102173314.GE20943@thinkpad>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2RQTmcreDlKZGVUelF5M083TjlZcjh6akkxVCsrbHJ5ZE84bVhEUXVDV0tE?=
 =?utf-8?B?WmxGSGVZK1hQbXExSkNqd1NzLzdQdmtnZTI3N2lBazhLR3lkTG5acVpwaXI4?=
 =?utf-8?B?czVTdGdpT2RzLzF3UXM5ei9JeFZjNGU2UHNkcU85VmkxK1lNYlYvRFlLTG1P?=
 =?utf-8?B?UURBdnI5YW1hM2dBUkdUejlhaE40UkZmclF5SHNyMGZVS25tZ3Y0bFZlWm1M?=
 =?utf-8?B?dUxlR3pUTWM1K0R0bjFraElDYU9nOWNPMWUyaUJXQThGTzAyQkJiNi9RSlFv?=
 =?utf-8?B?ZndXS2Q3RDBYM2FzZ0llNW9RdDJiU21BT0ZJSkpydHR4cHhsL3pKenlIZDRi?=
 =?utf-8?B?NmFtcjNnR3Fvcm12eldWTVAwZFVlWTJqVlN0QXMvN0dGTVZQL0N4NVd6NUlj?=
 =?utf-8?B?a2JFTG45UjNXcEdqd01Jd3VKazdRaUp5b0pxOXRydG1HdWVIS2JwWDFGSS9K?=
 =?utf-8?B?Q3pIRm1lWi8zMTRtU3Jrd2JJRm9DdXFWY1BoMWYvSzhsUENPdG51c1d2aEly?=
 =?utf-8?B?bUFMVkdCU3l5TXd1bWRYckltUUhSVHppcitibzhYWGZ1SEFlMEpkb21GakNh?=
 =?utf-8?B?LzRoL1JSM0M4S3VGdlAyYldTN3ljTFNVbkhjWldDejNsaGphejRuUTdqSXhN?=
 =?utf-8?B?NmtwbmNIWkIxRlZ2WnloWHI0RXA1RjhwTGhIYzlUTUh4ZjBja0Q2YUtwUlpX?=
 =?utf-8?B?eUk3S2tzWE9LZkwwZDE1VHNoVDFzaVhVL1huOFkzdEhPckNHS2RoenlwRmRL?=
 =?utf-8?B?U3JZSVVKL2N2RERYNkhhbVhTMEZweVM2dVhEdVprYzBac3dqUmhQM054K3Jz?=
 =?utf-8?B?QnMrdWZCLy9KWVhsTXpmcHI1Z1lyandGNXhtUjd1L3J5eXZoWXNnQXJKTitU?=
 =?utf-8?B?RzNsUU5OWHkvdGZzbW95UTcwMkUzZmxINFp3NERSZVVwRGhkSVNvdzVSbHc0?=
 =?utf-8?B?eTBlMHdZUVdIZ3ZmQ1ZDTnB1a1hZMmIrUnI1YjQvbGw1L1YranNodS8rRDNm?=
 =?utf-8?B?YTdTSlNzelJNUmdMbVNYRFM4ZEN2M2RVQzJrYS82cWphbjlWSE5KcGxvMXZ0?=
 =?utf-8?B?L2VFZlVnWVNDTmlDckNYMlBCdWNBQVpMaG53MGFzL2Y4dzEwemdGL1FtZGlU?=
 =?utf-8?B?YU1FL3NFNmdtWFdzVHgySFlLVVpCYklnWG1rd1U1UmpsRFFkcjFJdUJyUldh?=
 =?utf-8?B?c2FsMG11S0REMWd6c1hHcUpOdHkzdU5yWlZhT1lHRXRYWE9UOUxGb0szcUdB?=
 =?utf-8?B?OGQ1M2JDYlJlMVlMTk1uRFhDUVdJTStzTkJ6ZVptWkJNWm9hZWszSjVqMFdr?=
 =?utf-8?B?R1Fkcll1NzU4akJXMGtITU9aSFVRb1BMVERZWUhXZlNCWTRFWGpXNldUZVBI?=
 =?utf-8?B?ZmRVTnZJeDhXb25KUGdoOWVuS1lIUGx0RjBmMGk0ZFE0aHJudnJ6Y0p6ajZD?=
 =?utf-8?B?TzdsMmNiSm5MYjlJcWZYUXA3VUxUSTNtbDM3R3diVVAvd0szMGt2ejdod3lQ?=
 =?utf-8?B?b2dKRjJxTUJEVmJDd3lRV1NNMmVYMFdtZGMxVHlJSDAzT21xWk5FMVR6VndR?=
 =?utf-8?B?WlJYcVczVWpEVk1FMSsrWEtkZGxTU1NQVmpUNEhLUk1Sc0tPREtMcURMOUZo?=
 =?utf-8?B?MklZQ2ZzQ0lBWEJ6cStqSDB2eG9ZcmNUUDJjOTcydWV3UjArL3FkNHFKb0dV?=
 =?utf-8?B?a0ZIRkdwNXF0aEJzZHFlVlhqdFgxVHVZM1lMYjd4b2JFaHhpU3QzMHBGL3RG?=
 =?utf-8?B?bW84TTlKT1grc0I0VXhUSnRxMHpEaXRtSUU2Mkh3OHI1N01Zd3JGNENsT1FJ?=
 =?utf-8?B?a3JxSm1qa0JhZkpkNlNiOFZFYWFET3RZN0Y0MWxLeUhEN2E4QXU4elVuTmJm?=
 =?utf-8?B?TXpzc1NOclcvWjIxREFHM1FydTE4aUMzbE84NnF0NTdmc09rVWM0cU9YeVFw?=
 =?utf-8?B?ajdCdFQzT1dkaTJBODQ3WmdzQVk2NFZ2eGg1cjkzLzdxd1ZISlJXeGRJYStH?=
 =?utf-8?B?Unk3TnE5TktOeXBaRWpGdjZzOUFZQWNKR0poU3c4ejJyeU1IZUc3eTNqRXpU?=
 =?utf-8?B?cUZCdzNiM1d3bzVMVVo4Ry9TZFp1L3RNTGM1NUQrQlE3aCtxZG9QdTNzajh6?=
 =?utf-8?Q?bKw4=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21ae8afe-e007-4f76-10e3-08dbdbd0838f
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 18:21:21.1147
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OoJ7hYTEdga/gf31xrhnQ8jMgd7t4oHN/d8p6K68azCHDm6qZpEIh259IanIk5g34SfkpemBYbMAX6avMAvLgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8219
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 02 Nov 2023 11:21:38 -0700 (PDT)

On Thu, Nov 02, 2023 at 11:03:14PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Oct 17, 2023 at 03:31:44PM -0400, Frank Li wrote:
> > 'pf' and 'lut' is just difference name in difference chips, but basic it is
> > a MMIO base address plus an offset.
> > 
> > Rename it to avoid duplicate pf_* and lut_* in driver.
> > 
> 
> "pci-layerscape-ep.c" uses "ls_lut_" prefix and now you are using "pf_lut_". May
> I know the difference between these two? Can we just use a common name?

Some chip use name lut, some chip use name pf. I think ls_pcie_pf_lut_*()
is better name then 'ls_lut_' in pci-layerscape-ep.c to align with spec. 

If need, I can rename "ls_lut_" in "pci-layerscape-ep.c" later.

Frank

> 
> - Mani
> 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > 
> > Notes:
> >     change from v1 to v3
> >     - new patch at v3
> > 
> >  drivers/pci/controller/dwc/pci-layerscape.c | 34 ++++++++++-----------
> >  1 file changed, 17 insertions(+), 17 deletions(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
> > index 6f47cfe146c44..4b663b20d8612 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> > @@ -46,7 +46,7 @@
> >  #define LS_PCIE_DRV_SCFG	BIT(0)
> >  
> >  struct ls_pcie_drvdata {
> > -	const u32 pf_off;
> > +	const u32 pf_lut_off;
> >  	const struct dw_pcie_host_ops *ops;
> >  	int (*exit_from_l2)(struct dw_pcie_rp *pp);
> >  	int flags;
> > @@ -56,13 +56,13 @@ struct ls_pcie_drvdata {
> >  struct ls_pcie {
> >  	struct dw_pcie *pci;
> >  	const struct ls_pcie_drvdata *drvdata;
> > -	void __iomem *pf_base;
> > +	void __iomem *pf_lut_base;
> >  	struct regmap *scfg;
> >  	int index;
> >  	bool big_endian;
> >  };
> >  
> > -#define ls_pcie_pf_readl_addr(addr)	ls_pcie_pf_readl(pcie, addr)
> > +#define ls_pcie_pf_lut_readl_addr(addr)	ls_pcie_pf_lut_readl(pcie, addr)
> >  #define to_ls_pcie(x)	dev_get_drvdata((x)->dev)
> >  
> >  static bool ls_pcie_is_bridge(struct ls_pcie *pcie)
> > @@ -103,20 +103,20 @@ static void ls_pcie_fix_error_response(struct ls_pcie *pcie)
> >  	iowrite32(PCIE_ABSERR_SETTING, pci->dbi_base + PCIE_ABSERR);
> >  }
> >  
> > -static u32 ls_pcie_pf_readl(struct ls_pcie *pcie, u32 off)
> > +static u32 ls_pcie_pf_lut_readl(struct ls_pcie *pcie, u32 off)
> >  {
> >  	if (pcie->big_endian)
> > -		return ioread32be(pcie->pf_base + off);
> > +		return ioread32be(pcie->pf_lut_base + off);
> >  
> > -	return ioread32(pcie->pf_base + off);
> > +	return ioread32(pcie->pf_lut_base + off);
> >  }
> >  
> > -static void ls_pcie_pf_writel(struct ls_pcie *pcie, u32 off, u32 val)
> > +static void ls_pcie_pf_lut_writel(struct ls_pcie *pcie, u32 off, u32 val)
> >  {
> >  	if (pcie->big_endian)
> > -		iowrite32be(val, pcie->pf_base + off);
> > +		iowrite32be(val, pcie->pf_lut_base + off);
> >  	else
> > -		iowrite32(val, pcie->pf_base + off);
> > +		iowrite32(val, pcie->pf_lut_base + off);
> >  }
> >  
> >  static void ls_pcie_send_turnoff_msg(struct dw_pcie_rp *pp)
> > @@ -126,11 +126,11 @@ static void ls_pcie_send_turnoff_msg(struct dw_pcie_rp *pp)
> >  	u32 val;
> >  	int ret;
> >  
> > -	val = ls_pcie_pf_readl(pcie, LS_PCIE_PF_MCR);
> > +	val = ls_pcie_pf_lut_readl(pcie, LS_PCIE_PF_MCR);
> >  	val |= PF_MCR_PTOMR;
> > -	ls_pcie_pf_writel(pcie, LS_PCIE_PF_MCR, val);
> > +	ls_pcie_pf_lut_writel(pcie, LS_PCIE_PF_MCR, val);
> >  
> > -	ret = readx_poll_timeout(ls_pcie_pf_readl_addr, LS_PCIE_PF_MCR,
> > +	ret = readx_poll_timeout(ls_pcie_pf_lut_readl_addr, LS_PCIE_PF_MCR,
> >  				 val, !(val & PF_MCR_PTOMR),
> >  				 PCIE_PME_TO_L2_TIMEOUT_US/10,
> >  				 PCIE_PME_TO_L2_TIMEOUT_US);
> > @@ -149,15 +149,15 @@ static int ls_pcie_exit_from_l2(struct dw_pcie_rp *pp)
> >  	 * Set PF_MCR_EXL2S bit in LS_PCIE_PF_MCR register for the link
> >  	 * to exit L2 state.
> >  	 */
> > -	val = ls_pcie_pf_readl(pcie, LS_PCIE_PF_MCR);
> > +	val = ls_pcie_pf_lut_readl(pcie, LS_PCIE_PF_MCR);
> >  	val |= PF_MCR_EXL2S;
> > -	ls_pcie_pf_writel(pcie, LS_PCIE_PF_MCR, val);
> > +	ls_pcie_pf_lut_writel(pcie, LS_PCIE_PF_MCR, val);
> >  
> >  	/*
> >  	 * L2 exit timeout of 10ms is not defined in the specifications,
> >  	 * it was chosen based on empirical observations.
> >  	 */
> > -	ret = readx_poll_timeout(ls_pcie_pf_readl_addr, LS_PCIE_PF_MCR,
> > +	ret = readx_poll_timeout(ls_pcie_pf_lut_readl_addr, LS_PCIE_PF_MCR,
> >  				 val, !(val & PF_MCR_EXL2S),
> >  				 1000,
> >  				 10000);
> > @@ -245,7 +245,7 @@ static const struct ls_pcie_drvdata ls1021a_drvdata = {
> >  };
> >  
> >  static const struct ls_pcie_drvdata layerscape_drvdata = {
> > -	.pf_off = 0xc0000,
> > +	.pf_lut_off = 0xc0000,
> >  	.pm_support = true,
> >  	.exit_from_l2 = ls_pcie_exit_from_l2,
> >  };
> > @@ -295,7 +295,7 @@ static int ls_pcie_probe(struct platform_device *pdev)
> >  
> >  	pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian");
> >  
> > -	pcie->pf_base = pci->dbi_base + pcie->drvdata->pf_off;
> > +	pcie->pf_lut_base = pci->dbi_base + pcie->drvdata->pf_lut_off;
> >  
> >  	if (pcie->drvdata->flags & LS_PCIE_DRV_SCFG) {
> >  
> > -- 
> > 2.34.1
> > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்