Message-ID: <4747E0C6.5010900@cosmosbay.com>
Date: Sat, 24 Nov 2007 09:28:54 +0100
From: Eric Dumazet <dada1@cosmosbay.com>
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: Ulrich Drepper <drepper@redhat.com>
CC: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mingo@elte.hu,
       tglx@linutronix.de, torvalds@linux-foundation.org
Subject: Re: [PATCHv5 4/5] Allow setting O_NONBLOCK flag for new sockets
References: <200711210728.lAL7SoJO015052@devserv.devel.redhat.com> <4747D00D.1090603@cosmosbay.com> <4747D610.6040108@redhat.com>
In-Reply-To: <4747D610.6040108@redhat.com>
Content-Type: multipart/mixed;
 boundary="------------060804030609060201010703"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2228
Lines: 60

This is a multi-part message in MIME format.
--------------060804030609060201010703
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Ulrich Drepper a écrit :
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Eric Dumazet wrote:
>> 1) Can the fd passing with recvmsg() on AF_UNIX also gets O_CLOEXEC
>> support ?
> 
> Already there, see MSG_CMSG_CLOEXEC.

OK, but maybe for consistency, we might accept the two mechanisms.

The one added in 2.6.23, and the more general indirect() way.

(See attached untested patch for the general idea, you'll have to also add
#if INDSYSCALL(recvmsg)
   case INDSYSCALL(recvmsg):
#endif
)

>> 2) Why this O_NONBLOCK ability is needed for sockets ? Is it a security
>> issue, and if yes could you remind it to me ?
> 
> No security issue.  But look at any correct network program, all need to
> set the mode to non-blocking.  Adding this support to the syscall comes
> at almost no cost and it cuts the cost for every program down by one or
> two syscalls.
> 

OK, thank you.


--------------060804030609060201010703
Content-Type: text/plain;
 name="scm.patch"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
 filename="scm.patch"

ZGlmZiAtLWdpdCBhL25ldC9jb3JlL3NjbS5jIGIvbmV0L2NvcmUvc2NtLmMKaW5kZXggMTAw
YmE2ZC4uMzhhMGI3NyAxMDA2NDQKLS0tIGEvbmV0L2NvcmUvc2NtLmMKKysrIGIvbmV0L2Nv
cmUvc2NtLmMKQEAgLTIzMCwxMSArMjMwLDEyIEBAIHZvaWQgc2NtX2RldGFjaF9mZHMoc3Ry
dWN0IG1zZ2hkciAqbXNnLCBzdHJ1Y3Qgc2NtX2Nvb2tpZSAqc2NtKQogCSAgICAgaSsrLCBj
bWZwdHIrKykKIAl7CiAJCWludCBuZXdfZmQ7CisJCWludCBmbGFncyA9IElORElSRUNUX1BB
UkFNKGZpbGVfZmxhZ3MsIGZsYWdzKSAmIE9fQ0xPRVhFQzsKIAkJZXJyID0gc2VjdXJpdHlf
ZmlsZV9yZWNlaXZlKGZwW2ldKTsKIAkJaWYgKGVycikKIAkJCWJyZWFrOwogCQllcnIgPSBn
ZXRfdW51c2VkX2ZkX2ZsYWdzKE1TR19DTVNHX0NMT0VYRUMgJiBtc2ctPm1zZ19mbGFncwot
CQkJCQkgID8gT19DTE9FWEVDIDogMCk7CisJCQkJCSAgPyBPX0NMT0VYRUMgOiBmbGFncyk7
CiAJCWlmIChlcnIgPCAwKQogCQkJYnJlYWs7CiAJCW5ld19mZCA9IGVycjsK
--------------060804030609060201010703--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/