Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <929f2e54-0778-4376-8cd7-8e1b906924fb@intel.com>
Date:   Thu, 2 Nov 2023 11:49:29 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/4] platform/x86: intel-wmi-sbl-fw-update: Use bus-based
 WMI interface
To:     Armin Wolf <W_Armin@gmx.de>, <maurice.ma@intel.com>,
        <hdegoede@redhat.com>, <markgross@kernel.org>,
        <ilpo.jarvinen@linux.intel.com>
CC:     <Dell.Client.Kernel@dell.com>,
        <platform-driver-x86@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20231102042959.11816-1-W_Armin@gmx.de>
 <20231102042959.11816-3-W_Armin@gmx.de>
Content-Language: en-US
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <20231102042959.11816-3-W_Armin@gmx.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckVJdlYzSGh4eTRxRjVuWjZVVjR3MW4zQUR1bGRSYnlVWjByTE96STd4UkFG?=
 =?utf-8?B?bTBMeWhsTUtmK3psYW1sQ2l3NmJGRkduRzRIZmd3d0NCK0xrclNpNUhEK0NI?=
 =?utf-8?B?MGN5YU9YNzhlUjY0bzZhVkdmTW5hWEtnMmozTUtQYVFFSTB6Q21NQUlCQnRx?=
 =?utf-8?B?SzFIRWwvTnBOV3VwVU00WWJleStzYnFHSE1uanM0eTVSbG1wa3NxdkRMQW00?=
 =?utf-8?B?Unl2czFja3dRdU41OWc2NlJtaVRHak5NS3VLWk9tY3Rzam1nd3JBdzZ2OVhr?=
 =?utf-8?B?V3VlWWNyeGpOaS9rNUpSaGtDZ3Q0bkx1Vk9qNGNxb2pUK01CNjN5SFBReU1E?=
 =?utf-8?B?VnZYQnZvNmp6YytiSzRvR0hDMmlRWlJ4RFB5MWFGbGJCeE5uSS9qMDZlS2Zm?=
 =?utf-8?B?UEVZY00zUlBhMWFoSTh3d21IMFllbTJpRUFpMzdydkx6WUU5a015Vzk4Z2Vr?=
 =?utf-8?B?Vk1BeUwvWU9DdnliK0hOZ0hla1ROUDlZUVFJd3I3WXA4UWJKajNualdBdkZN?=
 =?utf-8?B?Y1hkL05BNmpzdDZ6dWlmQTlIYm1vRi9hME16OGp0cEFFRW5zSWVvWnRaYXI3?=
 =?utf-8?B?OS94T041YUtKekYxcEdDK2RaVjA1MGNZUUptUnZaTmpUS09TVjVqMkxXN1Nk?=
 =?utf-8?B?d1VnRlRDRTZLSk1zcHdkaVVXL052b0NWekJ0WTJkZzYwdU9TeTVYbkpLbnNi?=
 =?utf-8?B?UTQwVENuaFZqbEJGMjJJMHdTSTNDREdWbU9kd3F4UmhXRXo3TmhKVkNWTE9Q?=
 =?utf-8?B?WDRSQzZoUWI1SVFpaFJoZ0ZXeWI4ZGJKQUpJYWgvTVVaNWxTQXlnWThVR3Rv?=
 =?utf-8?B?NXRuREI0cFZ5bEVZYU5JUWx1bjE5enQwcHlRbEQ3ZzRQQndJRFlxOEtXc0RU?=
 =?utf-8?B?Zjd4VmlvQ3B2T25tUVJYSXUrUTNGb0Y5SXkzbldLNndsSTFobHRNUUlvSGpI?=
 =?utf-8?B?dkNvajlJSXNTUTlxQzFEZDdSM3c2NWRQK0hpK3d4b3V0NmlWRnl2cnNOK2p1?=
 =?utf-8?B?c3BEUWlBSTJQSVlqZGFYZzQwWkJybnB3K0RhMWp6dVFrYjRKODFSYlFpZi8z?=
 =?utf-8?B?RGE0VUZadzNnWUlySCtXVGUxVC8zUmFLYkRHcm1kMHVJOGM5ZFRVcnhyeWhX?=
 =?utf-8?B?SGkyRk04RVA1OUdzb0NTS1FsNkVlQXBsWHRPYWE0M0I2R3FFTW9wOS94K1Ey?=
 =?utf-8?B?VVF0REx5TkpCZTV3OUdXdzhJc2ErRjlPUWtuSmcwZUxIN1NCcTdNT1d3V1F2?=
 =?utf-8?B?SnA5SEV3UFRtK1dPQWthdW9HL04wUHR6MUY5S3liZjRLdTMyZXRGUWJmWmNN?=
 =?utf-8?B?SFhrS2Q0NVZzZ0pwbjJKeVNkU2tQcllzL29rL1VnUGlpWUIzaWFOL2NjVWYw?=
 =?utf-8?B?WnA4QjRVQ1NXcTUxbTk0OWpqQTJoMGdhdzVjTmpQL09idEdrb3p0eWVEYTB0?=
 =?utf-8?B?QXdHcGhUZ2lRNEtLNGpWOWh1V0lDMnpSMG9JWXJBQUwxUEVmRjlHd2w1aXZw?=
 =?utf-8?B?NFlQekVBOXdpOThkWGkyS3RCL0VBUHFqS1JFZDVUOGo4dS9QbUUvSEw4RWhk?=
 =?utf-8?B?aG5YeWFtVmlmYjF3YlVKdHd2dWR6YVRqSC9jYmUrWS8yeVVpRFowZTJkeE5S?=
 =?utf-8?B?YVBKRFFvOXBxOTlydy9kWWI3NDY1VFJ3UU9ENktFM3FFb0hIek9jZkJTckZW?=
 =?utf-8?B?bzJqZkt6b1RXZkc2OVNyZDVLZXFtd2JVTXFKS1lrRWY3YkxPR1JaenAxTWZF?=
 =?utf-8?B?OFpQUC8vZ1cvVWZ1YjZIK1hkSjU2ak9IMnlEeGtVckxXZ2VIeUtDWDhRZVY1?=
 =?utf-8?B?VTZoM1V0RU16NXhJbGptS2I4K2ZtVlp0MzRxUnhycVYzUmVxYSt0SWRTTVJU?=
 =?utf-8?B?WGZNNVBXR0xid3BMYVBvZ3ZqS1NKbFVRYXExZjRPOHdoLzJFRlBFcC9PdG02?=
 =?utf-8?B?VG5JYWU5QnlqRWJsdGtPWk5TUTFqcVBiRVM3L3RxRGhhK2h6Z2RBTy9ucEwy?=
 =?utf-8?B?cG9uTjkwYTh4VUJjVDI0V1lCaUdIMDU4d0d1WXZhS3NmV1p4MFpOTVN1TXZa?=
 =?utf-8?B?UDdZL3VOcTB3U2tGQXM3TFpCVWhRZVNVZHJHaENUVmNYclp0Y0I5RmxoSEE3?=
 =?utf-8?B?WEFFQ2JsMkIyRlR2dytqUmhPdUxpamh0V3RCSzNMSWhWWHJ6WTVuUWtHeWFI?=
 =?utf-8?B?bkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 02c54c6b-b760-4d7a-1ee4-08dbdbd473a5
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 18:49:32.4015
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f70TMxx6+ZioU67gj3kNXhuYMuEYGCfMFQUT0LuP+5j4nJWeQZWx0e5YrqgsbFqIlsN9fjO1rDoWxrO8PweX4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4759
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 02 Nov 2023 11:49:54 -0700 (PDT)


On 11/1/2023 9:29 PM, Armin Wolf wrote:
> Currently, the driver was still using the deprecated GUID-based
> interface to query/set data blocks. Use the modern bus-based
> interface for this.
> 
> Tested with a custom SSDT from the Intel Slim Bootloader project.
> 
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
>  drivers/platform/x86/intel/wmi/sbl-fw-update.c | 13 ++++---------
>  drivers/platform/x86/wmi.c                     |  1 +
>  2 files changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/wmi/sbl-fw-update.c b/drivers/platform/x86/intel/wmi/sbl-fw-update.c
> index 3c86e0108a24..9cf5ed0f8dc2 100644
> --- a/drivers/platform/x86/intel/wmi/sbl-fw-update.c
> +++ b/drivers/platform/x86/intel/wmi/sbl-fw-update.c
> @@ -25,18 +25,13 @@
> 
>  static int get_fwu_request(struct device *dev, u32 *out)
>  {
> -	struct acpi_buffer result = {ACPI_ALLOCATE_BUFFER, NULL};
>  	union acpi_object *obj;
> -	acpi_status status;
> 
> -	status = wmi_query_block(INTEL_WMI_SBL_GUID, 0, &result);
> -	if (ACPI_FAILURE(status)) {
> -		dev_err(dev, "wmi_query_block failed\n");
> +	obj = wmidev_block_query(to_wmi_device(dev), 0);
> +	if (!obj)
>  		return -ENODEV;
> -	}
> 
> -	obj = (union acpi_object *)result.pointer;
> -	if (!obj || obj->type != ACPI_TYPE_INTEGER) {
> +	if (obj->type != ACPI_TYPE_INTEGER) {
>  		dev_warn(dev, "wmi_query_block returned invalid value\n");
>  		kfree(obj);
>  		return -EINVAL;
> @@ -58,7 +53,7 @@ static int set_fwu_request(struct device *dev, u32 in)
>  	input.length = sizeof(u32);
>  	input.pointer = &value;
> 
> -	status = wmi_set_block(INTEL_WMI_SBL_GUID, 0, &input);
> +	status = wmidev_block_set(to_wmi_device(dev), 0, &input);
>  	if (ACPI_FAILURE(status)) {
>  		dev_err(dev, "wmi_set_block failed\n");
>  		return -ENODEV;
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index 9d9a050e7086..4c4effc883ae 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -106,6 +106,7 @@ MODULE_DEVICE_TABLE(acpi, wmi_device_ids);
>  static const char * const allow_duplicates[] = {
>  	"05901221-D566-11D1-B2F0-00A0C9062910",	/* wmi-bmof */
>  	"8A42EA14-4F2A-FD45-6422-0087F7A7E608",	/* dell-wmi-ddv */
> +	"44FADEB1-B204-40F2-8581-394BBDC1B651",	/* intel-wmi-sbl-fw-update */
>  	NULL
>  };
> 

sbl driver specific changes looks okay to me
Reviewed-by: Jithu Joseph <jithu.joseph@intel.com>

Jithu