Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <0c87ab95-1727-4a02-92a3-3e0a14f5b715@intel.com>
Date:   Thu, 2 Nov 2023 12:08:12 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/4] platform/x86: wmi: Add wmidev_block_set()
Content-Language: en-US
To:     Armin Wolf <W_Armin@gmx.de>, <maurice.ma@intel.com>,
        <hdegoede@redhat.com>, <markgross@kernel.org>,
        <ilpo.jarvinen@linux.intel.com>
CC:     <Dell.Client.Kernel@dell.com>,
        <platform-driver-x86@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20231102042959.11816-1-W_Armin@gmx.de>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <20231102042959.11816-1-W_Armin@gmx.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXR0WkY5Zk8zaERQbGJSOTlHbW1QQVgybFFqYlZvQ2RoOG9PZGpuME1ucjFn?=
 =?utf-8?B?ZXI0OU1UcktzZVI3T3JDRVVjUUJKSHJVdVpSK3F2ZU81YjBFNmRpUkZIdjhS?=
 =?utf-8?B?czNMMUFSeUVTdHNoenBuN0t5a0xoMXorQ1VoRk1kbWxhbzhLNGVEVFE2alg5?=
 =?utf-8?B?VXBRVWdTT3VETlpxRm8rZ2hFMHhsOGd0K3RrTG9zV3JTeElscWMyaE5mNmk1?=
 =?utf-8?B?ektCNzhJcWpQZDg1K0VBT2ZHeHNTRDBUMFJjRU1jVEkyZC9PcWJMSnFiLzRM?=
 =?utf-8?B?dEFodGJPM2lNUFltN3Zldlord0Jpa0ZiL3FQb3BxR2hXTEpadXZpZ1V2VXQx?=
 =?utf-8?B?dFN5aDF0UUd2NWtNcnhyRlVZN21rTDFNb004M0hqRnJBUCtubkx0RVpSRFd0?=
 =?utf-8?B?RXJOekQrUGt4clA5c2UvRXRwTXNOWXRPeXA5ZUlHU2JFOUZ4c2JHMmpObE1j?=
 =?utf-8?B?Q0FNNHd0SG90UkY4UmhWTUtpOUEzNytFWm5SVllXTHVZZWxGdUhQcy9xTGEv?=
 =?utf-8?B?TE9xNVVxeUR1amswWGtKVFhJTk5FYjdLZ2ZJYzRGRGZqVkVGV05PWlo3WVN6?=
 =?utf-8?B?d2FGcGpYUHQ2K2VnNWVtQzhKRUVndk1UWEU3dFoxYThxUDk4eE1hT0w5dzFO?=
 =?utf-8?B?MVR0N2RQaTh0ajVvUVJYekdMNFVaN1MvYmV0cXBZVnhBQk51MG1FTjltMWxU?=
 =?utf-8?B?Y09kN0Z4czlEUjhRWXNXN29xV1hzTEtLRThQVG1OUUNONDRNNVFqK09WUmdL?=
 =?utf-8?B?Q1pqVzBRMitNcDVqWUI2cE8xU29MZDRPU3BwM0hiWDM5dk56SjBBSEdwL3lp?=
 =?utf-8?B?OHExM1dHT3dZaWgxTHJ5USt0UC9KalY0YVNoSFM1a3ZWSXVHMGR0LzZOaW13?=
 =?utf-8?B?cmhCSnVNWFEwakxKbDd2OGN4b1FvbytGQlFrVDF1V0lSbm0rSFBuVUNidFZt?=
 =?utf-8?B?dWRNUnV6MzhSK1VabHdjbFZWMGZ5NW5FVnRNTFQ1WUhXRzNmTjk1OUlEYXZx?=
 =?utf-8?B?bGNyNDgxMFhwT1cvRDMwSGNjclpOUm45VGhDRjNOeVNwYlQ3OGg0WVNLTGtK?=
 =?utf-8?B?RW5iNnkxWjBKTDV3NllpYTI4RHhrVUIrQUZXeVBOUGN1ZmNjUTVaQzN3TTM4?=
 =?utf-8?B?TFBpQmVZL1NlSFYxSGNjOE9CVU5jL3ZkMmk1L0tMWERWNk9saTduOUwxeHRE?=
 =?utf-8?B?b1U1KzN5YlVZQkNMdEFGNlBNRUc2ZHFIbmwwVTZMdGI0cFJKMkRJa2VZZjFy?=
 =?utf-8?B?RjBhYS92V05BaTRSbmdrcEFza0N2YkZqekN5d0JNWSt3N1BSaFVKSVFZeEo2?=
 =?utf-8?B?TTRjNllkQTAyN1VxRVpTZXpqeFdYR0FFdHNjd3FMZXhpeVdPUTUyOVpMK1VC?=
 =?utf-8?B?eWc0T2RLdEd0bW80QjdHNmtwbS9MMHpxZStBbWErbXdiaUt6NWI4eUxOVDR2?=
 =?utf-8?B?SEp4VmR0eDFDMmtnL0RLUW1uTHhQUllGdWwyY1VYREtzWTJ0MkpDS2hzc2lo?=
 =?utf-8?B?WkEzemlMeVNsRURHbS9sQ01vdm1Gb1p6QTVRWHNHMjVVN0JrS3lPV3BaWkdj?=
 =?utf-8?B?SVJaWnlQemxRRlBnakJvM0pST0xzRDY5RWJqUjhvWXZEQTdrOGY5WHBEQzA0?=
 =?utf-8?B?VUNSRCtUWXBKNVh6cGRKQkZ1WitZSE9qUVYveGY3dVY0WDI3WUV2RmdKamdm?=
 =?utf-8?B?MnZObURwcFlNUFlJbHVHOFg2WXBucG5KcTRlVXdGYndKNVYvL2tmMUpaYllF?=
 =?utf-8?B?L1c2VzF5T1M5eFV1em85ZlEwUU1OaDcvVGZGZHYwQUtNT3lMMHJNMExGSnF1?=
 =?utf-8?B?ZmxqczhRbHgwc2NrNlBiR1Z4ckRTV3hIdzJGR0t3QXBPdndSSVRZUmpkYzVk?=
 =?utf-8?B?SXVoRHVwemRnZVVSY2RCZzI4L0pCQnZieXAxNDBKR082Q3Y1aUF5ZVg1bkRC?=
 =?utf-8?B?M2NVZzlvY1JDYlhRN2FOL3hnTGhWSERoSTBxbU4zK1h2RHE4a3dCTTVMZDJT?=
 =?utf-8?B?R1hNUTRzcHlzdTc3SjFaa0NFWWw2SVJjcHlxVzlORzF1K3VLV1hLbFhxNDc5?=
 =?utf-8?B?WGdwaHExM1BsZzlFM3NlNUZUeU1KNlZjZ3ozVitvN3hwbjFuRGtvQjRWVkJu?=
 =?utf-8?B?TktVcXRnek9lZkI3M01vaXlhNVRLZkNWQ1VmVElFeTZJUUgyaFplU0FZYjVN?=
 =?utf-8?B?N0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ea64be1-c217-4292-8c49-08dbdbd71115
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 19:08:15.5629
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f5thk7gq8EmCB3Ex5ml63msuuOPpK3ajf1Lfh+gpSObydmTn0IhYDINbv2IJ6nyo1nuPAUI/z3tIxpLK0Bl95Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7351
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 02 Nov 2023 12:08:39 -0700 (PDT)


On 11/1/2023 9:29 PM, Armin Wolf wrote:
> Currently, WMI drivers have to use the deprecated GUID-based
> interface when setting data blocks. This prevents those
> drivers from fully moving away from this interface.
> 
> Provide wmidev_block_set() so drivers using wmi_set_block() can
> fully migrate to the modern bus-based interface.
> 
> Tested with a custom SSDT from the Intel Slim Bootloader project.
> 
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
>  drivers/platform/x86/wmi.c | 64 ++++++++++++++++++++------------------
>  include/linux/wmi.h        |  2 ++
>  2 files changed, 36 insertions(+), 30 deletions(-)
> 

I noticed that this patch doesn't apply ontop of the latest released tag (v6.6) (the other 3 applies)
Just a minor suggestion  :
Perhaps a note on which tree/base-commit the patch would apply would be helpful for reviewers

(After some digging around I found that the patch does indeed apply ontop of your patches submitted for the merge window)

Jithu