Received: by 2002:ac8:6216:0:b0:41c:c224:f26f with SMTP id ks22csp86577qtb; Thu, 2 Nov 2023 12:16:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH6+FXhz15BdoobAwWwMLqkgXRn2FLPpJrk+SUOH/1OHGvho4rO7JsCWuhO2ohjGoT1Yqlj X-Received: by 2002:a17:902:ec81:b0:1cc:6e5e:a980 with SMTP id x1-20020a170902ec8100b001cc6e5ea980mr8920905plg.3.1698952593917; Thu, 02 Nov 2023 12:16:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698952593; cv=none; d=google.com; s=arc-20160816; b=tr+sh2cXJMIGho99QcgvAIixWdjikT8LCzYKK75oH7R0ioVF/6Z2O19UfoNXDa+2cG Fmh+hMX4akPMHYyWOCRv4fowqgis7dR+gFweC5YqD6kBRWrhjgWNZU6BsBcxJZeNZeV6 ANZ3ZS7hihg1gsK7gcIp/yKCk1V8t5CHdHiegIZIhtqdr46jTEecAWyw7ijUEl3+bnMM wHfRfTrwTguVCIdqDP9VxfoRxjvXGFTQGMz0HxedvvSN5PB3omwQ73//W6OcaBYYqvg0 w8jGw+ZjqJR185Sh52HQuV4gVrqvDxQLbpN+kJ5J1GLR3e0l+glrcaswHGEtyVKOnaw/ b3LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=Hi2EMa2JURthjzhOMbj1ijk40LtXcNMKHU4qr6uWg4k=; fh=z7Y4oTJYbJhim9xXZjXURKwE7i+bt2THVU7fT+DjcKk=; b=bOXDhilEMGzYI2L80K82JePKjReocqCdFmNR/zTbpDGth1NTG0/yspm6RyH1zOPFoW rN57PYvqzuNJ6Tak7l9GKrlrnCJ1bGXOqwvz1UlSnzykeFvp6oMl7ysYSNQwkLaf/q32 wLd3pX8XkCDBS/PzuNU8vID9FCZY7CZp/L2/cLZnv9Dl5ryCPoxMfI4IIYH3E7uD1S/y DGUatK23ll+33bnIELzxgCDOLWjR4TRuZHYzZ59Z6rHR6CA6quosGWBpJIE9Fpp8Shk9 /GicJriTYKrhiG6BHxf0/j+gVeDyVw1uqmPPM4aqr5y6J7MBNfx8EkF0esxzjCEQYNEe PWKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id b1-20020a170903228100b001bf1a9dbcc9si130128plh.549.2023.11.02.12.16.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 12:16:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 77FD182291BA; Thu, 2 Nov 2023 12:16:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234389AbjKBTQX (ORCPT + 99 others); Thu, 2 Nov 2023 15:16:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229703AbjKBTQV (ORCPT ); Thu, 2 Nov 2023 15:16:21 -0400 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6639D185; Thu, 2 Nov 2023 12:16:19 -0700 (PDT) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1cc394f4cdfso10455735ad.0; Thu, 02 Nov 2023 12:16:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698952579; x=1699557379; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hi2EMa2JURthjzhOMbj1ijk40LtXcNMKHU4qr6uWg4k=; b=XpIE8qS8NGZqosFK74UwSeizioweoMym5CZOAFSU1BZDzrfcysUx9dAPm/jBc+PFTK fKNZs+9BtnjCnFkAsiJjzlFAesjJMvYRH5p51mmcBiGM4cA6Vb2tbkQI8t9xmP45JFKr BG9a4J61FgZIf4gROcpcI3IF0Ot/qiK0mSOitqFfgZTt01iZaNp4chGT+K0xhtBcKhDo SaAOZBiJxXPe1sSJneTvQIrx8hO2Hli2yzccI8Vd5NiX3dN5EvO53geOqWYrBWcVJauN 2Bsjd9ganw274M+AeFDsZBHkA42gafL6HAlpbpTI0a2qZ9f5ul3/djOegWKcrqHyzipD nATg== X-Gm-Message-State: AOJu0YwoxM6rojURZmfEVxPxoUbB5JpjF1bV4bUGF1pexapOo4eq29kr hIqLfuLyxyfcBc8GWvg6l4g= X-Received: by 2002:a17:903:32cc:b0:1cc:45d0:46fc with SMTP id i12-20020a17090332cc00b001cc45d046fcmr13519966plr.54.1698952578726; Thu, 02 Nov 2023 12:16:18 -0700 (PDT) Received: from ?IPV6:2620:15c:211:201:87f7:9784:4475:1cd4? ([2620:15c:211:201:87f7:9784:4475:1cd4]) by smtp.gmail.com with ESMTPSA id e5-20020a170902744500b001c60ba709b7sm80157plt.125.2023.11.02.12.16.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Nov 2023 12:16:18 -0700 (PDT) Message-ID: <45495479-dc4e-4d89-8c0d-836df83ee18a@acm.org> Date: Thu, 2 Nov 2023 12:16:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] ufs: core: Expand MCQ queue slot to DeviceQueueDepth + 1 Content-Language: en-US To: naomi.chu@mediatek.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Matthias Brugger , AngeloGioacchino Del Regno , Manivannan Sadhasivam , Asutosh Das , Can Guo Cc: wsd_upstream@mediatek.com, peter.wang@mediatek.com, casper.li@mediatek.com, powen.kao@mediatek.com, alice.chao@mediatek.com, chun-hung.wu@mediatek.com, cc.chou@mediatek.com, eddie.huang@mediatek.com References: <20231102052426.12006-1-naomi.chu@mediatek.com> <20231102052426.12006-2-naomi.chu@mediatek.com> From: Bart Van Assche In-Reply-To: <20231102052426.12006-2-naomi.chu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 02 Nov 2023 12:16:30 -0700 (PDT) On 11/1/23 22:24, naomi.chu@mediatek.com wrote: > The UFSHCI 4.0 specification mandates that there should always be at > least one empty slot in each queue for distinguishing between full and > empty states. Enlarge the `hwq->max_entries` to `DeviceQueueDepth +1` > to allow UFSHCI 4.0 controllers to fully utilize MCQ queue slots. Reviewed-by: Bart Van Assche