Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Thu, 2 Nov 2023 15:20:51 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Carlos Llamas <cmllamas@google.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= <arve@android.com>,
        Todd Kjos <tkjos@android.com>,
        Martijn Coenen <maco@android.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Christian Brauner <brauner@kernel.org>,
        Suren Baghdasaryan <surenb@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Michal Hocko <mhocko@kernel.org>, linux-kernel@vger.kernel.org,
        kernel-team@android.com, stable@vger.kernel.org,
        Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH 02/21] binder: fix use-after-free in shinker's callback
Message-ID: <20231102192051.innr2tbugspgmotw@revolver>
References: <20231102185934.773885-1-cmllamas@google.com>
 <20231102185934.773885-3-cmllamas@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231102185934.773885-3-cmllamas@google.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?b9rFFrM+nkKZQYtfXbQhN+NOw9EOsm8SIl8P9GW1GcBq90AEbiAdgaIdeDGq?=
 =?us-ascii?Q?Mlkz1XFHkhdfXb7Ch/eBZ/NMvXf2Qw4cM/JpVTJCxH9Iryhlp780fBUVn8pO?=
 =?us-ascii?Q?Gxsbgv5i7SZfnz4r4gpK+YNPhs+/hF+oHx6Q6apo1KWIBZkVxwjfAgtnOnp8?=
 =?us-ascii?Q?mEuXUnNSHc00UiaIUv/dGIeK4rc9AjCkT31dV5xDhNZNMbpWIFDFhx0t4scV?=
 =?us-ascii?Q?rlR7WNd/oYxWt/hN1CVBVO3tUn6yp4GyMPGewHD6o52yLUE4w9uCfBwmgsM/?=
 =?us-ascii?Q?2160PwJxgUBVapTaQV9EXh+oGGe/vkT38g76lWbCKZDK8UqPqMAKWqzhHz6v?=
 =?us-ascii?Q?N1bMJ8BGMywdqCBiLi+Q8dsiqmgOMS9zYoGh3jGCHWcu/RIWKn4cnGQY8E/m?=
 =?us-ascii?Q?0L1F01B7X+KxGLDdCWWlhxjgwp4mdZu8fuYKzX8DiZuoiA9xLby46+QJJgOi?=
 =?us-ascii?Q?GLJ5N+3h6nqCIuYhlROvp/7JZc/w+7ENr75wphzTPagvsCosw6FpNCmR0L01?=
 =?us-ascii?Q?xcZGMUTgPZxPiyhFUa64dswUf+ku/yK+9l80bQPbgVXxRqY/EmeDljofz/QD?=
 =?us-ascii?Q?vZPjwnfvEiZfxqAoy6T8q0ZMOgz0A6qn3LZ5in38Oyj6b/fWfCZ6nQaFQTSK?=
 =?us-ascii?Q?IaQV0Zo9APyWRUJECag8Pn+hXshuI2YWGeU9ZO0+j5Do7Wkfwy9Ncq/rGFNh?=
 =?us-ascii?Q?IJNxAqtnKQUtq0QduZuwrHsS7L19EH22XZWneRyiP4oAuWMn4s0HZWJ0tJV2?=
 =?us-ascii?Q?nEFdFPHXaIF5yP8STDSY3HTiNnLlxMukssOx8QMQ9fao/G9qFrImU+FK2Zwg?=
 =?us-ascii?Q?YXIy4Pm/E2PQEZaLdnLPjx1C6DhIHoqeqXeXehzhkTDFM6LXhe5iWoeR1gzl?=
 =?us-ascii?Q?nlTZ2tNXQ2r2O7QqdfFnruc3S3FS0ORKZywEKfhox7AVHJPI7ulA5e6SXnXA?=
 =?us-ascii?Q?ZqWfHgMO9QDyK3degFlRhQzOn8zSOeSOXL5RGgNDbeGGHLWhqJh2qVXuvkmS?=
 =?us-ascii?Q?AaVtFMkh9dzY5w5I//D/NtdFZr5S5wo68wLWquWJECVwc4PNQZ2EaI5YGWP4?=
 =?us-ascii?Q?FkXwDRBw/NAdZ0UoBnLtrQFvme8hJWGajr+qPvlO2QUSr9jiRcIYKmdUJB4b?=
 =?us-ascii?Q?W+w4D+1RvMyU//ifzzuzEQJXwp4CBoJOjzK98miZ7fh158JXrjWs4ON7Meow?=
 =?us-ascii?Q?L7DRna0v9LOGhiJaA6uuFicYLl8qNdlPTu85tG6yGgB0zsRS+UY1wcyLwV4W?=
 =?us-ascii?Q?3D77njX/aVdJeETFwgeaF5eyXKXRFmQjuvpgi48oaOx23GWdf4fsXS5jutEx?=
 =?us-ascii?Q?+gdWRaI6wEsCpgAGwor9iaLRE2GRovD6Ge+jBOlcwSmcDeGo5j2z3DEH65az?=
 =?us-ascii?Q?2xTd5Bb4bgIf4PrK+1qJ8U3aEFof4SCSmgQavErUCX/vdzlS6btD0mujMB3M?=
 =?us-ascii?Q?eaYyDcPVFnEb/kcNjCrZeeSxMVDMUZxfgbzQwi4NacTWbYIPOUnphhpADvZJ?=
 =?us-ascii?Q?rMg+SmSgeH939h+FXGJ16UbUUAmRxED5Z1Dvk1iadxLzj97+9q+tg6Sc4WrL?=
 =?us-ascii?Q?8W/c267VG2iOvZuEUq0n1MsN1/t5B57DJPeDvLFX?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?CCo8L6b3hCGi18yUSkay2CyTFyCs2xRsS8LMNhzjOxAvVZq1ZyEezXjZ5RUS?=
 =?us-ascii?Q?wJ83z7zGi/RrgtUj8Du8YLi8xYGu9MtTJoUie1xnHOz5HTQv1LYDqwemIAx1?=
 =?us-ascii?Q?bVNsicnGOsci4ZMkcZObin9I5yhhjnsu/AbNB2HeOj+SqD1/Ca049eNmXNC+?=
 =?us-ascii?Q?F07RjA4PB7GD3OfVtUOt54MnJuyGM++yn9LeLYRGavpnpfaqE2qZK1ZfEcWk?=
 =?us-ascii?Q?gi2o3rkO/Kbkp9Z+UPZfBe0F9cCUgRG/LlFxI9iTefmHT+W1lzNlJvVuFB0V?=
 =?us-ascii?Q?JvvmpGVks4Fq5wSkof9jeA1Cm/bNN26lhkiUSOxFPyD03hwnGL6tP4rLOPM1?=
 =?us-ascii?Q?BiyKRkEyledOevsxtBChFRhZT0dpgsJfazbFVyJ71mLWX6So7elB9LOig+05?=
 =?us-ascii?Q?E62M3ekACp2s9Gbu4m7ZXgUCFs4rqGgUSy4LFntP2MRSbcYtUWaXYo+uVSaz?=
 =?us-ascii?Q?Mx9FkMzqmAFaQwH5gVbBVxuZUZi4XqkU7CLDpMIif0RN6wfHGI2LlPSCp6MQ?=
 =?us-ascii?Q?ipiw5OyrOs9efD2AGtHuX2q/GLohq62DwjHqFvANtBndk2Ivfj+tX1KWqxkm?=
 =?us-ascii?Q?6LPY4GGimhptzq+ICU8RXLc1As8lfK1NxK9yUX2T7vy+r18zsUhT+RqXvQBT?=
 =?us-ascii?Q?a3d+zvKsHfrnPoSuB2YYzaGY/9m6e60r5PM+cINWmJK25V2H04k/ZYQmZc1S?=
 =?us-ascii?Q?fvcUiLyLxMIZr8GpKmvL/ij7Zz7LNuBy3PDabED7qs0ug2s5Uj//7gPPwfZx?=
 =?us-ascii?Q?VMblHbZF9Cn1yXOdY9Ypa179LVJmvRqQxi3My1efYM6WJUMWg3D1MXqe/VH/?=
 =?us-ascii?Q?jsDRS6ePI6Zq1pvF5MEv7uWSyXzTBufiFQQIVPUWR3XDv27bHOk9HrzEA9WL?=
 =?us-ascii?Q?SotVYpuMh/pHx422sPtRgIKqc+FKTp8AmIULAygsUat/24oxNkRwu53p1/n5?=
 =?us-ascii?Q?AubcJSGCdAEF4ymXz85Tmzl94/LCGrkq+1x9EEXC353MDJE3M6TwGsYz4n8E?=
 =?us-ascii?Q?J7SWNy4xtCaCaMLt2v+moOU+ZfQOBqOiRYuf2TMbQtehUAs+YMG8Dm8jAAt1?=
 =?us-ascii?Q?D0YYqfGPCz0mL4bc8scSSadTx/wXVAqm0R8K73N3tcvzqdyFqa4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9efdcf9c-e7f0-4a54-a311-08dbdbd8d552
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 19:20:54.2692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pyjO6VuYlNLZ2uOQQWDTF5hT9zVShgutSWfeq+k2dCGT5zja2UHHvbATolOe3L2/XMrhWZQOORXb/KtPCfyFzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4974
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-02_10,2023-11-02_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 spamscore=0
 phishscore=0 mlxlogscore=863 adultscore=0 mlxscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000
 definitions=main-2311020158
X-Proofpoint-ORIG-GUID: BwWwpUx6kujQTz1robVxXb5ANmNAINdo
X-Proofpoint-GUID: BwWwpUx6kujQTz1robVxXb5ANmNAINdo
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 02 Nov 2023 12:21:43 -0700 (PDT)

* Carlos Llamas <cmllamas@google.com> [231102 15:00]:
> The mmap read lock is used during the shrinker's callback, which means
> that using alloc->vma pointer isn't safe as it can race with munmap().

I think you know my feelings about the safety of that pointer from
previous discussions.

> As of commit dd2283f2605e ("mm: mmap: zap pages with read mmap_sem in
> munmap") the mmap lock is downgraded after the vma has been isolated.
> 
> I was able to reproduce this issue by manually adding some delays and
> triggering page reclaiming through the shrinker's debug sysfs. The
> following KASAN report confirms the UAF:
> 
>   ==================================================================
>   BUG: KASAN: slab-use-after-free in zap_page_range_single+0x470/0x4b8
>   Read of size 8 at addr ffff356ed50e50f0 by task bash/478
> 
>   CPU: 1 PID: 478 Comm: bash Not tainted 6.6.0-rc5-00055-g1c8b86a3799f-dirty #70
>   Hardware name: linux,dummy-virt (DT)
>   Call trace:
>    zap_page_range_single+0x470/0x4b8
>    binder_alloc_free_page+0x608/0xadc
>    __list_lru_walk_one+0x130/0x3b0
>    list_lru_walk_node+0xc4/0x22c
>    binder_shrink_scan+0x108/0x1dc
>    shrinker_debugfs_scan_write+0x2b4/0x500
>    full_proxy_write+0xd4/0x140
>    vfs_write+0x1ac/0x758
>    ksys_write+0xf0/0x1dc
>    __arm64_sys_write+0x6c/0x9c
> 
>   Allocated by task 492:
>    kmem_cache_alloc+0x130/0x368
>    vm_area_alloc+0x2c/0x190
>    mmap_region+0x258/0x18bc
>    do_mmap+0x694/0xa60
>    vm_mmap_pgoff+0x170/0x29c
>    ksys_mmap_pgoff+0x290/0x3a0
>    __arm64_sys_mmap+0xcc/0x144
> 
>   Freed by task 491:
>    kmem_cache_free+0x17c/0x3c8
>    vm_area_free_rcu_cb+0x74/0x98
>    rcu_core+0xa38/0x26d4
>    rcu_core_si+0x10/0x1c
>    __do_softirq+0x2fc/0xd24
> 
>   Last potentially related work creation:
>    __call_rcu_common.constprop.0+0x6c/0xba0
>    call_rcu+0x10/0x1c
>    vm_area_free+0x18/0x24
>    remove_vma+0xe4/0x118
>    do_vmi_align_munmap.isra.0+0x718/0xb5c
>    do_vmi_munmap+0xdc/0x1fc
>    __vm_munmap+0x10c/0x278
>    __arm64_sys_munmap+0x58/0x7c
> 
> Fix this issue by performing instead a vma_lookup() which will fail to
> find the vma that was isolated before the mmap lock downgrade. Note that
> this option has better performance than upgrading to a mmap write lock
> which would increase contention. Plus, mmap_write_trylock() has been
> recently removed anyway.
> 
> Fixes: dd2283f2605e ("mm: mmap: zap pages with read mmap_sem in munmap")
> Cc: stable@vger.kernel.org
> Cc: Liam Howlett <liam.howlett@oracle.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
> ---
>  drivers/android/binder_alloc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
> index e3db8297095a..c4d60d81221b 100644
> --- a/drivers/android/binder_alloc.c
> +++ b/drivers/android/binder_alloc.c
> @@ -1005,7 +1005,9 @@ enum lru_status binder_alloc_free_page(struct list_head *item,
>  		goto err_mmget;
>  	if (!mmap_read_trylock(mm))
>  		goto err_mmap_read_lock_failed;
> -	vma = binder_alloc_get_vma(alloc);
> +	vma = vma_lookup(mm, page_addr);
> +	if (vma && vma != binder_alloc_get_vma(alloc))
> +		goto err_invalid_vma;

Doesn't this need to be:
if (!vma || vma != binder_alloc_get_vma(alloc))

This way, we catch a different vma and a NULL vma.

Or even, just:
if (vma != binder_alloc_get_vma(alloc))

if the alloc vma cannot be NULL?

>  
>  	list_lru_isolate(lru, item);
>  	spin_unlock(lock);
> @@ -1031,6 +1033,8 @@ enum lru_status binder_alloc_free_page(struct list_head *item,
>  	mutex_unlock(&alloc->mutex);
>  	return LRU_REMOVED_RETRY;
>  
> +err_invalid_vma:
> +	mmap_read_unlock(mm);
>  err_mmap_read_lock_failed:
>  	mmput_async(mm);
>  err_mmget:
> -- 
> 2.42.0.869.gea05f2083d-goog
>